Re: [Freeipa-devel] [PATCH] 307 Added extensible UI framework.

2011-11-04 Thread Petr Vobornik

On 11/04/2011 04:37 AM, Endi Sukma Dewata wrote:

The entity definitions have been converted into classes. The entity
init() method will use the builder to construct the facets and dialogs.
The UI can be customized by creating a subclass of the original entity
in extension.js and then overriding the init() method.

Ticket #2043


There is a warning/error in browser when there is no extension.js 
present. This doesn't affect functionality, but I think we should try to 
eliminate this kinds of error. Same problem is for develop.js on 
production machines. This can be fixed separately.


ACK and pushed to master

--
Petr Vobornik

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


Re: [Freeipa-devel] [PATCH] 307 Added extensible UI framework.

2011-11-04 Thread Adam Young

On 11/04/2011 12:10 PM, Petr Vobornik wrote:

On 11/04/2011 04:37 AM, Endi Sukma Dewata wrote:

The entity definitions have been converted into classes. The entity
init() method will use the builder to construct the facets and dialogs.
The UI can be customized by creating a subclass of the original entity
in extension.js and then overriding the init() method.

Ticket #2043


There is a warning/error in browser when there is no extension.js 
present. This doesn't affect functionality, but I think we should try 
to eliminate this kinds of error. Same problem is for develop.js on 
production machines. This can be fixed separately.


ACK and pushed to master

One solution is to have stub  extension.js and develop.js  files with 
nothing in them.  In the case of the extension.js file,   it should be 
there, and served out of /etc/ipa/http.  develope.jss should be  done by 
converting of develop_blank.js  to develop.js  when packaging up the RPM


___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


Re: [Freeipa-devel] [PATCH] 307 Added extensible UI framework.

2011-11-04 Thread Endi Sukma Dewata

On 11/4/2011 12:11 PM, Adam Young wrote:

There is a warning/error in browser when there is no extension.js
present. This doesn't affect functionality, but I think we should try
to eliminate this kinds of error. Same problem is for develop.js on
production machines. This can be fixed separately.


One solution is to have stub extension.js and develop.js files with
nothing in them. In the case of the extension.js file, it should be
there, and served out of /etc/ipa/http. develope.jss should be done by
converting of develop_blank.js to develop.js when packaging up the RPM


I don't actually see any warnings with Firefox, but I agree we shouldn't 
create a broken link. Ideally when viewing the static files during 
development we shouldn't have a broken link either, not just in the 
production machine.


How about this, we rename the develop.js into extension.js, but we don't 
include it in the RPM. Then during RPM install we will touch 
extension.js so we wouldn't override the existing file, and not remove 
it during uninstall either? Then we can remove any references to 
develop.js too.


Is it ok to create the extension.js in /usr/share/ipa/ui?

--
Endi S. Dewata

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel