Re: [Freeipa-devel] [PATCH] 32-47 #2040, #1515 Refactor UI widgets

2011-12-05 Thread Endi Sukma Dewata
On 12/5/2011 7:41 AM, Petr Vobornik wrote: All tests passed. ACK 32-47, 49-1, 50. Pushed to master. YAY! -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] 32-47 #2040, #1515 Refactor UI widgets

2011-12-02 Thread Endi Sukma Dewata
The UI seems to be working like before, so patches #32-47 are ACKed. But I'd rather wait until the unit tests are completely fixed before pushing. I'm going to rebase the HBAC Test patches on top of these. I have some comments below, but they can be addressed separately. On 11/30/2011 10:37

Re: [Freeipa-devel] [PATCH] 32-47 #2040, #1515 Refactor UI widgets

2011-12-02 Thread Endi Sukma Dewata
On 12/1/2011 10:45 AM, Adam Young wrote: On 12/01/2011 10:02 AM, Petr Vobornik wrote: 1) Should widget expect that array of values like ['value'] will be always passed to update(values) method or the update method should also work with simple values like 'value'? The widget tests are higly

Re: [Freeipa-devel] [PATCH] 32-47 #2040, #1515 Refactor UI widgets

2011-12-01 Thread Adam Young
On 12/01/2011 10:02 AM, Petr Vobornik wrote: Attaching patch for unit tests. Couple of widget tests still fail. They raise couple questions: 1) Should widget expect that array of values like ['value'] will be always passed to update(values) method or the update method should also work with