On 3.4.2012 13:04, Martin Kosek wrote:
On Tue, 2012-04-03 at 13:02 +0200, Martin Kosek wrote:
On Tue, 2012-04-03 at 11:58 +0200, Jan Cholasta wrote:
https://fedorahosted.org/freeipa/ticket/2572
Honza
NACK.
This creates a regression:
# ipa group-show foogroup
Group name: foogroup
Description: foo
GID: 358800017
# ipa user-add --first=Foo --last=Bar fbar5 --gidnumber=358800017 --noprivate
--
Added user fbar5
--
User login: fbar5
First name: Foo
Last name: Bar
Full name: Foo Bar
Display name: Foo Bar
Initials: FB
Home directory: /home/fbar5
GECOS field: Foo Bar
Login shell: /bin/sh
Kerberos principal: fb...@idm.lab.bos.redhat.com
UID: 358800019
GID: 358800012
Password: False
Member of groups: ipausers
Kerberos keys available: False
# id fbar5
uid=358800019(fbar5) gid=358800012(ipausers) groups=358800012(ipausers)
Custom user group (GID) was overwritten.
I think we also want a test case for this situation.
Martin
... and we also want to have the new error message(s) i18n-able.
Martin
Updated patch attached.
Honza
--
Jan Cholasta
From 72258c8cf11ebe798db26782fa0d392972e556b6 Mon Sep 17 00:00:00 2001
From: Jan Cholasta jchol...@redhat.com
Date: Thu, 29 Mar 2012 09:12:36 -0400
Subject: [PATCH] Check whether the default user group is POSIX when adding
new user with --noprivate.
ticket 2572
---
API.txt|6 +-
ipalib/plugins/user.py | 12 ++-
tests/test_xmlrpc/test_group_plugin.py |4 +-
tests/test_xmlrpc/test_user_plugin.py | 163 +++-
tests/util.py |8 ++
5 files changed, 183 insertions(+), 10 deletions(-)
diff --git a/API.txt b/API.txt
index e9eb1e1..cc0d1eb 100644
--- a/API.txt
+++ b/API.txt
@@ -3082,7 +3082,7 @@ option: Str('mail', attribute=True, cli_name='email', multivalue=True, required=
option: Password('userpassword', attribute=True, cli_name='password', exclude='webui', multivalue=False, required=False)
option: Flag('random', attribute=False, autofill=True, cli_name='random', default=False, multivalue=False, required=False)
option: Int('uidnumber', attribute=True, autofill=True, cli_name='uid', default=999, minvalue=1, multivalue=False, required=True)
-option: Int('gidnumber', attribute=True, autofill=True, cli_name='gidnumber', minvalue=1, multivalue=False, required=True)
+option: Int('gidnumber', attribute=True, autofill=True, cli_name='gidnumber', default=999, minvalue=1, multivalue=False, required=True)
option: Str('street', attribute=True, cli_name='street', multivalue=False, required=False)
option: Str('l', attribute=True, cli_name='city', multivalue=False, required=False)
option: Str('st', attribute=True, cli_name='state', multivalue=False, required=False)
@@ -3140,7 +3140,7 @@ option: Str('krbprincipalname', attribute=True, autofill=False, cli_name='princi
option: Str('mail', attribute=True, autofill=False, cli_name='email', multivalue=True, query=True, required=False)
option: Password('userpassword', attribute=True, autofill=False, cli_name='password', exclude='webui', multivalue=False, query=True, required=False)
option: Int('uidnumber', attribute=True, autofill=False, cli_name='uid', default=999, minvalue=1, multivalue=False, query=True, required=False)
-option: Int('gidnumber', attribute=True, autofill=False, cli_name='gidnumber', minvalue=1, multivalue=False, query=True, required=False)
+option: Int('gidnumber', attribute=True, autofill=False, cli_name='gidnumber', default=999, minvalue=1, multivalue=False, query=True, required=False)
option: Str('street', attribute=True, autofill=False, cli_name='street', multivalue=False, query=True, required=False)
option: Str('l', attribute=True, autofill=False, cli_name='city', multivalue=False, query=True, required=False)
option: Str('st', attribute=True, autofill=False, cli_name='state', multivalue=False, query=True, required=False)
@@ -3189,7 +3189,7 @@ option: Str('mail', attribute=True, autofill=False, cli_name='email', multivalue
option: Password('userpassword', attribute=True, autofill=False, cli_name='password', exclude='webui', multivalue=False, required=False)
option: Flag('random', attribute=False, autofill=True, cli_name='random', default=False, multivalue=False, required=False)
option: Int('uidnumber', attribute=True, autofill=False, cli_name='uid', default=999, minvalue=1, multivalue=False, required=False)
-option: Int('gidnumber', attribute=True, autofill=False, cli_name='gidnumber', minvalue=1, multivalue=False, required=False)
+option: Int('gidnumber', attribute=True, autofill=False, cli_name='gidnumber', default=999, minvalue=1, multivalue=False, required=False)
option: Str('street', attribute=True, autofill=False, cli_name='street', multivalue=False, required=False)
option: Str('l', attribute=True, autofill=False, cli_name='city', multivalue=False, required=False)
option: Str('st',
