Re: [Freeipa-devel] [PATCH] 780 Handle principal not found errors when converting replication agreements
Martin Kosek wrote: On Wed, 2011-04-27 at 11:23 -0400, Rob Crittenden wrote: There are times where one side or the other is missing its peers krbprincipalname when converting from simple to GSSAPI replication. Ticket 1188 should address the cause of this. This patch provides better information and handling should either side be missing. ticket 1044 rob NACK. The idea is good, but there is a syntax error (missing parentheses) in the logging lines. Martin Gah, that's what I get for updating the message at the last minute. Updated patch attached, passes make-lint. rob freeipa-rcrit-780-2-replica.patch Description: application/mbox ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] 780 Handle principal not found errors when converting replication agreements
On Thu, 2011-04-28 at 08:58 -0400, Rob Crittenden wrote: Martin Kosek wrote: On Wed, 2011-04-27 at 11:23 -0400, Rob Crittenden wrote: There are times where one side or the other is missing its peers krbprincipalname when converting from simple to GSSAPI replication. Ticket 1188 should address the cause of this. This patch provides better information and handling should either side be missing. ticket 1044 rob NACK. The idea is good, but there is a syntax error (missing parentheses) in the logging lines. Martin Gah, that's what I get for updating the message at the last minute. Updated patch attached, passes make-lint. rob Yeah, we all have been there. That's where pylint comes to service :-) ACK. Pushed to master, ipa-2-0. Martin ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
