Re: [Freeipa-devel] [PATCH] 802 add message summary to sudorule

2011-06-16 Thread Martin Kosek
On Wed, 2011-06-15 at 17:29 +, JR Aquino wrote:
 On Jun 14, 2011, at 6:36 PM, Rob Crittenden wrote:
 
  Some of the sudorule commands were missing a message summary.
  
  ticket https://fedorahosted.org/freeipa/ticket/1255
  
  rob
  freeipa-rcrit-802-sudo.patch___
  Freeipa-devel mailing list
  Freeipa-devel@redhat.com
  https://www.redhat.com/mailman/listinfo/freeipa-devel
 
 NACK
 
 error: patch failed: ipalib/plugins/sudorule.py:189
 error: ipalib/plugins/sudorule.py: patch does not apply
 
 Appears to perhaps be off by 1 line number. You might have to rebase.

I already ack-ed and pushed this patch to master, ipa-2-0. It applied to
the branches without any problem.

Martin

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


Re: [Freeipa-devel] [PATCH] 802 add message summary to sudorule

2011-06-15 Thread Martin Kosek
On Tue, 2011-06-14 at 21:36 -0400, Rob Crittenden wrote:
 Some of the sudorule commands were missing a message summary.
 
 ticket https://fedorahosted.org/freeipa/ticket/1255
 
 rob

ACK. I checked if any unit test is broken because of newly returned
summary field, but its OK.

Pushed to master, ipa-2-0.

Martin

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


Re: [Freeipa-devel] [PATCH] 802 add message summary to sudorule

2011-06-15 Thread JR Aquino
On Jun 14, 2011, at 6:36 PM, Rob Crittenden wrote:

 Some of the sudorule commands were missing a message summary.
 
 ticket https://fedorahosted.org/freeipa/ticket/1255
 
 rob
 freeipa-rcrit-802-sudo.patch___
 Freeipa-devel mailing list
 Freeipa-devel@redhat.com
 https://www.redhat.com/mailman/listinfo/freeipa-devel

NACK

error: patch failed: ipalib/plugins/sudorule.py:189
error: ipalib/plugins/sudorule.py: patch does not apply

Appears to perhaps be off by 1 line number. You might have to rebase.

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel