Re: [Freeipa-devel] [PATCH] 869 set precedence correctly
On Tue, 2011-09-13 at 11:14 -0400, Rob Crittenden wrote: > Martin Kosek wrote: > > On Tue, 2011-09-13 at 10:15 -0400, Rob Crittenden wrote: > >> Martin Kosek wrote: > >>> On Mon, 2011-09-12 at 11:01 -0400, Rob Crittenden wrote: > I set precedence in the wrong entry of the modrdn plugin so it wasn't > having any effect. This should fix it. > > rob > >>> > >>> Works fine. > >>> > >>> Shouldn't we remove errorneous nsslapd-pluginprecedence from cn=Kerberos > >>> Principal Name,cn=IPA MODRDN,cn=plugins,cn=config during update process? > >>> If not, then ACK. > >>> > >>> Martin > >>> > >> > >> Good point. The old value doesn't actually do anything but lets remove > >> it to avoid confusion. > >> > >> rob > > > > Ok. But I think you attached an incorrect patch, its the same as the > > first version. > > > > Martin > > > > Sorry, used wrong commit id when regenerating patch > > rob ACK. Pushed to master, ipa-2-1. Martin ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] 869 set precedence correctly
Martin Kosek wrote: On Tue, 2011-09-13 at 10:15 -0400, Rob Crittenden wrote: Martin Kosek wrote: On Mon, 2011-09-12 at 11:01 -0400, Rob Crittenden wrote: I set precedence in the wrong entry of the modrdn plugin so it wasn't having any effect. This should fix it. rob Works fine. Shouldn't we remove errorneous nsslapd-pluginprecedence from cn=Kerberos Principal Name,cn=IPA MODRDN,cn=plugins,cn=config during update process? If not, then ACK. Martin Good point. The old value doesn't actually do anything but lets remove it to avoid confusion. rob Ok. But I think you attached an incorrect patch, its the same as the first version. Martin Sorry, used wrong commit id when regenerating patch rob >From 4fa72c6032f5d5f1307b4480c3974f16631d14dd Mon Sep 17 00:00:00 2001 From: Rob Crittenden Date: Mon, 12 Sep 2011 10:36:56 -0400 Subject: [PATCH] The precendence on the modrdn plugin was set in the wrong location. https://fedorahosted.org/freeipa/ticket/1370 --- .../ipa-slapi-plugins/ipa-modrdn/modrdn-conf.ldif |1 + install/share/modrdn-krbprinc.ldif |1 - install/updates/10-config.update |6 +- 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/daemons/ipa-slapi-plugins/ipa-modrdn/modrdn-conf.ldif b/daemons/ipa-slapi-plugins/ipa-modrdn/modrdn-conf.ldif index 54916eb..176f8be 100644 --- a/daemons/ipa-slapi-plugins/ipa-modrdn/modrdn-conf.ldif +++ b/daemons/ipa-slapi-plugins/ipa-modrdn/modrdn-conf.ldif @@ -13,3 +13,4 @@ nsslapd-pluginversion: 1.0 nsslapd-pluginvendor: Red Hat, Inc. nsslapd-plugindescription: IPA MODRDN plugin nsslapd-plugin-depends-on-type: database +nsslapd-pluginPrecedence: 60 diff --git a/install/share/modrdn-krbprinc.ldif b/install/share/modrdn-krbprinc.ldif index 15e6d3c..b35ea25 100644 --- a/install/share/modrdn-krbprinc.ldif +++ b/install/share/modrdn-krbprinc.ldif @@ -9,4 +9,3 @@ ipaModRDNtargetAttr: krbPrincipalName ipaModRDNsuffix: @$REALM ipaModRDNfilter: (&(objectclass=posixaccount)(objectclass=krbPrincipalAux)) ipaModRDNscope: $SUFFIX -nsslapd-pluginPrecedence: 60 diff --git a/install/updates/10-config.update b/install/updates/10-config.update index b3beefc..133ec67 100644 --- a/install/updates/10-config.update +++ b/install/updates/10-config.update @@ -4,7 +4,11 @@ dn: cn=config only:nsslapd-ssl-check-hostname: on +# Remove incorrect placement +dn: cn=Kerberos Principal Name,cn=IPA MODRDN,cn=plugins,cn=config +remove: nsslapd-pluginPrecedence: 60 + # Set the precedence of the ipa-modrdn plugin so it runs after other # plugins (the default is 50). -dn: cn=Kerberos Principal Name,cn=IPA MODRDN,cn=plugins,cn=config +dn: cn=IPA MODRDN,cn=plugins,cn=config only: nsslapd-pluginPrecedence: 60 -- 1.7.4 ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] 869 set precedence correctly
On Tue, 2011-09-13 at 10:15 -0400, Rob Crittenden wrote: > Martin Kosek wrote: > > On Mon, 2011-09-12 at 11:01 -0400, Rob Crittenden wrote: > >> I set precedence in the wrong entry of the modrdn plugin so it wasn't > >> having any effect. This should fix it. > >> > >> rob > > > > Works fine. > > > > Shouldn't we remove errorneous nsslapd-pluginprecedence from cn=Kerberos > > Principal Name,cn=IPA MODRDN,cn=plugins,cn=config during update process? > > If not, then ACK. > > > > Martin > > > > Good point. The old value doesn't actually do anything but lets remove > it to avoid confusion. > > rob Ok. But I think you attached an incorrect patch, its the same as the first version. Martin ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] 869 set precedence correctly
Martin Kosek wrote: On Mon, 2011-09-12 at 11:01 -0400, Rob Crittenden wrote: I set precedence in the wrong entry of the modrdn plugin so it wasn't having any effect. This should fix it. rob Works fine. Shouldn't we remove errorneous nsslapd-pluginprecedence from cn=Kerberos Principal Name,cn=IPA MODRDN,cn=plugins,cn=config during update process? If not, then ACK. Martin Good point. The old value doesn't actually do anything but lets remove it to avoid confusion. rob >From 5e1cd569b49b7d902ceb0f4c220276ff8f57de54 Mon Sep 17 00:00:00 2001 From: Rob Crittenden Date: Mon, 12 Sep 2011 10:36:56 -0400 Subject: [PATCH] The precendence on the modrdn plugin was set in the wrong location. https://fedorahosted.org/freeipa/ticket/1370 --- .../ipa-slapi-plugins/ipa-modrdn/modrdn-conf.ldif |1 + install/share/modrdn-krbprinc.ldif |1 - install/updates/10-config.update |2 +- 3 files changed, 2 insertions(+), 2 deletions(-) diff --git a/daemons/ipa-slapi-plugins/ipa-modrdn/modrdn-conf.ldif b/daemons/ipa-slapi-plugins/ipa-modrdn/modrdn-conf.ldif index 54916eb..176f8be 100644 --- a/daemons/ipa-slapi-plugins/ipa-modrdn/modrdn-conf.ldif +++ b/daemons/ipa-slapi-plugins/ipa-modrdn/modrdn-conf.ldif @@ -13,3 +13,4 @@ nsslapd-pluginversion: 1.0 nsslapd-pluginvendor: Red Hat, Inc. nsslapd-plugindescription: IPA MODRDN plugin nsslapd-plugin-depends-on-type: database +nsslapd-pluginPrecedence: 60 diff --git a/install/share/modrdn-krbprinc.ldif b/install/share/modrdn-krbprinc.ldif index 15e6d3c..b35ea25 100644 --- a/install/share/modrdn-krbprinc.ldif +++ b/install/share/modrdn-krbprinc.ldif @@ -9,4 +9,3 @@ ipaModRDNtargetAttr: krbPrincipalName ipaModRDNsuffix: @$REALM ipaModRDNfilter: (&(objectclass=posixaccount)(objectclass=krbPrincipalAux)) ipaModRDNscope: $SUFFIX -nsslapd-pluginPrecedence: 60 diff --git a/install/updates/10-config.update b/install/updates/10-config.update index b3beefc..9eb9186 100644 --- a/install/updates/10-config.update +++ b/install/updates/10-config.update @@ -6,5 +6,5 @@ only:nsslapd-ssl-check-hostname: on # Set the precedence of the ipa-modrdn plugin so it runs after other # plugins (the default is 50). -dn: cn=Kerberos Principal Name,cn=IPA MODRDN,cn=plugins,cn=config +dn: cn=IPA MODRDN,cn=plugins,cn=config only: nsslapd-pluginPrecedence: 60 -- 1.7.4 ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] 869 set precedence correctly
On Mon, 2011-09-12 at 11:01 -0400, Rob Crittenden wrote: > I set precedence in the wrong entry of the modrdn plugin so it wasn't > having any effect. This should fix it. > > rob Works fine. Shouldn't we remove errorneous nsslapd-pluginprecedence from cn=Kerberos Principal Name,cn=IPA MODRDN,cn=plugins,cn=config during update process? If not, then ACK. Martin ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
