Re: [Freeipa-devel] [PATCH] 89 Raise ValidationError on invalid CSV values

2013-02-08 Thread Martin Kosek
On 01/28/2013 03:30 PM, Petr Viktorin wrote: On 01/28/2013 10:29 AM, Jan Cholasta wrote: On 14.1.2013 12:56, Petr Viktorin wrote: On 01/09/2013 06:11 PM, Jan Cholasta wrote: Hi, this patch fixes https://fedorahosted.org/freeipa/ticket/3323. Honza The patch works well, but could you also

Re: [Freeipa-devel] [PATCH] 89 Raise ValidationError on invalid CSV values

2013-01-28 Thread Jan Cholasta
On 14.1.2013 12:56, Petr Viktorin wrote: On 01/09/2013 06:11 PM, Jan Cholasta wrote: Hi, this patch fixes https://fedorahosted.org/freeipa/ticket/3323. Honza The patch works well, but could you also add a test to ensure we don't regress in the future? Test added. -- Jan Cholasta From

Re: [Freeipa-devel] [PATCH] 89 Raise ValidationError on invalid CSV values

2013-01-28 Thread Petr Viktorin
On 01/28/2013 10:29 AM, Jan Cholasta wrote: On 14.1.2013 12:56, Petr Viktorin wrote: On 01/09/2013 06:11 PM, Jan Cholasta wrote: Hi, this patch fixes https://fedorahosted.org/freeipa/ticket/3323. Honza The patch works well, but could you also add a test to ensure we don't regress in the

Re: [Freeipa-devel] [PATCH] 89 Raise ValidationError on invalid CSV values

2013-01-14 Thread Petr Viktorin
On 01/09/2013 06:11 PM, Jan Cholasta wrote: Hi, this patch fixes https://fedorahosted.org/freeipa/ticket/3323. Honza The patch works well, but could you also add a test to ensure we don't regress in the future? -- Petr³ ___ Freeipa-devel