Re: [Freeipa-devel] [PATCH] 951 webui: fail nicely if cookies are disabled
On 01/28/2016 04:25 PM, Petr Vobornik wrote: > On 01/28/2016 04:23 PM, Tomas Babej wrote: >> >> >> On 01/28/2016 04:15 PM, Petr Vobornik wrote: >>> Reworks also sessionStorage test because disablement of cookies might be >>> connected with sessionStorage and localStorage. E.g. Chrome raises >>> exception when *Storage is accessed with "Block sites from setting any >>> data" settings set in "Content Settings/Cookies" section. >>> >>> https://fedorahosted.org/freeipa/ticket/4338 >>> >>> >> >> Seems that two spaces inserted themselves to the error message for >> localStorage :) >> > > updated patch attached. > > ACK, works fine. Pushed to master: 3c519951c5a719421d5abfa864dfeb6fbce6869d -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
Re: [Freeipa-devel] [PATCH] 951 webui: fail nicely if cookies are disabled
On 28.01.2016 16:25, Petr Vobornik wrote: On 01/28/2016 04:23 PM, Tomas Babej wrote: On 01/28/2016 04:15 PM, Petr Vobornik wrote: Reworks also sessionStorage test because disablement of cookies might be connected with sessionStorage and localStorage. E.g. Chrome raises exception when *Storage is accessed with "Block sites from setting any data" settings set in "Content Settings/Cookies" section. https://fedorahosted.org/freeipa/ticket/4338 Seems that two spaces inserted themselves to the error message for localStorage :) updated patch attached. Bump for review -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
Re: [Freeipa-devel] [PATCH] 951 webui: fail nicely if cookies are disabled
On 01/28/2016 04:23 PM, Tomas Babej wrote: On 01/28/2016 04:15 PM, Petr Vobornik wrote: Reworks also sessionStorage test because disablement of cookies might be connected with sessionStorage and localStorage. E.g. Chrome raises exception when *Storage is accessed with "Block sites from setting any data" settings set in "Content Settings/Cookies" section. https://fedorahosted.org/freeipa/ticket/4338 Seems that two spaces inserted themselves to the error message for localStorage :) updated patch attached. -- Petr Vobornik From 1e2306c426fef8ef2aa4e71fbcb197b49f13cdba Mon Sep 17 00:00:00 2001 From: Petr Vobornik Date: Thu, 28 Jan 2016 16:07:06 +0100 Subject: [PATCH] webui: fail nicely if cookies are disabled Reworks also sessionStorage test because disablement of cookies might be connected with sessionStorage and localStorage. E.g. Chrome raises exception when *Storage is accessed with "Block sites from setting any data" settings set in "Content Settings/Cookies" section. https://fedorahosted.org/freeipa/ticket/4338 --- install/ui/src/freeipa/app_container.js | 26 -- 1 file changed, 20 insertions(+), 6 deletions(-) diff --git a/install/ui/src/freeipa/app_container.js b/install/ui/src/freeipa/app_container.js index 1194fd14263a1b6f1a5a0a2fa4bc605f344ef417..bbe57ac97bd7b4877f9f90b6f4059771a26046ca 100644 --- a/install/ui/src/freeipa/app_container.js +++ b/install/ui/src/freeipa/app_container.js @@ -63,14 +63,28 @@ define([ phases.on('init', lang.hitch(this, function() { var deferred = new Deferred(); -if (!window.sessionStorage) { -deferred.reject({ -message: "Web UI requires sessionStorage enabled. " + - "This might be caused by too strict browser " + - "configuration." -}); + +function reject(item) { +var msg = "Web UI requires " + item + " enabled. " + + "Possible cause: too strict browser " + + "configuration."; +deferred.reject({ message: msg }); return deferred.promise; } + +function testStorage(storage) { +try { +if (!window[storage]) return false; +} catch(e) { +return false; +} +return true; +} + +if (!window.navigator.cookieEnabled) return reject('cookies'); +if (!testStorage('sessionStorage')) return reject('sessionStorage'); +if (!testStorage('localStorage')) return reject('localStorage'); + if (window.sessionStorage.getItem('logout')) { window.sessionStorage.removeItem('logout'); var login_facet = reg.facet.get('login'); -- 2.4.3 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
Re: [Freeipa-devel] [PATCH] 951 webui: fail nicely if cookies are disabled
On 01/28/2016 04:15 PM, Petr Vobornik wrote: > Reworks also sessionStorage test because disablement of cookies might be > connected with sessionStorage and localStorage. E.g. Chrome raises > exception when *Storage is accessed with "Block sites from setting any > data" settings set in "Content Settings/Cookies" section. > > https://fedorahosted.org/freeipa/ticket/4338 > > Seems that two spaces inserted themselves to the error message for localStorage :) -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code