Re: [Freeipa-devel] [PATCH] 966 limit allowed characters in netgroup name

2012-02-27 Thread Rob Crittenden
Martin Kosek wrote: On Mon, 2012-02-27 at 10:07 -0500, Rob Crittenden wrote: Martin Kosek wrote: On Fri, 2012-02-24 at 15:01 -0500, Rob Crittenden wrote: Limit the characters in a netgroup name to alpha, digits, -, _ and . rob NACK. 1) The regular expressions is not correct, you forget the

Re: [Freeipa-devel] [PATCH] 966 limit allowed characters in netgroup name

2012-02-27 Thread Martin Kosek
On Mon, 2012-02-27 at 10:07 -0500, Rob Crittenden wrote: > Martin Kosek wrote: > > On Fri, 2012-02-24 at 15:01 -0500, Rob Crittenden wrote: > >> Limit the characters in a netgroup name to alpha, digits, -, _ and . > >> > >> rob > > > > NACK. > > > > 1) The regular expressions is not correct, you fo

Re: [Freeipa-devel] [PATCH] 966 limit allowed characters in netgroup name

2012-02-27 Thread Rob Crittenden
Martin Kosek wrote: On Fri, 2012-02-24 at 15:01 -0500, Rob Crittenden wrote: Limit the characters in a netgroup name to alpha, digits, -, _ and . rob NACK. 1) The regular expressions is not correct, you forget the ending "$". Thus it matches any string with the right beginning. Like this one

Re: [Freeipa-devel] [PATCH] 966 limit allowed characters in netgroup name

2012-02-27 Thread Martin Kosek
On Fri, 2012-02-24 at 15:01 -0500, Rob Crittenden wrote: > Limit the characters in a netgroup name to alpha, digits, -, _ and . > > rob NACK. 1) The regular expressions is not correct, you forget the ending "$". Thus it matches any string with the right beginning. Like this one: # ipa netgroup-