Re: [Freeipa-devel] [PATCH] Allow using external hosts in HBAC test

2011-09-13 Thread Martin Kosek
On Tue, 2011-09-13 at 13:17 +0200, Martin Kosek wrote:
> On Tue, 2011-09-13 at 11:54 +0300, Alexander Bokovoy wrote:
> > When external host is specified in HBAC rule, allow its use in simulation
> > 
> > https://fedorahosted.org/freeipa/ticket/1763
> > 
> > When external host is specified in HBAC rule, it needs to be added to
> > the set of source hosts this rule applies to. Add (list of external hosts)
> > explicitly when converting FreeIPA rules to PyHBAC objects.
> > 
> 
> ACK. Pushed to master, ipa-2-1.
> 
> Martin

We missed a pylint false positive. Attached one-liner was acked by
Alexander over IRC and pushed to master, ipa-2-1.

Martin
>From 83a03d44525383e8efce9a77348a22ad76766614 Mon Sep 17 00:00:00 2001
From: Martin Kosek 
Date: Tue, 13 Sep 2011 13:37:32 +0200
Subject: [PATCH] Fix pylint false positive in hbactest module

https://fedorahosted.org/freeipa/ticket/1763
---
 ipalib/plugins/hbactest.py |2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/ipalib/plugins/hbactest.py b/ipalib/plugins/hbactest.py
index 43151e3407cba5808035259d36f99f09d6fd759f..75442451ca91783718942f78738170f399ef8ca9 100644
--- a/ipalib/plugins/hbactest.py
+++ b/ipalib/plugins/hbactest.py
@@ -153,7 +153,7 @@ def convert_to_ipa_rule(rule):
 if attr_name in rule:
 element[4].groups = rule[attr_name]
 if 'externalhost' in rule:
-ipa_rule.srchosts.names.extend(rule['externalhost'])
+ipa_rule.srchosts.names.extend(rule['externalhost']) #pylint: disable=E1101
 return ipa_rule
 
 
-- 
1.7.6

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] Allow using external hosts in HBAC test

2011-09-13 Thread Martin Kosek
On Tue, 2011-09-13 at 11:54 +0300, Alexander Bokovoy wrote:
> When external host is specified in HBAC rule, allow its use in simulation
> 
> https://fedorahosted.org/freeipa/ticket/1763
> 
> When external host is specified in HBAC rule, it needs to be added to
> the set of source hosts this rule applies to. Add (list of external hosts)
> explicitly when converting FreeIPA rules to PyHBAC objects.
> 

ACK. Pushed to master, ipa-2-1.

Martin

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel