Re: [Freeipa-devel] [PATCH] Improvements to enrollments in the webUI.

2011-01-04 Thread Adam Young

On 01/04/2011 10:34 AM, Pavel Zuna wrote:
The patch is a bit bigger and more complex, so I expect this to be the 
first shot at it.


There are some places where we need to handle localization better and 
be more generic when it comes to non-standard relationships like 
'enrolledby' etc., but that can be done later. (I put a few TODOs in 
the code.)


Anyway, here's the changelog for this patch:

- Enrollement links in the action panel are now sorted by relationships.
- You can only enroll members.
  (The webUI made the impression you can enroll parents as well, but 
it was

   broken.)
- When enrolling new members, you can choose not to display already 
enrolled

  ones. (On by default.)
- Couple cosmetic changes.

IT DEPENDS ON MY PATCH NUMBER 54 (Improve filtering of enrollments 
search results.)



Pavel


___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Nack,

Make sure you fiter out the object itselt, so you can't enroll, for 
example, a group in itself.
For verbage, Use Members for ojects enrolled in this object, and 
Member of:  inplace of parent.


Other than that, it looks good.

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] Improvements to enrollments in the webUI.

2011-01-04 Thread Adam Young

On 01/04/2011 12:45 PM, Adam Young wrote:

On 01/04/2011 10:34 AM, Pavel Zuna wrote:
The patch is a bit bigger and more complex, so I expect this to be 
the first shot at it.


There are some places where we need to handle localization better and 
be more generic when it comes to non-standard relationships like 
'enrolledby' etc., but that can be done later. (I put a few TODOs in 
the code.)


Anyway, here's the changelog for this patch:

- Enrollement links in the action panel are now sorted by relationships.
- You can only enroll members.
  (The webUI made the impression you can enroll parents as well, but 
it was

   broken.)
- When enrolling new members, you can choose not to display already 
enrolled

  ones. (On by default.)
- Couple cosmetic changes.

IT DEPENDS ON MY PATCH NUMBER 54 (Improve filtering of enrollments 
search results.)



Pavel


___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Nack,

Make sure you fiter out the object itselt, so you can't enroll, for 
example, a group in itself.
For verbage, Use Members for ojects enrolled in this object, and 
Member of:  inplace of parent.


Other than that, it looks good.


___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

pushed to master
___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] Improvements to enrollments in the webUI.

2011-01-04 Thread Adam Young

On 01/04/2011 12:45 PM, Adam Young wrote:

On 01/04/2011 10:34 AM, Pavel Zuna wrote:
The patch is a bit bigger and more complex, so I expect this to be 
the first shot at it.


There are some places where we need to handle localization better and 
be more generic when it comes to non-standard relationships like 
'enrolledby' etc., but that can be done later. (I put a few TODOs in 
the code.)


Anyway, here's the changelog for this patch:

- Enrollement links in the action panel are now sorted by relationships.
- You can only enroll members.
  (The webUI made the impression you can enroll parents as well, but 
it was

   broken.)
- When enrolling new members, you can choose not to display already 
enrolled

  ones. (On by default.)
- Couple cosmetic changes.

IT DEPENDS ON MY PATCH NUMBER 54 (Improve filtering of enrollments 
search results.)



Pavel


___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Nack,

Make sure you fiter out the object itselt, so you can't enroll, for 
example, a group in itself.

For verbage, Use Members fo


Actually, we can do those as follow on work.  I think this should be 
pushed, as it is a significant improvement over what we have now.



r ojects enrolled in this object, and Member of:  inplace of parent.

Other than that, it looks good.


___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel