Re: [Freeipa-devel] [PATCH] Make DNS plugin support output validation and thus make it work again.

2010-01-20 Thread Martin Nagy
On Mon, 2010-01-18 at 18:07 +0100, Pavel Zuna wrote:
> Rob Crittenden wrote:
> > Pavel Zuna wrote:
> >> Pavel Zuna wrote:
> >>> .
> >>>
> >>> Pavel
> >>>
> >> Patch attached... here.
> >>
> >> Pavel
> >>
> > 
> > This looks ok but do you really want to override output_for_cli? This 
> > doesn't seem to do a lot more than the default, but I may be wrong.
> It does a little bit more. Anyway this patch is simply there to make things 
> work 
> again for Martin, I'm planning to re-factor the whole thing in the future.

Yeah, I pretty much need this, thanks.
I made a review and tested the patch.

Ack & pushed.

Martin

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


Re: [Freeipa-devel] [PATCH] Make DNS plugin support output validation and thus make it work again.

2010-01-18 Thread Pavel Zuna

Rob Crittenden wrote:

Pavel Zuna wrote:

Pavel Zuna wrote:

.

Pavel


Patch attached... here.

Pavel



This looks ok but do you really want to override output_for_cli? This 
doesn't seem to do a lot more than the default, but I may be wrong.
It does a little bit more. Anyway this patch is simply there to make things work 
again for Martin, I'm planning to re-factor the whole thing in the future.



rob


Pavel

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


Re: [Freeipa-devel] [PATCH] Make DNS plugin support output validation and thus make it work again.

2010-01-14 Thread Rob Crittenden

Pavel Zuna wrote:

Pavel Zuna wrote:

.

Pavel


Patch attached... here.

Pavel



This looks ok but do you really want to override output_for_cli? This 
doesn't seem to do a lot more than the default, but I may be wrong.


rob

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


Re: [Freeipa-devel] [PATCH] Make DNS plugin support output validation and thus make it work again.

2010-01-14 Thread Pavel Zuna

Pavel Zuna wrote:

.

Pavel


Patch attached... here.

Pavel


0001-Make-DNS-plugin-support-output-validation-and-thus-m.patch
Description: application/mbox
___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel