Re: [Freeipa-devel] [PATCH] Permission MOD command fix
On 18.2.2014 21:03, Martin Kosek wrote: On 02/18/2014 06:52 PM, Petr Viktorin wrote: On 02/18/2014 06:46 PM, Jan Cholasta wrote: Hi, On 18.2.2014 18:40, Nathaniel McCallum wrote: On Tue, 2014-02-18 at 12:31 -0500, Adam Misnyovszki wrote: Hi, this patch fixes permission-mod command returning duplicate memberships. https://fedorahosted.org/freeipa/ticket/4175 NACK This patch does not apply to master. Nathaniel The ticket is for 3.3. ACK on the patch. Honza Thanks! Welcome to FreeIPA. +1! I've added a few more words and the ticket URL to the commit message. Next time, please be a bit more verbose. Pushed to ipa-3-3: 2ae2e9b142f1e34f5c95da93ec74ccaa90af2d27 Yes, please see the guidelines we have on our wiki: http://www.freeipa.org/page/Contribute/Code http://www.freeipa.org/page/Contribute/Patch_Format Note to code itself - it would be better to check for "memberofindirect_" instead of "memberofindirect" so that it is consistent with already used "member_" part. Or even better, one could work with self.obj.attribute_members to see all the possible memberships. Actually I think just "memberindirect" is correct here, because unlike member, both memberindirect and memberindirect_* are not real attributes. But this is just a nitpick, this patch lives in ipa-3-3 only anyway. Martin -- Jan Cholasta ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] Permission MOD command fix
On 02/18/2014 06:52 PM, Petr Viktorin wrote: On 02/18/2014 06:46 PM, Jan Cholasta wrote: Hi, On 18.2.2014 18:40, Nathaniel McCallum wrote: On Tue, 2014-02-18 at 12:31 -0500, Adam Misnyovszki wrote: Hi, this patch fixes permission-mod command returning duplicate memberships. https://fedorahosted.org/freeipa/ticket/4175 NACK This patch does not apply to master. Nathaniel The ticket is for 3.3. ACK on the patch. Honza Thanks! Welcome to FreeIPA. +1! I've added a few more words and the ticket URL to the commit message. Next time, please be a bit more verbose. Pushed to ipa-3-3: 2ae2e9b142f1e34f5c95da93ec74ccaa90af2d27 Yes, please see the guidelines we have on our wiki: http://www.freeipa.org/page/Contribute/Code http://www.freeipa.org/page/Contribute/Patch_Format Note to code itself - it would be better to check for "memberofindirect_" instead of "memberofindirect" so that it is consistent with already used "member_" part. Or even better, one could work with self.obj.attribute_members to see all the possible memberships. But this is just a nitpick, this patch lives in ipa-3-3 only anyway. Martin ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] Permission MOD command fix
On 02/18/2014 06:46 PM, Jan Cholasta wrote: Hi, On 18.2.2014 18:40, Nathaniel McCallum wrote: On Tue, 2014-02-18 at 12:31 -0500, Adam Misnyovszki wrote: Hi, this patch fixes permission-mod command returning duplicate memberships. https://fedorahosted.org/freeipa/ticket/4175 NACK This patch does not apply to master. Nathaniel The ticket is for 3.3. ACK on the patch. Honza Thanks! Welcome to FreeIPA. I've added a few more words and the ticket URL to the commit message. Next time, please be a bit more verbose. Pushed to ipa-3-3: 2ae2e9b142f1e34f5c95da93ec74ccaa90af2d27 -- Petr³ ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] Permission MOD command fix
Hi, On 18.2.2014 18:40, Nathaniel McCallum wrote: On Tue, 2014-02-18 at 12:31 -0500, Adam Misnyovszki wrote: Hi, this patch fixes permission-mod command returning duplicate memberships. https://fedorahosted.org/freeipa/ticket/4175 NACK This patch does not apply to master. Nathaniel The ticket is for 3.3. ACK on the patch. Honza -- Jan Cholasta ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] Permission MOD command fix
On Tue, 2014-02-18 at 12:31 -0500, Adam Misnyovszki wrote: > Hi, > this patch fixes permission-mod command returning duplicate memberships. > > https://fedorahosted.org/freeipa/ticket/4175 NACK This patch does not apply to master. Nathaniel ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
