Re: [Freeipa-devel] [PATCH] Removed duplicate domain name validation function

2015-12-02 Thread Martin Basti
On 02.12.2015 17:28, Martin Basti wrote: On 01.12.2015 16:03, Stanislav Laznicka wrote: Sending the patch with renamed function. Standa On 12/01/2015 09:57 AM, Jan Cholasta wrote: On 1.12.2015 09:37, Petr Spacek wrote: On 30.11.2015 20:00, Martin Basti wrote: On 27.11.2015 16:06,

Re: [Freeipa-devel] [PATCH] Removed duplicate domain name validation function

2015-12-02 Thread Martin Basti
On 01.12.2015 16:03, Stanislav Laznicka wrote: Sending the patch with renamed function. Standa On 12/01/2015 09:57 AM, Jan Cholasta wrote: On 1.12.2015 09:37, Petr Spacek wrote: On 30.11.2015 20:00, Martin Basti wrote: On 27.11.2015 16:06, Stanislav Laznicka wrote: Please, see the

Re: [Freeipa-devel] [PATCH] Removed duplicate domain name validation function

2015-12-01 Thread Petr Spacek
On 30.11.2015 20:00, Martin Basti wrote: > > > On 27.11.2015 16:06, Stanislav Laznicka wrote: >> Please, see the modified patch attached. >> >> Standa >> >> On 11/27/2015 03:48 PM, Martin Basti wrote: >>> >>> >>> On 27.11.2015 15:33, Petr Spacek wrote: On 27.11.2015 15:32, Martin Basti

Re: [Freeipa-devel] [PATCH] Removed duplicate domain name validation function

2015-12-01 Thread Jan Cholasta
On 1.12.2015 09:37, Petr Spacek wrote: On 30.11.2015 20:00, Martin Basti wrote: On 27.11.2015 16:06, Stanislav Laznicka wrote: Please, see the modified patch attached. Standa On 11/27/2015 03:48 PM, Martin Basti wrote: On 27.11.2015 15:33, Petr Spacek wrote: On 27.11.2015 15:32, Martin

Re: [Freeipa-devel] [PATCH] Removed duplicate domain name validation function

2015-12-01 Thread Stanislav Laznicka
Sending the patch with renamed function. Standa On 12/01/2015 09:57 AM, Jan Cholasta wrote: On 1.12.2015 09:37, Petr Spacek wrote: On 30.11.2015 20:00, Martin Basti wrote: On 27.11.2015 16:06, Stanislav Laznicka wrote: Please, see the modified patch attached. Standa On 11/27/2015 03:48

Re: [Freeipa-devel] [PATCH] Removed duplicate domain name validation function

2015-11-30 Thread Martin Basti
On 27.11.2015 16:06, Stanislav Laznicka wrote: Please, see the modified patch attached. Standa On 11/27/2015 03:48 PM, Martin Basti wrote: On 27.11.2015 15:33, Petr Spacek wrote: On 27.11.2015 15:32, Martin Basti wrote: On 25.11.2015 17:18, Stanislav Laznicka wrote: There were two

Re: [Freeipa-devel] [PATCH] Removed duplicate domain name validation function

2015-11-27 Thread Martin Basti
On 25.11.2015 17:18, Stanislav Laznicka wrote: There were two functions for the same purpose. Removed one. Hello, I would like to have "log" param of is_host_resolvable as optional Otherwise the patch LGTM. Martin -- Manage your subscription for the Freeipa-devel mailing list:

Re: [Freeipa-devel] [PATCH] Removed duplicate domain name validation function

2015-11-27 Thread Petr Spacek
On 27.11.2015 15:32, Martin Basti wrote: > > > On 25.11.2015 17:18, Stanislav Laznicka wrote: >> There were two functions for the same purpose. Removed one. >> >> > Hello, > > I would like to have "log" param of is_host_resolvable as optional Is there an immediate need for the optional param?

Re: [Freeipa-devel] [PATCH] Removed duplicate domain name validation function

2015-11-27 Thread Martin Basti
On 27.11.2015 15:33, Petr Spacek wrote: On 27.11.2015 15:32, Martin Basti wrote: On 25.11.2015 17:18, Stanislav Laznicka wrote: There were two functions for the same purpose. Removed one. Hello, I would like to have "log" param of is_host_resolvable as optional Is there an immediate

Re: [Freeipa-devel] [PATCH] Removed duplicate domain name validation function

2015-11-27 Thread Stanislav Laznicka
Please, see the modified patch attached. Standa On 11/27/2015 03:48 PM, Martin Basti wrote: On 27.11.2015 15:33, Petr Spacek wrote: On 27.11.2015 15:32, Martin Basti wrote: On 25.11.2015 17:18, Stanislav Laznicka wrote: There were two functions for the same purpose. Removed one.