Re: [Freeipa-devel] [PATCH] SPEC: Drop sssd from BuildRequires
On 05.11.2015 08:40, Lukas Slebodnik wrote: On (05/11/15 09:24), Alexander Bokovoy wrote: On Thu, 05 Nov 2015, Lukas Slebodnik wrote: On (04/11/15 18:12), Alexander Bokovoy wrote: On Tue, 03 Nov 2015, Lukas Slebodnik wrote: >From c466be0e769a80fe204fc70675b8fa0ea3efb7b2 Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik Date: Mon, 2 Nov 2015 19:52:57 + Subject: [PATCH] SPEC: Drop sssd from BuildRequires Packaging of sssd was changed and more sub-packages are build >from sssd.src.rpm. Especially python bindings and development packages are already in sub-packages. As a result of this change the meta package sssd can be removed from BuildRequires without any problem. FreeIPA spec file contained build requirement for latest version of sssd even though the latest sssd was not required for building FreeIPA rpms. In many cases, it was sufficient just to change requirements for FreeIPA packages instead of build requirements. ACK -- we have explicit requirements to separate SSSD components (libsss_idmap, libsss_nss_idmap, python-libipa_hbac, to name a few). Thank you very much for review. Perhaps, telling that your goal is to build without SSSD is somewhat misleading -- SSSD subpackages will be installed anyway and at least 1.12.1 will be required. Did we test the same patch? I cannot see installed sssd in build root on rawhide http://paste.fedoraproject.org/287115/46707060 [build@526468c6ceac rpms]$ grep sssd root.log [build@526468c6ceac rpms]$ grep 1.13.1-4.fc24 root.log DEBUG util.py:393: libipa_hbac x86_64 1.13.1-4.fc24 fedora 73 k DEBUG util.py:393: libsss_idmap x86_64 1.13.1-4.fc24 fedora 77 k DEBUG util.py:393: libsss_idmap-devel x86_64 1.13.1-4.fc24 fedora 140 k DEBUG util.py:393: libsss_nss_idmap x86_64 1.13.1-4.fc24 fedora 77 k DEBUG util.py:393: libsss_nss_idmap-devel x86_64 1.13.1-4.fc24 fedora 125 k DEBUG util.py:393: python-libipa_hbac x86_64 1.13.1-4.fc24 fedora 68 k DEBUG util.py:393: [SKIPPED] python-libipa_hbac-1.13.1-4.fc24.x86_64.rpm: Already downloaded DEBUG util.py:393: [SKIPPED] libipa_hbac-1.13.1-4.fc24.x86_64.rpm: Already downloaded DEBUG util.py:393: [SKIPPED] libsss_idmap-devel-1.13.1-4.fc24.x86_64.rpm: Already downloaded DEBUG util.py:393: [SKIPPED] libsss_idmap-1.13.1-4.fc24.x86_64.rpm: Already downloaded DEBUG util.py:393: [SKIPPED] libsss_nss_idmap-devel-1.13.1-4.fc24.x86_64.rpm: Already downloaded DEBUG util.py:393: [SKIPPED] libsss_nss_idmap-1.13.1-4.fc24.x86_64.rpm: Already downloaded DEBUG util.py:393: Installing : libsss_nss_idmap-1.13.1-4.fc24.x86_64 91/241 DEBUG util.py:393: Installing : libsss_idmap-1.13.1-4.fc24.x86_64 92/241 DEBUG util.py:393: Installing : libipa_hbac-1.13.1-4.fc24.x86_64 195/241 DEBUG util.py:393: Installing : python-libipa_hbac-1.13.1-4.fc24.x86_64 212/241 DEBUG util.py:393: Installing : libsss_idmap-devel-1.13.1-4.fc24.x86_64 224/241 DEBUG util.py:393: Installing : libsss_nss_idmap-devel-1.13.1-4.fc24.x86_64 225/241 DEBUG util.py:393: Verifying : python-libipa_hbac-1.13.1-4.fc24.x86_64 19/241 DEBUG util.py:393: Verifying : libipa_hbac-1.13.1-4.fc24.x86_64 77/241 DEBUG util.py:393: Verifying : libsss_idmap-devel-1.13.1-4.fc24.x86_64 187/241 DEBUG util.py:393: Verifying : libsss_idmap-1.13.1-4.fc24.x86_64 188/241 DEBUG util.py:393: Verifying : libsss_nss_idmap-devel-1.13.1-4.fc24.x86_64 189/241 DEBUG util.py:393: Verifying : libsss_nss_idmap-1.13.1-4.fc24.x86_64 190/241 DEBUG util.py:393: libipa_hbac.x86_64 1.13.1-4.fc24 DEBUG util.py:393: libsss_idmap.x86_64 1.13.1-4.fc24 DEBUG util.py:393: libsss_idmap-devel.x86_64 1.13.1-4.fc24 DEBUG util.py:393: libsss_nss_idmap.x86_64 1.13.1-4.fc24 DEBUG util.py:393: libsss_nss_idmap-devel.x86_64 1.13.1-4.fc24 DEBUG util.py:393: python-libipa_hbac.x86_64 1.13.1-4.fc24 and freeipa packages were successfully built. http://paste.fedoraproject.org/287118/07222144 Right and as I said, SSSD subpackages are installed. You listed them above. That's all we needed. Ahh, I'm sorry. I misread the sentense. I saw "sssd pacakge" instead of "sssd subpackages" LS Pushed to master: 85253b9c40d2b2734a5ed761f324c6177d1a74bc -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
Re: [Freeipa-devel] [PATCH] SPEC: Drop sssd from BuildRequires
On (05/11/15 09:24), Alexander Bokovoy wrote: >On Thu, 05 Nov 2015, Lukas Slebodnik wrote: >>On (04/11/15 18:12), Alexander Bokovoy wrote: >>>On Tue, 03 Nov 2015, Lukas Slebodnik wrote: >From c466be0e769a80fe204fc70675b8fa0ea3efb7b2 Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik Date: Mon, 2 Nov 2015 19:52:57 + Subject: [PATCH] SPEC: Drop sssd from BuildRequires Packaging of sssd was changed and more sub-packages are build from sssd.src.rpm. Especially python bindings and development packages are already in sub-packages. As a result of this change the meta package sssd can be removed from BuildRequires without any problem. FreeIPA spec file contained build requirement for latest version of sssd even though the latest sssd was not required for building FreeIPA rpms. In many cases, it was sufficient just to change requirements for FreeIPA packages instead of build requirements. >>>ACK -- we have explicit requirements to separate SSSD components >>>(libsss_idmap, libsss_nss_idmap, python-libipa_hbac, to name a few). >>> >>Thank you very much for review. >> >>>Perhaps, telling that your goal is to build without SSSD is somewhat >>>misleading -- SSSD subpackages will be installed anyway and at least >>>1.12.1 will be required. >>> >>Did we test the same patch? >> >>I cannot see installed sssd in build root on rawhide >>http://paste.fedoraproject.org/287115/46707060 >> >>[build@526468c6ceac rpms]$ grep sssd root.log >>[build@526468c6ceac rpms]$ grep 1.13.1-4.fc24 root.log >>DEBUG util.py:393: libipa_hbac x86_64 1.13.1-4.fc24 >>fedora 73 k >>DEBUG util.py:393: libsss_idmap x86_64 1.13.1-4.fc24 >>fedora 77 k >>DEBUG util.py:393: libsss_idmap-devel x86_64 1.13.1-4.fc24 >>fedora 140 k >>DEBUG util.py:393: libsss_nss_idmap x86_64 1.13.1-4.fc24 >>fedora 77 k >>DEBUG util.py:393: libsss_nss_idmap-devel x86_64 1.13.1-4.fc24 >>fedora 125 k >>DEBUG util.py:393: python-libipa_hbac x86_64 1.13.1-4.fc24 >>fedora 68 k >>DEBUG util.py:393: [SKIPPED] python-libipa_hbac-1.13.1-4.fc24.x86_64.rpm: >>Already downloaded >>DEBUG util.py:393: [SKIPPED] libipa_hbac-1.13.1-4.fc24.x86_64.rpm: Already >>downloaded >>DEBUG util.py:393: [SKIPPED] libsss_idmap-devel-1.13.1-4.fc24.x86_64.rpm: >>Already downloaded >>DEBUG util.py:393: [SKIPPED] libsss_idmap-1.13.1-4.fc24.x86_64.rpm: Already >>downloaded >>DEBUG util.py:393: [SKIPPED] libsss_nss_idmap-devel-1.13.1-4.fc24.x86_64.rpm: >>Already downloaded >>DEBUG util.py:393: [SKIPPED] libsss_nss_idmap-1.13.1-4.fc24.x86_64.rpm: >>Already downloaded >>DEBUG util.py:393: Installing : libsss_nss_idmap-1.13.1-4.fc24.x86_64 >>91/241 >>DEBUG util.py:393: Installing : libsss_idmap-1.13.1-4.fc24.x86_64 >>92/241 >>DEBUG util.py:393: Installing : libipa_hbac-1.13.1-4.fc24.x86_64 >>195/241 >>DEBUG util.py:393: Installing : python-libipa_hbac-1.13.1-4.fc24.x86_64 >>212/241 >>DEBUG util.py:393: Installing : libsss_idmap-devel-1.13.1-4.fc24.x86_64 >>224/241 >>DEBUG util.py:393: Installing : libsss_nss_idmap-devel-1.13.1-4.fc24.x86_64 >>225/241 >>DEBUG util.py:393: Verifying : python-libipa_hbac-1.13.1-4.fc24.x86_64 >>19/241 >>DEBUG util.py:393: Verifying : libipa_hbac-1.13.1-4.fc24.x86_64 >>77/241 >>DEBUG util.py:393: Verifying : libsss_idmap-devel-1.13.1-4.fc24.x86_64 >>187/241 >>DEBUG util.py:393: Verifying : libsss_idmap-1.13.1-4.fc24.x86_64 >>188/241 >>DEBUG util.py:393: Verifying : libsss_nss_idmap-devel-1.13.1-4.fc24.x86_64 >>189/241 >>DEBUG util.py:393: Verifying : libsss_nss_idmap-1.13.1-4.fc24.x86_64 >>190/241 >>DEBUG util.py:393: libipa_hbac.x86_64 1.13.1-4.fc24 >>DEBUG util.py:393: libsss_idmap.x86_64 1.13.1-4.fc24 >>DEBUG util.py:393: libsss_idmap-devel.x86_64 1.13.1-4.fc24 >>DEBUG util.py:393: libsss_nss_idmap.x86_64 1.13.1-4.fc24 >>DEBUG util.py:393: libsss_nss_idmap-devel.x86_64 1.13.1-4.fc24 >>DEBUG util.py:393: python-libipa_hbac.x86_64 1.13.1-4.fc24 >> >>and freeipa packages were successfully built. >>http://paste.fedoraproject.org/287118/07222144 >Right and as I said, SSSD subpackages are installed. You listed them >above. That's all we needed. Ahh, I'm sorry. I misread the sentense. I saw "sssd pacakge" instead of "sssd subpackages" LS -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
Re: [Freeipa-devel] [PATCH] SPEC: Drop sssd from BuildRequires
On Thu, 05 Nov 2015, Lukas Slebodnik wrote: On (04/11/15 18:12), Alexander Bokovoy wrote: On Tue, 03 Nov 2015, Lukas Slebodnik wrote: From c466be0e769a80fe204fc70675b8fa0ea3efb7b2 Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik Date: Mon, 2 Nov 2015 19:52:57 + Subject: [PATCH] SPEC: Drop sssd from BuildRequires Packaging of sssd was changed and more sub-packages are build from sssd.src.rpm. Especially python bindings and development packages are already in sub-packages. As a result of this change the meta package sssd can be removed from BuildRequires without any problem. FreeIPA spec file contained build requirement for latest version of sssd even though the latest sssd was not required for building FreeIPA rpms. In many cases, it was sufficient just to change requirements for FreeIPA packages instead of build requirements. ACK -- we have explicit requirements to separate SSSD components (libsss_idmap, libsss_nss_idmap, python-libipa_hbac, to name a few). Thank you very much for review. Perhaps, telling that your goal is to build without SSSD is somewhat misleading -- SSSD subpackages will be installed anyway and at least 1.12.1 will be required. Did we test the same patch? I cannot see installed sssd in build root on rawhide http://paste.fedoraproject.org/287115/46707060 [build@526468c6ceac rpms]$ grep sssd root.log [build@526468c6ceac rpms]$ grep 1.13.1-4.fc24 root.log DEBUG util.py:393: libipa_hbac x86_64 1.13.1-4.fc24 fedora 73 k DEBUG util.py:393: libsss_idmap x86_64 1.13.1-4.fc24 fedora 77 k DEBUG util.py:393: libsss_idmap-devel x86_64 1.13.1-4.fc24 fedora 140 k DEBUG util.py:393: libsss_nss_idmap x86_64 1.13.1-4.fc24 fedora 77 k DEBUG util.py:393: libsss_nss_idmap-devel x86_64 1.13.1-4.fc24 fedora 125 k DEBUG util.py:393: python-libipa_hbac x86_64 1.13.1-4.fc24 fedora 68 k DEBUG util.py:393: [SKIPPED] python-libipa_hbac-1.13.1-4.fc24.x86_64.rpm: Already downloaded DEBUG util.py:393: [SKIPPED] libipa_hbac-1.13.1-4.fc24.x86_64.rpm: Already downloaded DEBUG util.py:393: [SKIPPED] libsss_idmap-devel-1.13.1-4.fc24.x86_64.rpm: Already downloaded DEBUG util.py:393: [SKIPPED] libsss_idmap-1.13.1-4.fc24.x86_64.rpm: Already downloaded DEBUG util.py:393: [SKIPPED] libsss_nss_idmap-devel-1.13.1-4.fc24.x86_64.rpm: Already downloaded DEBUG util.py:393: [SKIPPED] libsss_nss_idmap-1.13.1-4.fc24.x86_64.rpm: Already downloaded DEBUG util.py:393: Installing : libsss_nss_idmap-1.13.1-4.fc24.x86_64 91/241 DEBUG util.py:393: Installing : libsss_idmap-1.13.1-4.fc24.x86_64 92/241 DEBUG util.py:393: Installing : libipa_hbac-1.13.1-4.fc24.x86_64 195/241 DEBUG util.py:393: Installing : python-libipa_hbac-1.13.1-4.fc24.x86_64 212/241 DEBUG util.py:393: Installing : libsss_idmap-devel-1.13.1-4.fc24.x86_64 224/241 DEBUG util.py:393: Installing : libsss_nss_idmap-devel-1.13.1-4.fc24.x86_64 225/241 DEBUG util.py:393: Verifying : python-libipa_hbac-1.13.1-4.fc24.x86_64 19/241 DEBUG util.py:393: Verifying : libipa_hbac-1.13.1-4.fc24.x86_64 77/241 DEBUG util.py:393: Verifying : libsss_idmap-devel-1.13.1-4.fc24.x86_64 187/241 DEBUG util.py:393: Verifying : libsss_idmap-1.13.1-4.fc24.x86_64 188/241 DEBUG util.py:393: Verifying : libsss_nss_idmap-devel-1.13.1-4.fc24.x86_64 189/241 DEBUG util.py:393: Verifying : libsss_nss_idmap-1.13.1-4.fc24.x86_64 190/241 DEBUG util.py:393: libipa_hbac.x86_64 1.13.1-4.fc24 DEBUG util.py:393: libsss_idmap.x86_64 1.13.1-4.fc24 DEBUG util.py:393: libsss_idmap-devel.x86_64 1.13.1-4.fc24 DEBUG util.py:393: libsss_nss_idmap.x86_64 1.13.1-4.fc24 DEBUG util.py:393: libsss_nss_idmap-devel.x86_64 1.13.1-4.fc24 DEBUG util.py:393: python-libipa_hbac.x86_64 1.13.1-4.fc24 and freeipa packages were successfully built. http://paste.fedoraproject.org/287118/07222144 Right and as I said, SSSD subpackages are installed. You listed them above. That's all we needed. -- / Alexander Bokovoy -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
Re: [Freeipa-devel] [PATCH] SPEC: Drop sssd from BuildRequires
On (04/11/15 18:12), Alexander Bokovoy wrote: >On Tue, 03 Nov 2015, Lukas Slebodnik wrote: >>>From c466be0e769a80fe204fc70675b8fa0ea3efb7b2 Mon Sep 17 00:00:00 2001 >>From: Lukas Slebodnik >>Date: Mon, 2 Nov 2015 19:52:57 + >>Subject: [PATCH] SPEC: Drop sssd from BuildRequires >> >>Packaging of sssd was changed and more sub-packages are build >>from sssd.src.rpm. Especially python bindings and development packages >>are already in sub-packages. As a result of this change the meta package >>sssd can be removed from BuildRequires without any problem. >> >>FreeIPA spec file contained build requirement for latest version of >>sssd even though the latest sssd was not required for building >>FreeIPA rpms. In many cases, it was sufficient just to change requirements >>for FreeIPA packages instead of build requirements. >ACK -- we have explicit requirements to separate SSSD components >(libsss_idmap, libsss_nss_idmap, python-libipa_hbac, to name a few). > Thank you very much for review. >Perhaps, telling that your goal is to build without SSSD is somewhat >misleading -- SSSD subpackages will be installed anyway and at least >1.12.1 will be required. > Did we test the same patch? I cannot see installed sssd in build root on rawhide http://paste.fedoraproject.org/287115/46707060 [build@526468c6ceac rpms]$ grep sssd root.log [build@526468c6ceac rpms]$ grep 1.13.1-4.fc24 root.log DEBUG util.py:393: libipa_hbac x86_64 1.13.1-4.fc24 fedora 73 k DEBUG util.py:393: libsss_idmap x86_64 1.13.1-4.fc24 fedora 77 k DEBUG util.py:393: libsss_idmap-devel x86_64 1.13.1-4.fc24 fedora 140 k DEBUG util.py:393: libsss_nss_idmap x86_64 1.13.1-4.fc24 fedora 77 k DEBUG util.py:393: libsss_nss_idmap-devel x86_64 1.13.1-4.fc24 fedora 125 k DEBUG util.py:393: python-libipa_hbac x86_64 1.13.1-4.fc24 fedora 68 k DEBUG util.py:393: [SKIPPED] python-libipa_hbac-1.13.1-4.fc24.x86_64.rpm: Already downloaded DEBUG util.py:393: [SKIPPED] libipa_hbac-1.13.1-4.fc24.x86_64.rpm: Already downloaded DEBUG util.py:393: [SKIPPED] libsss_idmap-devel-1.13.1-4.fc24.x86_64.rpm: Already downloaded DEBUG util.py:393: [SKIPPED] libsss_idmap-1.13.1-4.fc24.x86_64.rpm: Already downloaded DEBUG util.py:393: [SKIPPED] libsss_nss_idmap-devel-1.13.1-4.fc24.x86_64.rpm: Already downloaded DEBUG util.py:393: [SKIPPED] libsss_nss_idmap-1.13.1-4.fc24.x86_64.rpm: Already downloaded DEBUG util.py:393: Installing : libsss_nss_idmap-1.13.1-4.fc24.x86_64 91/241 DEBUG util.py:393: Installing : libsss_idmap-1.13.1-4.fc24.x86_64 92/241 DEBUG util.py:393: Installing : libipa_hbac-1.13.1-4.fc24.x86_64 195/241 DEBUG util.py:393: Installing : python-libipa_hbac-1.13.1-4.fc24.x86_64 212/241 DEBUG util.py:393: Installing : libsss_idmap-devel-1.13.1-4.fc24.x86_64 224/241 DEBUG util.py:393: Installing : libsss_nss_idmap-devel-1.13.1-4.fc24.x86_64 225/241 DEBUG util.py:393: Verifying : python-libipa_hbac-1.13.1-4.fc24.x86_64 19/241 DEBUG util.py:393: Verifying : libipa_hbac-1.13.1-4.fc24.x86_64 77/241 DEBUG util.py:393: Verifying : libsss_idmap-devel-1.13.1-4.fc24.x86_64 187/241 DEBUG util.py:393: Verifying : libsss_idmap-1.13.1-4.fc24.x86_64 188/241 DEBUG util.py:393: Verifying : libsss_nss_idmap-devel-1.13.1-4.fc24.x86_64 189/241 DEBUG util.py:393: Verifying : libsss_nss_idmap-1.13.1-4.fc24.x86_64 190/241 DEBUG util.py:393: libipa_hbac.x86_64 1.13.1-4.fc24 DEBUG util.py:393: libsss_idmap.x86_64 1.13.1-4.fc24 DEBUG util.py:393: libsss_idmap-devel.x86_64 1.13.1-4.fc24 DEBUG util.py:393: libsss_nss_idmap.x86_64 1.13.1-4.fc24 DEBUG util.py:393: libsss_nss_idmap-devel.x86_64 1.13.1-4.fc24 DEBUG util.py:393: python-libipa_hbac.x86_64 1.13.1-4.fc24 and freeipa packages were successfully built. http://paste.fedoraproject.org/287118/07222144 LS -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
Re: [Freeipa-devel] [PATCH] SPEC: Drop sssd from BuildRequires
On Tue, 03 Nov 2015, Lukas Slebodnik wrote: From c466be0e769a80fe204fc70675b8fa0ea3efb7b2 Mon Sep 17 00:00:00 2001 From: Lukas Slebodnik Date: Mon, 2 Nov 2015 19:52:57 + Subject: [PATCH] SPEC: Drop sssd from BuildRequires Packaging of sssd was changed and more sub-packages are build from sssd.src.rpm. Especially python bindings and development packages are already in sub-packages. As a result of this change the meta package sssd can be removed from BuildRequires without any problem. FreeIPA spec file contained build requirement for latest version of sssd even though the latest sssd was not required for building FreeIPA rpms. In many cases, it was sufficient just to change requirements for FreeIPA packages instead of build requirements. ACK -- we have explicit requirements to separate SSSD components (libsss_idmap, libsss_nss_idmap, python-libipa_hbac, to name a few). Perhaps, telling that your goal is to build without SSSD is somewhat misleading -- SSSD subpackages will be installed anyway and at least 1.12.1 will be required. -- / Alexander Bokovoy -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
