Re: [Freeipa-devel] [PATCH] SUDO Rule Search and Details Pages
On 11/19/2010 12:21 PM, Endi Sukma Dewata wrote: On 11/19/2010 11:18 AM, Dmitri Pal wrote: Endi Sukma Dewata wrote: On 11/19/2010 10:22 AM, Adam Young wrote: ACK. However, you will need to rebase, as Rob already made the index.html addition to ipa.spec.in Thanks. Rebased and pushed to master. I suspect it is the first pass at those since the UXD spec is underway for the SUDO pages. Yes, this is based on HBAC. At least the functionality works. We can revise the page again when the spec becomes available. ACK and pushed to master ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] SUDO Rule Search and Details Pages
On 11/19/2010 11:18 AM, Dmitri Pal wrote: Endi Sukma Dewata wrote: On 11/19/2010 10:22 AM, Adam Young wrote: ACK. However, you will need to rebase, as Rob already made the index.html addition to ipa.spec.in Thanks. Rebased and pushed to master. I suspect it is the first pass at those since the UXD spec is underway for the SUDO pages. Yes, this is based on HBAC. At least the functionality works. We can revise the page again when the spec becomes available. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] SUDO Rule Search and Details Pages
Endi Sukma Dewata wrote: > On 11/19/2010 10:22 AM, Adam Young wrote: >> ACK. However, you will need to rebase, as Rob already made the >> index.html addition to ipa.spec.in > > Thanks. Rebased and pushed to master. > I suspect it is the first pass at those since the UXD spec is underway for the SUDO pages. -- Thank you, Dmitri Pal Sr. Engineering Manager IPA project, Red Hat Inc. --- Looking to carve out IT costs? www.redhat.com/carveoutcosts/ ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] SUDO Rule Search and Details Pages
On 11/19/2010 10:22 AM, Adam Young wrote: ACK. However, you will need to rebase, as Rob already made the index.html addition to ipa.spec.in Thanks. Rebased and pushed to master. -- Endi S. Dewata ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCH] SUDO Rule Search and Details Pages
On 11/18/2010 09:33 PM, Endi Sukma Dewata wrote: Hi, Please review the attached patch. Thanks! The search and details pages for SUDO Rule have been added. Codes that are shared with HBAC have been moved to rule.js. The following methods were renamed for consistency: - ipa_details_load() -> ipa_details_refresh() - ipa_details_display() -> ipa_details_load() The ipa_details_cache has been removed because the cache is now stored in each widget. The index.xhtml has been removed. All references to it has been changed to index.html. The Unselect All checkbox has been fixed. Unnecessary parameter 'container' has been removed. The unit test has been updated and new test data has been added. ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel ACK. However, you will need to rebase, as Rob already made the index.html addition to ipa.spec.in ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
