Re: [Freeipa-devel] [PATCH] admiyo-0168-target-style-cleanup

2011-01-26 Thread Kyle Baker
ACK

- Original Message -
 Does not depend on any previous patches.
 
 ___
 Freeipa-devel mailing list
 Freeipa-devel@redhat.com
 https://www.redhat.com/mailman/listinfo/freeipa-devel
From 106b8f90f482c86b491af710296129b354b56597 Mon Sep 17 00:00:00 2001
From: Adam Young ayo...@redhat.com
Date: Wed, 26 Jan 2011 16:11:22 -0500
Subject: [PATCH] target style cleanup

Target section had radio buttonsreversed, and a few other style changes
---
 install/ui/aci.js  |   26 +--
 install/ui/ipa.css |  119 
 2 files changed, 94 insertions(+), 51 deletions(-)

diff --git a/install/ui/aci.js b/install/ui/aci.js
index 91be59acc210aa7e305bdbd693934ff6e1602f37..3846789ae6ac7d2d94bc56bb7d879fa01c9f882a 100644
--- a/install/ui/aci.js
+++ b/install/ui/aci.js
@@ -53,10 +53,11 @@ IPA.attribute_table_widget= function (spec){
 var that = IPA.widget(spec);
 var object_type = spec.objecttype || 'user';
 var table;
+var dd_class = other;
 
 that.create = function(container){
 
-var dd  = $('dd/').appendTo(container);
+var dd  = $('dd/',{class:dd_class}).appendTo(container);
 table =   $('table/',{
 id:id,
 'class':'search-table aci-attribute-table'}).
@@ -323,14 +324,14 @@ IPA.target_section = function () {
 
 function display_filter_target(dl){
 $(dt/).
-append($(label/,{
-text:  Filter })).
 append($('input/',{
 type:radio,
 name:type,
 checked:true,
 id:aci_by_filter
 })).
+append($(label/,{
+text:  Filter })).
 appendTo(dl);
 
 $('dd/',{
@@ -347,13 +348,13 @@ IPA.target_section = function () {
 
 function display_type_target(dl){
 $(dt/).
-append($(label/,{
-text:  Object By Type  })).
 append($('input/',{
 type:radio,
 name:type,
 checked:true,
 id:aci_by_type })).
+append($(label/,{
+text:  Object By Type  })).
 appendTo(dl);
 
 var dd = $('dd/',{
@@ -375,8 +376,6 @@ IPA.target_section = function () {
 text:  type_params.values[pc]
 }));
 }
-dd = $('dd /',{
-class:aci_by_type other}).appendTo(dl);
 
 var attribute_table = IPA.attribute_table_widget(
 {name:'aci_attributes_table',object_type:'user'});
@@ -388,11 +387,11 @@ IPA.target_section = function () {
 
 function display_query_target(dl){
 $('dt/').
-append($('label /',{ html: 'By Subtree'} )).
 append($('input /',{
 type:radio,
 name:type,
 id:aci_by_query })).
+append($('label /',{ html: 'By Subtree'} )).
 appendTo(dl);
 
 $(dd/,{
@@ -427,12 +426,12 @@ IPA.target_section = function () {
 
 function display_group_target(dl){
 $('dt/' ).
+append($('input /',{
+type:radio,
+name:type,
+id:aci_by_group })).
 append($('label /',{
 html: 'Target Group'} )).
-append($('input /',{
-type:radio,
-name:type,
-id:aci_by_group })).
 appendTo(dl);
 
 that.group_filter = $('input/',{
@@ -459,8 +458,7 @@ IPA.target_section = function () {
 }
 
 that.create = function(container) {
-var dl =  $('dl class=entryattrs/').appendTo(container);
-
+var dl =  $('dl class=aci-target/').appendTo(container);
 display_filter_target(dl);
 display_query_target(dl);
 display_group_target(dl);
diff --git a/install/ui/ipa.css b/install/ui/ipa.css
index 67fa0338f8ba549f29ab00a55abd26ac6af86864..7938f8a23c0d8fe408c7c909d347933f35c7b421 100644
--- a/install/ui/ipa.css
+++ b/install/ui/ipa.css
@@ -13,7 +13,7 @@
 
 body{
 background-image:url(outer-bg.png);
-background-repeat:repeat-x; 
+background-repeat:repeat-x;
 background-position:left top;
 background-color:#ededed;
 border-width: 0;
@@ -98,7 +98,7 @@ div.tabs {
 width: 100%;
 height: 100%;
 min-height: 40em;
-	background: url(centered-bg.png) no-repeat scroll 0 8.4em transparent;
+background: url(centered-bg.png) no-repeat scroll 0 8.4em transparent;
 }
 
 div#content {
@@ -148,11 +148,11 @@ h1 {
 
 .entity-container h1{
 -moz-border-radius: 0.5em 0.5em 0 0;
-	background: -moz-linear-gradient(center top , #EE, #DFDFDF) repeat scroll 0 0 transparent;
-	margin-top: 1.5em;
-	padding: 0.5em 0.9em;
-	position: relative;
-	width: 40.5em;
+background: -moz-linear-gradient(center top , #EE, #DFDFDF) repeat scroll 0 0 transparent;
+margin-top: 1.5em;
+padding: 

Re: [Freeipa-devel] [PATCH] admiyo-0168-target-style-cleanup

2011-01-26 Thread Adam Young

On 01/26/2011 04:14 PM, Kyle Baker wrote:

ACK

- Original Message -

Does not depend on any previous patches.

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Pushed to master

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel