Re: [Freeipa-devel] [PATCH] admiyo-0221-action-panel-to-top-tabs

2011-04-26 Thread Endi Sukma Dewata
There are still some issues. Some of them have been discussed over IRC: On 4/25/2011 3:24 PM, Adam Young wrote: 11. Navigation error. Open User Groups tab, click one of the groups. Under Member Users, click one of the users. It will show an error dialog box (it has some typos too). Still a

Re: [Freeipa-devel] [PATCH] admiyo-0221-action-panel-to-top-tabs

2011-04-26 Thread Endi Sukma Dewata
On 4/26/2011 12:42 PM, Adam Young wrote: 20. The facet groups needs to be customizable. Currently it's stored in unordered set in entity's facet_group and the order is hard- coded in get_facet() and facet_tabs(). It would be difficult to workaround this limitations in custom facets. See how

Re: [Freeipa-devel] [PATCH] admiyo-0221-action-panel-to-top-tabs

2011-04-26 Thread Adam Young
On 04/26/2011 03:12 PM, Endi Sukma Dewata wrote: On 4/26/2011 12:42 PM, Adam Young wrote: 20. The facet groups needs to be customizable. Currently it's stored in unordered set in entity's facet_group and the order is hard- coded in get_facet() and facet_tabs(). It would be difficult to

Re: [Freeipa-devel] [PATCH] admiyo-0221-action-panel-to-top-tabs

2011-04-19 Thread Endi Sukma Dewata
On 4/19/2011 3:07 PM, Adam Young wrote: going to post this, but with a request to hold on pushing to the repo. I have not yet tested against selenium, and suspect that it will break all selenium test navigation. I've tested this patch with static data. There are some issues: 1. Incorrect data

Re: [Freeipa-devel] [PATCH] admiyo-0221-action-panel-to-top-tabs

2011-04-19 Thread Adam Young
Good points all. Only one minoir quibble, in-line. On 04/19/2011 05:31 PM, Endi Sukma Dewata wrote: On 4/19/2011 3:07 PM, Adam Young wrote: going to post this, but with a request to hold on pushing to the repo. I have not yet tested against selenium, and suspect that it will break all