Re: [Freeipa-devel] [PATCH] bynd-dyndb-ldap: Fix keytab checking

2010-12-21 Thread Simo Sorce 
On Fri, 17 Dec 2010 17:47:39 +0100
Zoran Pericic  wrote:

> On 12/16/2010 08:06 PM, Simo Sorce wrote:
> 
> > Obvious ACK,
> > I will put the change in myself unless you can send me a git
> > formatted patch I can git am into my tree.
> 
> Thunerbird converted tabs to spaces. I hope this is ok.
> 
> Best regards,
> Zoran Pericic
> 
> diff --git a/src/krb5_helper.c b/src/krb5_helper.c
> index
> a52b412f10551dfb4079ef5add37d0ebe000d310..571f511c71a4a0d547e0e74f5b5109a0bd5498b1
> 100644 --- a/src/krb5_helper.c +++ b/src/krb5_helper.c
> @@ -111,7 +111,7 @@ get_krb5_tgt(isc_mem_t *mctx, const char
> *principal, const char *keyfile) DEFAULT_KEYTAB);
>   keyfile = DEFAULT_KEYTAB;
>   } else {
> - if (strcmp(keyfile, "FILE:") != 0) {
> + if (strncmp(keyfile, "FILE:", 5) != 0) {
>   log_error("Unknown keytab file name format,
> " "missing leading 'FILE:' prefix");
>   return ISC_R_FAILURE;

This patch was pushed by Adam.

Simo.


-- 
Simo Sorce * Red Hat, Inc * New York

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] bynd-dyndb-ldap: Fix keytab checking

2010-12-17 Thread Zoran Pericic 

On 12/17/2010 06:06 PM, Stephen Gallagher wrote:


Zoran, it is generally preferred to create the patch with the command:
git format-patch -M -C --patience --full-index -1

Then attach the file to the email, rather than copying it in. If you
have more than one patch in your tree that you want to send, change "-1"
to "-2", "-3", etc.


Thanks. Will look at git documentation.

Best regard,
Zoran Pericic

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] bynd-dyndb-ldap: Fix keytab checking

2010-12-17 Thread Stephen Gallagher 
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

On 12/17/2010 11:47 AM, Zoran Pericic wrote:
> On 12/16/2010 08:06 PM, Simo Sorce wrote:
> 
>> Obvious ACK,
>> I will put the change in myself unless you can send me a git formatted
>> patch I can git am into my tree.
> 
> Thunerbird converted tabs to spaces. I hope this is ok.
> 

Zoran, it is generally preferred to create the patch with the command:

git format-patch -M -C --patience --full-index -1

Then attach the file to the email, rather than copying it in. If you
have more than one patch in your tree that you want to send, change "-1"
to "-2", "-3", etc.

- -- 
Stephen Gallagher
RHCE 804006346421761

Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/

iEYEARECAAYFAk0LmKoACgkQeiVVYja6o6MOdQCgrNMqGqpd57oX6dY75SU50Oqw
TakAoK+Ez7RNR/piaP1eutba2dRU8cYn
=+K+j
-END PGP SIGNATURE-

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] bynd-dyndb-ldap: Fix keytab checking

2010-12-17 Thread Zoran Pericic 

On 12/16/2010 08:06 PM, Simo Sorce wrote:


Obvious ACK,
I will put the change in myself unless you can send me a git formatted
patch I can git am into my tree.


Thunerbird converted tabs to spaces. I hope this is ok.

Best regards,
Zoran Pericic

diff --git a/src/krb5_helper.c b/src/krb5_helper.c
index 
a52b412f10551dfb4079ef5add37d0ebe000d310..571f511c71a4a0d547e0e74f5b5109a0bd5498b1
 100644
--- a/src/krb5_helper.c
+++ b/src/krb5_helper.c
@@ -111,7 +111,7 @@ get_krb5_tgt(isc_mem_t *mctx, const char *principal, const 
char *keyfile)
  DEFAULT_KEYTAB);
keyfile = DEFAULT_KEYTAB;
} else {
-   if (strcmp(keyfile, "FILE:") != 0) {
+   if (strncmp(keyfile, "FILE:", 5) != 0) {
log_error("Unknown keytab file name format, "
  "missing leading 'FILE:' prefix");
return ISC_R_FAILURE;

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] bynd-dyndb-ldap: Fix keytab checking

2010-12-16 Thread Simo Sorce 
On Thu, 16 Dec 2010 19:39:38 +0100
Zoran Pericic  wrote:

> 
> diff -ur bind-dyndb-ldap-0.1.0b.org/src/krb5_helper.c 
> bind-dyndb-ldap-0.1.0b.keytab/src/krb5_helper.c
> --- bind-dyndb-ldap-0.1.0b.org/src/krb5_helper.c2009-09-06 
> 22:50:14.0 +0200
> +++ bind-dyndb-ldap-0.1.0b.keytab/src/krb5_helper.c2010-12-16 
> 19:30:18.281267020 +0100
> @@ -111,7 +111,7 @@
> DEFAULT_KEYTAB);
>   keyfile = DEFAULT_KEYTAB;
>   } else {
> -if (strcmp(keyfile, "FILE:") != 0) {
> +if (strncmp(keyfile, "FILE:", 5) != 0) {
>   log_error("Unknown keytab file name format, "
> "missing leading 'FILE:' prefix");
>   return ISC_R_FAILURE;

Obvious ACK,
I will put the change in myself unless you can send me a git formatted
patch I can git am into my tree.

Simo.

-- 
Simo Sorce * Red Hat, Inc * New York

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel