Re: [Freeipa-devel] [PATCH] fix default install with dogtag

2010-11-19 Thread Rob Crittenden 

Simo Sorce wrote:


This patch automatically disables pkinit when installing with
dogatg until dogtag support is added to the pkinit install bits.

Simo.



nack

I think this should be just: if not options.selfsign: ...

external_cert_file and external_ca_file are used when you are setting up 
dogtag as a subordinate of another CA. But it is still just setting up 
dogtag.


rob

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH] fix default install with dogtag

2010-11-19 Thread Simo Sorce 
On Fri, 19 Nov 2010 14:18:36 -0500
Rob Crittenden rcrit...@redhat.com wrote:

 Simo Sorce wrote:
  On Fri, 19 Nov 2010 13:45:11 -0500
  Rob Crittendenrcrit...@redhat.com  wrote:
 
  Simo Sorce wrote:
 
  This patch automatically disables pkinit when installing with
  dogatg until dogtag support is added to the pkinit install bits.
 
  Simo.
 
 
  nack
 
  I think this should be just: if not options.selfsign: ...
 
  external_cert_file and external_ca_file are used when you are
  setting up dogtag as a subordinate of another CA. But it is still
  just setting up dogtag.
 
  I took the wrong option, I meant to not disable pkinit if you pass
  in explicitly a pkinit certificate when external certs are used.
 
  Attached new patch.
 
  Simo.
 
 
 ack

rebased and pushed.

Simo.

-- 
Simo Sorce * Red Hat, Inc * New York

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel