Re: [Freeipa-devel] [PATCH] reduce redundant checks in ldapsam_search_users()

2012-07-06 Thread Simo Sorce
On Fri, 2012-07-06 at 12:51 +0300, Alexander Bokovoy wrote: > Hi, > > Obvious clean up in ldapsam_search_users(): every branch is setting > the > same base dn and nothing else. > ACK, Simo. -- Simo Sorce * Red Hat, Inc * New York ___ Freeipa-devel ma

Re: [Freeipa-devel] [PATCH] reduce redundant checks in ldapsam_search_users()

2012-07-06 Thread Alexander Bokovoy
On Fri, 06 Jul 2012, Sumit Bose wrote: On Fri, Jul 06, 2012 at 01:18:28PM +0300, Alexander Bokovoy wrote: On Fri, 06 Jul 2012, Alexander Bokovoy wrote: >Hi, > >Obvious clean up in ldapsam_search_users(): every branch is setting the >same base dn and nothing else. Merged the line with talloc_strd

Re: [Freeipa-devel] [PATCH] reduce redundant checks in ldapsam_search_users()

2012-07-06 Thread Sumit Bose
On Fri, Jul 06, 2012 at 01:18:28PM +0300, Alexander Bokovoy wrote: > On Fri, 06 Jul 2012, Alexander Bokovoy wrote: > >Hi, > > > >Obvious clean up in ldapsam_search_users(): every branch is setting the > >same base dn and nothing else. > Merged the line with talloc_strdup() call few lines after that

Re: [Freeipa-devel] [PATCH] reduce redundant checks in ldapsam_search_users()

2012-07-06 Thread Alexander Bokovoy
On Fri, 06 Jul 2012, Alexander Bokovoy wrote: Hi, Obvious clean up in ldapsam_search_users(): every branch is setting the same base dn and nothing else. Merged the line with talloc_strdup() call few lines after that. -- / Alexander Bokovoy >From bf06e39a143967d3d99dcfe3fcd4d7f2a5f0142c Mon Sep