Re: [Freeipa-devel] [PATCH 0006-0010] Low hanging fruit for #5343 -- platform abstractions

2015-11-04 Thread Tomas Babej
On 11/04/2015 12:58 PM, Tomas Babej wrote: > On 10/21/2015 06:05 PM, Timo Aaltonen wrote: >> On 07.10.2015 17:26, Martin Basti wrote: >>> thanks comments inline >> >> Hey, >> >> I hope these versions address the issues in the first batch.. >> > > Hi Timo, > > this patchset works fine, thanks. >

Re: [Freeipa-devel] [PATCH 0006-0010] Low hanging fruit for #5343 -- platform abstractions

2015-11-04 Thread Tomas Babej
On 10/21/2015 06:05 PM, Timo Aaltonen wrote: > On 07.10.2015 17:26, Martin Basti wrote: >> thanks comments inline > > Hey, > > I hope these versions address the issues in the first batch.. > Hi Timo, this patchset works fine, thanks. Seems you generated it in a non-standard way, it could not

Re: [Freeipa-devel] [PATCH 0006-0010] Low hanging fruit for #5343 -- platform abstractions

2015-10-21 Thread Timo Aaltonen
On 07.10.2015 17:26, Martin Basti wrote: > thanks comments inline Hey, I hope these versions address the issues in the first batch.. -- t commit 8fd0109b13eb87db2cfd22fe412e3adc4c0db9c3 Author: Timo Aaltonen Date: Tue Oct 6 16:02:37 2015 +0300 ipaplatform: Add HTTPD_USER to constants, a

Re: [Freeipa-devel] [PATCH 0006-0010] Low hanging fruit for #5343 -- platform abstractions

2015-10-07 Thread Martin Basti
thanks comments inline On 10/07/2015 12:51 PM, Tomas Babej wrote: On Tue, Oct 06, 2015 at 09:58:04PM +0300, Timo Aaltonen wrote: Hi So here's the first batch of quick patches for ticket #5343. They're only compile-tested so far (so no stupid mistakes I hope), as I don't have 4.2+ wo

Re: [Freeipa-devel] [PATCH 0006-0010] Low hanging fruit for #5343 -- platform abstractions

2015-10-07 Thread Tomas Babej
On Wed, Oct 07, 2015 at 12:51:10PM +0200, Tomas Babej wrote: > On Tue, Oct 06, 2015 at 09:58:04PM +0300, Timo Aaltonen wrote: > > > > Hi > > > > So here's the first batch of quick patches for ticket #5343. They're > > only compile-tested so far (so no stupid mistakes I hope), as I don't > >

Re: [Freeipa-devel] [PATCH 0006-0010] Low hanging fruit for #5343 -- platform abstractions

2015-10-07 Thread Tomas Babej
On Tue, Oct 06, 2015 at 09:58:04PM +0300, Timo Aaltonen wrote: > > Hi > > So here's the first batch of quick patches for ticket #5343. They're > only compile-tested so far (so no stupid mistakes I hope), as I don't > have 4.2+ working yet. Wonder how the quotes in the last patch work, but