I cannot apply your patch on master branch, missing blobs, can you
rebase please?
On 06.01.2016 11:47, Oleg Fayans wrote:
Any chance this patch can be merged this week?
On 12/14/2015 02:08 PM, Oleg Fayans wrote:
Hi Martin,
On 12/11/2015 05:58 PM, Martin Basti wrote:
On 11.12.2015 17:28, Ol
Any chance this patch can be merged this week?
On 12/14/2015 02:08 PM, Oleg Fayans wrote:
> Hi Martin,
>
> On 12/11/2015 05:58 PM, Martin Basti wrote:
>>
>>
>> On 11.12.2015 17:28, Oleg Fayans wrote:
>>> +myre = re.compile(".*Backed up to (?P.*?)\n.*")
>>
>> IMO this regexp is not good.
>>
>>
Hi Martin,
On 12/11/2015 05:58 PM, Martin Basti wrote:
>
>
> On 11.12.2015 17:28, Oleg Fayans wrote:
>> +myre = re.compile(".*Backed up to (?P.*?)\n.*")
>
> IMO this regexp is not good.
>
> 1)
> please name it better than "myre"
Done
>
> 2)
> initial '.*' is not needed because regexp do
On 11.12.2015 17:28, Oleg Fayans wrote:
+myre = re.compile(".*Backed up to (?P.*?)\n.*")
IMO this regexp is not good.
1)
please name it better than "myre"
2)
initial '.*' is not needed because regexp does not start with '^' and
you use search() later
3)
trailing '.*' is not needed a
On 12/11/2015 05:28 PM, Oleg Fayans wrote:
HI Oleg,
could you prefix the commit message and mail subject with "tests: " or
something similar to make clear that this is a fix in tests and not
actual CA or KRA installation.
--
Petr Vobornik
--
Manage your subscription for the Freeipa-devel mai
