Re: [Freeipa-devel] [PATCH 0040-0045] DNSSEC improvements

2015-06-29 Thread Tomas Babej
On 06/29/2015 01:36 PM, Tomas Babej wrote:
> 
> 
> On 06/29/2015 01:14 PM, Martin Basti wrote:
>> On 26/06/15 18:55, Petr Spacek wrote:
>>> Hello,
>>>
>>> attached patches implement a portion of improvements for ticket
>>> https://fedorahosted.org/freeipa/ticket/4657
>>>
>>> It came to my mind that it will be better to review them at once - the
>>> previous threads with my patches 40 and 41 can be abandoned.
>>>
>>> I'm sorry for the mess.
>>>
>>>
>>>
>> ACK
>>
>> -- 
>> Martin Basti
>>
>>
>>
> 
> Martin told me offline there is some potential issue with the patch, so
> it should not be pushed as of now.
> 

Pushed to:
ipa-4-1: a9831406bf0d205ac431aadc32b7ef03f74a2bfc
master: f9cbdd4915d13cd6e20fe7631d3c95c1352860f9

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code


Re: [Freeipa-devel] [PATCH 0040-0045] DNSSEC improvements

2015-06-29 Thread Tomas Babej


On 06/29/2015 01:14 PM, Martin Basti wrote:
> On 26/06/15 18:55, Petr Spacek wrote:
>> Hello,
>>
>> attached patches implement a portion of improvements for ticket
>> https://fedorahosted.org/freeipa/ticket/4657
>>
>> It came to my mind that it will be better to review them at once - the
>> previous threads with my patches 40 and 41 can be abandoned.
>>
>> I'm sorry for the mess.
>>
>>
>>
> ACK
> 
> -- 
> Martin Basti
> 
> 
> 

Martin told me offline there is some potential issue with the patch, so
it should not be pushed as of now.

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code


Re: [Freeipa-devel] [PATCH 0040-0045] DNSSEC improvements

2015-06-29 Thread Martin Basti

On 26/06/15 18:55, Petr Spacek wrote:

Hello,

attached patches implement a portion of improvements for ticket
https://fedorahosted.org/freeipa/ticket/4657

It came to my mind that it will be better to review them at once - the
previous threads with my patches 40 and 41 can be abandoned.

I'm sorry for the mess.




ACK

--
Martin Basti

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code