Re: [Freeipa-devel] [PATCH 0043] Stop uninstaller from failing if a service can't be started

2016-06-24 Thread Stanislav Laznicka
On 06/24/2016 04:04 PM, Martin Basti wrote: On 24.06.2016 15:50, Stanislav Laznicka wrote: On 06/21/2016 04:39 PM, Martin Basti wrote: On 14.06.2016 17:26, Stanislav Laznicka wrote: -signerd_service.start() +try: +signerd_service.start() +

Re: [Freeipa-devel] [PATCH 0043] Stop uninstaller from failing if a service can't be started

2016-06-24 Thread Stanislav Laznicka
On 06/21/2016 04:39 PM, Martin Basti wrote: On 14.06.2016 17:26, Stanislav Laznicka wrote: -signerd_service.start() +try: +signerd_service.start() +except Exception as e: +root_logger.error("Unable to start '{svcname}':

Re: [Freeipa-devel] [PATCH 0043] Stop uninstaller from failing if a service can't be started

2016-06-21 Thread Martin Basti
On 14.06.2016 17:26, Stanislav Laznicka wrote: -signerd_service.start() +try: +signerd_service.start() +except Exception as e: +root_logger.error("Unable to start '{svcname}': {err}" +

Re: [Freeipa-devel] [PATCH 0043] Stop uninstaller from failing if a service can't be started

2016-06-14 Thread Stanislav Laznicka
On 06/14/2016 09:25 AM, Stanislav Laznicka wrote: On 06/13/2016 02:51 PM, Martin Babinsky wrote: On 06/07/2016 10:14 AM, Stanislav Laznicka wrote: https://fedorahosted.org/freeipa/ticket/5775 Umm, wouldn't it be better to augment the `Service.start()/restart()` methods themselves with

Re: [Freeipa-devel] [PATCH 0043] Stop uninstaller from failing if a service can't be started

2016-06-14 Thread Stanislav Laznicka
On 06/13/2016 02:51 PM, Martin Babinsky wrote: On 06/07/2016 10:14 AM, Stanislav Laznicka wrote: https://fedorahosted.org/freeipa/ticket/5775 Umm, wouldn't it be better to augment the `Service.start()/restart()` methods themselves with parameters that will suppress exception raising and

Re: [Freeipa-devel] [PATCH 0043] Stop uninstaller from failing if a service can't be started

2016-06-13 Thread Martin Babinsky
On 06/07/2016 10:14 AM, Stanislav Laznicka wrote: https://fedorahosted.org/freeipa/ticket/5775 Umm, wouldn't it be better to augment the `Service.start()/restart()` methods themselves with parameters that will suppress exception raising and log an error instead of copy-pasting try: ...

Re: [Freeipa-devel] [PATCH 0043] Stop uninstaller from failing if a service can't be started

2016-06-13 Thread Florence Blanc-Renaud
On 06/07/2016 10:14 AM, Stanislav Laznicka wrote: https://fedorahosted.org/freeipa/ticket/5775 LGTM, ACK -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code