Re: [Freeipa-devel] [PATCH 0083-0084] Fix DNS zone overlap check to allow ipa-replica-install to worFix dns_is_enabled() API command to throw exceptions as appropriat

2016-01-08 Thread David Kupka

On 07/01/16 16:26, Petr Spacek wrote:

Hello,

Fix DNS zone overlap check to allow ipa-replica-install to work.

My review script claims that
"No problems detected using lint, pep8, ./make{api,aci}, and VERSION"

Please review.


Thanks, looks good and works as expected for me, ACK.

--
David Kupka

--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code


Re: [Freeipa-devel] [PATCH 0083-0084] Fix DNS zone overlap check to allow ipa-replica-install to worFix dns_is_enabled() API command to throw exceptions as appropriat

2016-01-08 Thread Martin Basti



On 08.01.2016 09:59, David Kupka wrote:

On 07/01/16 16:26, Petr Spacek wrote:

Hello,

Fix DNS zone overlap check to allow ipa-replica-install to work.

My review script claims that
"No problems detected using lint, pep8, ./make{api,aci}, and VERSION"

Please review.


Thanks, looks good and works as expected for me, ACK.


Pushed to:
master: 3d1a8d31343ce0a71d3236e9d8457a06e12c07a9
ipa-4-3: b9f2a7c523f27c09ef31573d174cdb6f3456a23b

--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code