Re: [Freeipa-devel] [PATCH 0084-0086] CI: Add double circle topology
On 24.02.2016 10:07, David Kupka wrote: On 24/02/16 08:27, David Kupka wrote: On 23/02/16 17:54, Martin Basti wrote: On 23.02.2016 17:33, Martin Basti wrote: On 23.02.2016 17:30, Martin Basti wrote: On 18.02.2016 10:14, David Kupka wrote: On 12/02/16 16:52, Martin Basti wrote: On 12.02.2016 13:03, Milan Kubík wrote: On 02/12/2016 10:59 AM, David Kupka wrote: Sending one more topology test. This one creates a M groups consisting N (N>=2) servers. First two servers in each group are used to connect with nearest four groups and also with the other servers inside the group (when N>2). Servers inside the group (not connecting to other groups) are connected with each other. The patch set needs freeipa-dkupka-8{1,2,3} applied. ACK I cannot apply patches, please rebase [mbasti@dhcp129-96 freeipa-devel]$ git checkout master Switched to branch 'master' Your branch is up-to-date with 'origin/master'. [mbasti@dhcp129-96 freeipa-devel]$ git am freeipa-dkupka-008* -3 Applying: CI: Add '2-connected' topology generator. Applying: CI: Add simple replication test in 2-connected topology. Applying: CI: Add test for 2-connected topology generator. Applying: CI: Add double circle topology. Applying: CI: Add replication test utilizing double-circle topology. Applying: CI: Add test for double-circle topology generator. error: invalid object 100644 e12d141391840cc7f9150a178875393a96dd469b for 'ipatests/test_integration/test_topologies.py' fatal: git-write-tree: error building trees Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0006 CI: Add test for double-circle topology generator. The copy of the patch that failed is found in: /home/mbasti/work/freeipa-devel/.git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". Martin^2 Git fails to apply patches because wrong version of freeipa-dkupka-008{1,2,3} was pushed. Attached patches should fix it. Sorry my bad. ACK Pushed to: ipa-4-3: ffe3731ae7813fcc3246a83e37d62fc2754bb4ca master: acdabba6ec0f68841f02c1e6ad65232de81bb505 New test: Pushed to: master: a1e582b33c42bcc8a708777afb975e7dc571ee3d ipa-4-3: 2efa60637111e40a9ac9459d507d9f55a2ae301a Revert? IMO this will not work on python3 * Module ipatests.test_integration.test_topologies ipatests/test_integration/test_topologies.py:124: [W1638(range-builtin-not-iterating), test_topology_double_circle_topo] range built-in referenced when not iterating) * Module ipatests.test_integration.tasks ipatests/test_integration/tasks.py:949: [W0110(deprecated-lambda), double_circle_topo] map/filter on lambda could be replaced by comprehension) ipatests/test_integration/tasks.py:949: [W1636(map-builtin-not-iterating), double_circle_topo] map built-in referenced when not iterating) ipatests/test_integration/tasks.py:949: [W1637(zip-builtin-not-iterating), double_circle_topo] zip built-in referenced when not iterating) You can revert it and I will send fixed patches or you can just apply attached patch. Updated patch attached. ACK Pushed to: master: 775ee77bcc091ba31fdd3e59f8d45d0b646a44a0 ipa-4-3: 05539761cd6f7bd6ce40b687b913be81eabf69e1 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
Re: [Freeipa-devel] [PATCH 0084-0086] CI: Add double circle topology
On 24/02/16 08:27, David Kupka wrote: On 23/02/16 17:54, Martin Basti wrote: On 23.02.2016 17:33, Martin Basti wrote: On 23.02.2016 17:30, Martin Basti wrote: On 18.02.2016 10:14, David Kupka wrote: On 12/02/16 16:52, Martin Basti wrote: On 12.02.2016 13:03, Milan Kubík wrote: On 02/12/2016 10:59 AM, David Kupka wrote: Sending one more topology test. This one creates a M groups consisting N (N>=2) servers. First two servers in each group are used to connect with nearest four groups and also with the other servers inside the group (when N>2). Servers inside the group (not connecting to other groups) are connected with each other. The patch set needs freeipa-dkupka-8{1,2,3} applied. ACK I cannot apply patches, please rebase [mbasti@dhcp129-96 freeipa-devel]$ git checkout master Switched to branch 'master' Your branch is up-to-date with 'origin/master'. [mbasti@dhcp129-96 freeipa-devel]$ git am freeipa-dkupka-008* -3 Applying: CI: Add '2-connected' topology generator. Applying: CI: Add simple replication test in 2-connected topology. Applying: CI: Add test for 2-connected topology generator. Applying: CI: Add double circle topology. Applying: CI: Add replication test utilizing double-circle topology. Applying: CI: Add test for double-circle topology generator. error: invalid object 100644 e12d141391840cc7f9150a178875393a96dd469b for 'ipatests/test_integration/test_topologies.py' fatal: git-write-tree: error building trees Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0006 CI: Add test for double-circle topology generator. The copy of the patch that failed is found in: /home/mbasti/work/freeipa-devel/.git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". Martin^2 Git fails to apply patches because wrong version of freeipa-dkupka-008{1,2,3} was pushed. Attached patches should fix it. Sorry my bad. ACK Pushed to: ipa-4-3: ffe3731ae7813fcc3246a83e37d62fc2754bb4ca master: acdabba6ec0f68841f02c1e6ad65232de81bb505 New test: Pushed to: master: a1e582b33c42bcc8a708777afb975e7dc571ee3d ipa-4-3: 2efa60637111e40a9ac9459d507d9f55a2ae301a Revert? IMO this will not work on python3 * Module ipatests.test_integration.test_topologies ipatests/test_integration/test_topologies.py:124: [W1638(range-builtin-not-iterating), test_topology_double_circle_topo] range built-in referenced when not iterating) * Module ipatests.test_integration.tasks ipatests/test_integration/tasks.py:949: [W0110(deprecated-lambda), double_circle_topo] map/filter on lambda could be replaced by comprehension) ipatests/test_integration/tasks.py:949: [W1636(map-builtin-not-iterating), double_circle_topo] map built-in referenced when not iterating) ipatests/test_integration/tasks.py:949: [W1637(zip-builtin-not-iterating), double_circle_topo] zip built-in referenced when not iterating) You can revert it and I will send fixed patches or you can just apply attached patch. Updated patch attached. -- David Kupka From 1e12eb7d207e5980fb3653d5818968b129f4a1c9 Mon Sep 17 00:00:00 2001 From: David Kupka Date: Wed, 24 Feb 2016 08:15:51 +0100 Subject: [PATCH] CI: Make double circle topology python3 compatible --- ipatests/test_integration/tasks.py | 2 +- ipatests/test_integration/test_topologies.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/ipatests/test_integration/tasks.py b/ipatests/test_integration/tasks.py index 9d9a78bb10b463016c646aa921dde722e882da93..60e9e82391077ce6b997d0ed4ad4f2ff19f43d1e 100644 --- a/ipatests/test_integration/tasks.py +++ b/ipatests/test_integration/tasks.py @@ -946,7 +946,7 @@ def double_circle_topo(master, replicas, site_size=6): # split servers into sites it = [iter(servers)] * site_size -sites = map(lambda x: (x[0], x[1], x[2:]), zip(*it)) +sites = [(x[0], x[1], x[2:]) for x in zip(*it)] num_sites = len(sites) for i in range(num_sites): diff --git a/ipatests/test_integration/test_topologies.py b/ipatests/test_integration/test_topologies.py index a0a1b9d6222779a9ce67b2fa8a29052747eae8f9..4618b44fe3b6cd69149a5fb55b2b392c5383a5c2 100644 --- a/ipatests/test_integration/test_topologies.py +++ b/ipatests/test_integration/test_topologies.py @@ -121,7 +121,7 @@ def test_topology_two_connected(): def test_topology_double_circle_topo(): topo = tasks.get_topo('double-circle') assert topo == tasks.double_circle_topo -assert list(topo('M', range(1, 30))) == [ +assert list(topo('M', list(range(1, 30 == [ ('M', 1), (1, 6), (1, 12), -- 2.5.0 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
Re: [Freeipa-devel] [PATCH 0084-0086] CI: Add double circle topology
On 23/02/16 17:54, Martin Basti wrote: On 23.02.2016 17:33, Martin Basti wrote: On 23.02.2016 17:30, Martin Basti wrote: On 18.02.2016 10:14, David Kupka wrote: On 12/02/16 16:52, Martin Basti wrote: On 12.02.2016 13:03, Milan Kubík wrote: On 02/12/2016 10:59 AM, David Kupka wrote: Sending one more topology test. This one creates a M groups consisting N (N>=2) servers. First two servers in each group are used to connect with nearest four groups and also with the other servers inside the group (when N>2). Servers inside the group (not connecting to other groups) are connected with each other. The patch set needs freeipa-dkupka-8{1,2,3} applied. ACK I cannot apply patches, please rebase [mbasti@dhcp129-96 freeipa-devel]$ git checkout master Switched to branch 'master' Your branch is up-to-date with 'origin/master'. [mbasti@dhcp129-96 freeipa-devel]$ git am freeipa-dkupka-008* -3 Applying: CI: Add '2-connected' topology generator. Applying: CI: Add simple replication test in 2-connected topology. Applying: CI: Add test for 2-connected topology generator. Applying: CI: Add double circle topology. Applying: CI: Add replication test utilizing double-circle topology. Applying: CI: Add test for double-circle topology generator. error: invalid object 100644 e12d141391840cc7f9150a178875393a96dd469b for 'ipatests/test_integration/test_topologies.py' fatal: git-write-tree: error building trees Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0006 CI: Add test for double-circle topology generator. The copy of the patch that failed is found in: /home/mbasti/work/freeipa-devel/.git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". Martin^2 Git fails to apply patches because wrong version of freeipa-dkupka-008{1,2,3} was pushed. Attached patches should fix it. Sorry my bad. ACK Pushed to: ipa-4-3: ffe3731ae7813fcc3246a83e37d62fc2754bb4ca master: acdabba6ec0f68841f02c1e6ad65232de81bb505 New test: Pushed to: master: a1e582b33c42bcc8a708777afb975e7dc571ee3d ipa-4-3: 2efa60637111e40a9ac9459d507d9f55a2ae301a Revert? IMO this will not work on python3 * Module ipatests.test_integration.test_topologies ipatests/test_integration/test_topologies.py:124: [W1638(range-builtin-not-iterating), test_topology_double_circle_topo] range built-in referenced when not iterating) * Module ipatests.test_integration.tasks ipatests/test_integration/tasks.py:949: [W0110(deprecated-lambda), double_circle_topo] map/filter on lambda could be replaced by comprehension) ipatests/test_integration/tasks.py:949: [W1636(map-builtin-not-iterating), double_circle_topo] map built-in referenced when not iterating) ipatests/test_integration/tasks.py:949: [W1637(zip-builtin-not-iterating), double_circle_topo] zip built-in referenced when not iterating) You can revert it and I will send fixed patches or you can just apply attached patch. -- David Kupka From a46ba01172e666d8afdac5e0605f32110138ea39 Mon Sep 17 00:00:00 2001 From: David Kupka Date: Wed, 24 Feb 2016 08:15:51 +0100 Subject: [PATCH] CI: Make double circle topology python3 compatible --- ipatests/test_integration/tasks.py | 2 +- ipatests/test_integration/test_topologies.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/ipatests/test_integration/tasks.py b/ipatests/test_integration/tasks.py index 9d9a78bb10b463016c646aa921dde722e882da93..60e9e82391077ce6b997d0ed4ad4f2ff19f43d1e 100644 --- a/ipatests/test_integration/tasks.py +++ b/ipatests/test_integration/tasks.py @@ -946,7 +946,7 @@ def double_circle_topo(master, replicas, site_size=6): # split servers into sites it = [iter(servers)] * site_size -sites = map(lambda x: (x[0], x[1], x[2:]), zip(*it)) +sites = [(x[0], x[1], x[2:]) for x in zip(*it)] num_sites = len(sites) for i in range(num_sites): diff --git a/ipatests/test_integration/test_topologies.py b/ipatests/test_integration/test_topologies.py index a0a1b9d6222779a9ce67b2fa8a29052747eae8f9..4bdff44a162e188c0549b6ecca12ae658839e5cd 100644 --- a/ipatests/test_integration/test_topologies.py +++ b/ipatests/test_integration/test_topologies.py @@ -121,7 +121,7 @@ def test_topology_two_connected(): def test_topology_double_circle_topo(): topo = tasks.get_topo('double-circle') assert topo == tasks.double_circle_topo -assert list(topo('M', range(1, 30))) == [ +assert list(topo('M', [r for r in range(1, 30)])) == [ ('M', 1), (1, 6), (1, 12), -- 2.5.0 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
Re: [Freeipa-devel] [PATCH 0084-0086] CI: Add double circle topology
On 23.02.2016 17:33, Martin Basti wrote: On 23.02.2016 17:30, Martin Basti wrote: On 18.02.2016 10:14, David Kupka wrote: On 12/02/16 16:52, Martin Basti wrote: On 12.02.2016 13:03, Milan Kubík wrote: On 02/12/2016 10:59 AM, David Kupka wrote: Sending one more topology test. This one creates a M groups consisting N (N>=2) servers. First two servers in each group are used to connect with nearest four groups and also with the other servers inside the group (when N>2). Servers inside the group (not connecting to other groups) are connected with each other. The patch set needs freeipa-dkupka-8{1,2,3} applied. ACK I cannot apply patches, please rebase [mbasti@dhcp129-96 freeipa-devel]$ git checkout master Switched to branch 'master' Your branch is up-to-date with 'origin/master'. [mbasti@dhcp129-96 freeipa-devel]$ git am freeipa-dkupka-008* -3 Applying: CI: Add '2-connected' topology generator. Applying: CI: Add simple replication test in 2-connected topology. Applying: CI: Add test for 2-connected topology generator. Applying: CI: Add double circle topology. Applying: CI: Add replication test utilizing double-circle topology. Applying: CI: Add test for double-circle topology generator. error: invalid object 100644 e12d141391840cc7f9150a178875393a96dd469b for 'ipatests/test_integration/test_topologies.py' fatal: git-write-tree: error building trees Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0006 CI: Add test for double-circle topology generator. The copy of the patch that failed is found in: /home/mbasti/work/freeipa-devel/.git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". Martin^2 Git fails to apply patches because wrong version of freeipa-dkupka-008{1,2,3} was pushed. Attached patches should fix it. Sorry my bad. ACK Pushed to: ipa-4-3: ffe3731ae7813fcc3246a83e37d62fc2754bb4ca master: acdabba6ec0f68841f02c1e6ad65232de81bb505 New test: Pushed to: master: a1e582b33c42bcc8a708777afb975e7dc571ee3d ipa-4-3: 2efa60637111e40a9ac9459d507d9f55a2ae301a Revert? IMO this will not work on python3 * Module ipatests.test_integration.test_topologies ipatests/test_integration/test_topologies.py:124: [W1638(range-builtin-not-iterating), test_topology_double_circle_topo] range built-in referenced when not iterating) * Module ipatests.test_integration.tasks ipatests/test_integration/tasks.py:949: [W0110(deprecated-lambda), double_circle_topo] map/filter on lambda could be replaced by comprehension) ipatests/test_integration/tasks.py:949: [W1636(map-builtin-not-iterating), double_circle_topo] map built-in referenced when not iterating) ipatests/test_integration/tasks.py:949: [W1637(zip-builtin-not-iterating), double_circle_topo] zip built-in referenced when not iterating) -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
Re: [Freeipa-devel] [PATCH 0084-0086] CI: Add double circle topology
On 23.02.2016 17:30, Martin Basti wrote: On 18.02.2016 10:14, David Kupka wrote: On 12/02/16 16:52, Martin Basti wrote: On 12.02.2016 13:03, Milan Kubík wrote: On 02/12/2016 10:59 AM, David Kupka wrote: Sending one more topology test. This one creates a M groups consisting N (N>=2) servers. First two servers in each group are used to connect with nearest four groups and also with the other servers inside the group (when N>2). Servers inside the group (not connecting to other groups) are connected with each other. The patch set needs freeipa-dkupka-8{1,2,3} applied. ACK I cannot apply patches, please rebase [mbasti@dhcp129-96 freeipa-devel]$ git checkout master Switched to branch 'master' Your branch is up-to-date with 'origin/master'. [mbasti@dhcp129-96 freeipa-devel]$ git am freeipa-dkupka-008* -3 Applying: CI: Add '2-connected' topology generator. Applying: CI: Add simple replication test in 2-connected topology. Applying: CI: Add test for 2-connected topology generator. Applying: CI: Add double circle topology. Applying: CI: Add replication test utilizing double-circle topology. Applying: CI: Add test for double-circle topology generator. error: invalid object 100644 e12d141391840cc7f9150a178875393a96dd469b for 'ipatests/test_integration/test_topologies.py' fatal: git-write-tree: error building trees Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0006 CI: Add test for double-circle topology generator. The copy of the patch that failed is found in: /home/mbasti/work/freeipa-devel/.git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". Martin^2 Git fails to apply patches because wrong version of freeipa-dkupka-008{1,2,3} was pushed. Attached patches should fix it. Sorry my bad. ACK Pushed to: ipa-4-3: ffe3731ae7813fcc3246a83e37d62fc2754bb4ca master: acdabba6ec0f68841f02c1e6ad65232de81bb505 New test: Pushed to: master: a1e582b33c42bcc8a708777afb975e7dc571ee3d ipa-4-3: 2efa60637111e40a9ac9459d507d9f55a2ae301a -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
Re: [Freeipa-devel] [PATCH 0084-0086] CI: Add double circle topology
On 18.02.2016 10:14, David Kupka wrote: On 12/02/16 16:52, Martin Basti wrote: On 12.02.2016 13:03, Milan Kubík wrote: On 02/12/2016 10:59 AM, David Kupka wrote: Sending one more topology test. This one creates a M groups consisting N (N>=2) servers. First two servers in each group are used to connect with nearest four groups and also with the other servers inside the group (when N>2). Servers inside the group (not connecting to other groups) are connected with each other. The patch set needs freeipa-dkupka-8{1,2,3} applied. ACK I cannot apply patches, please rebase [mbasti@dhcp129-96 freeipa-devel]$ git checkout master Switched to branch 'master' Your branch is up-to-date with 'origin/master'. [mbasti@dhcp129-96 freeipa-devel]$ git am freeipa-dkupka-008* -3 Applying: CI: Add '2-connected' topology generator. Applying: CI: Add simple replication test in 2-connected topology. Applying: CI: Add test for 2-connected topology generator. Applying: CI: Add double circle topology. Applying: CI: Add replication test utilizing double-circle topology. Applying: CI: Add test for double-circle topology generator. error: invalid object 100644 e12d141391840cc7f9150a178875393a96dd469b for 'ipatests/test_integration/test_topologies.py' fatal: git-write-tree: error building trees Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0006 CI: Add test for double-circle topology generator. The copy of the patch that failed is found in: /home/mbasti/work/freeipa-devel/.git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". Martin^2 Git fails to apply patches because wrong version of freeipa-dkupka-008{1,2,3} was pushed. Attached patches should fix it. Sorry my bad. ACK Pushed to: ipa-4-3: ffe3731ae7813fcc3246a83e37d62fc2754bb4ca master: acdabba6ec0f68841f02c1e6ad65232de81bb505 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
Re: [Freeipa-devel] [PATCH 0084-0086] CI: Add double circle topology
On 12/02/16 16:52, Martin Basti wrote: On 12.02.2016 13:03, Milan Kubík wrote: On 02/12/2016 10:59 AM, David Kupka wrote: Sending one more topology test. This one creates a M groups consisting N (N>=2) servers. First two servers in each group are used to connect with nearest four groups and also with the other servers inside the group (when N>2). Servers inside the group (not connecting to other groups) are connected with each other. The patch set needs freeipa-dkupka-8{1,2,3} applied. ACK I cannot apply patches, please rebase [mbasti@dhcp129-96 freeipa-devel]$ git checkout master Switched to branch 'master' Your branch is up-to-date with 'origin/master'. [mbasti@dhcp129-96 freeipa-devel]$ git am freeipa-dkupka-008* -3 Applying: CI: Add '2-connected' topology generator. Applying: CI: Add simple replication test in 2-connected topology. Applying: CI: Add test for 2-connected topology generator. Applying: CI: Add double circle topology. Applying: CI: Add replication test utilizing double-circle topology. Applying: CI: Add test for double-circle topology generator. error: invalid object 100644 e12d141391840cc7f9150a178875393a96dd469b for 'ipatests/test_integration/test_topologies.py' fatal: git-write-tree: error building trees Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0006 CI: Add test for double-circle topology generator. The copy of the patch that failed is found in: /home/mbasti/work/freeipa-devel/.git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". Martin^2 Git fails to apply patches because wrong version of freeipa-dkupka-008{1,2,3} was pushed. Attached patches should fix it. -- David Kupka From 676701253f034a335f603a917e24926e2bb41992 Mon Sep 17 00:00:00 2001 From: David Kupka Date: Thu, 18 Feb 2016 09:52:55 +0100 Subject: [PATCH 1/2] CI: Fix pep8 errors in 2-connected topology generator --- ipatests/test_integration/tasks.py | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/ipatests/test_integration/tasks.py b/ipatests/test_integration/tasks.py index d37b616bd6efe437a1a979cc7a9ad8c7ea803773..77cba89825574f5354017bf184b106e94eb75c59 100644 --- a/ipatests/test_integration/tasks.py +++ b/ipatests/test_integration/tasks.py @@ -857,6 +857,7 @@ def tree2_topo(master, replicas): yield master, replica master = replica + @_topo('2-connected') def two_connected_topo(master, replicas): r"""No replica has more than 4 agreements and at least two @@ -892,24 +893,24 @@ def two_connected_topo(master, replicas): v2 = pool.pop(0) yield v0, v2 -grow.append((v0,v2)) +grow.append((v0, v2)) v3 = pool.pop(0) yield v2, v3 yield v1, v3 -grow.append((v1,v3)) +grow.append((v1, v3)) -for (r,s) in grow: +for (r, s) in grow: t = pool.pop(0) -for (u,v) in [(r,t), (s,t)]: +for (u, v) in [(r, t), (s, t)]: yield u, v w = pool.pop(0) yield u, w x = pool.pop(0) yield v, x yield w, x -grow.append((w,x)) +grow.append((w, x)) except IndexError: return -- 2.5.0 From a5e900de20e63896bbca3a3fb53180d8207859eb Mon Sep 17 00:00:00 2001 From: David Kupka Date: Thu, 18 Feb 2016 09:55:53 +0100 Subject: [PATCH 2/2] CI: add empty topology test for 2-connected topology generator --- ipatests/test_integration/test_topologies.py | 1 + 1 file changed, 1 insertion(+) diff --git a/ipatests/test_integration/test_topologies.py b/ipatests/test_integration/test_topologies.py index f5332adbef12e8c18471592d4fd5c89097e2d4ed..e12d141391840cc7f9150a178875393a96dd469b 100644 --- a/ipatests/test_integration/test_topologies.py +++ b/ipatests/test_integration/test_topologies.py @@ -115,3 +115,4 @@ def test_topology_two_connected(): (4, 8), (7, 8), ] +assert list(topo('M', [])) == [] -- 2.5.0 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
Re: [Freeipa-devel] [PATCH 0084-0086] CI: Add double circle topology
On 12.02.2016 13:03, Milan Kubík wrote: On 02/12/2016 10:59 AM, David Kupka wrote: Sending one more topology test. This one creates a M groups consisting N (N>=2) servers. First two servers in each group are used to connect with nearest four groups and also with the other servers inside the group (when N>2). Servers inside the group (not connecting to other groups) are connected with each other. The patch set needs freeipa-dkupka-8{1,2,3} applied. ACK I cannot apply patches, please rebase [mbasti@dhcp129-96 freeipa-devel]$ git checkout master Switched to branch 'master' Your branch is up-to-date with 'origin/master'. [mbasti@dhcp129-96 freeipa-devel]$ git am freeipa-dkupka-008* -3 Applying: CI: Add '2-connected' topology generator. Applying: CI: Add simple replication test in 2-connected topology. Applying: CI: Add test for 2-connected topology generator. Applying: CI: Add double circle topology. Applying: CI: Add replication test utilizing double-circle topology. Applying: CI: Add test for double-circle topology generator. error: invalid object 100644 e12d141391840cc7f9150a178875393a96dd469b for 'ipatests/test_integration/test_topologies.py' fatal: git-write-tree: error building trees Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0006 CI: Add test for double-circle topology generator. The copy of the patch that failed is found in: /home/mbasti/work/freeipa-devel/.git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". Martin^2 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
Re: [Freeipa-devel] [PATCH 0084-0086] CI: Add double circle topology
On 02/12/2016 10:59 AM, David Kupka wrote: Sending one more topology test. This one creates a M groups consisting N (N>=2) servers. First two servers in each group are used to connect with nearest four groups and also with the other servers inside the group (when N>2). Servers inside the group (not connecting to other groups) are connected with each other. The patch set needs freeipa-dkupka-8{1,2,3} applied. ACK -- Milan Kubik -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code