Re: [Freeipa-devel] [PATCH 0117] ipa-client-install: create a temporary directory for ccache files

2015-12-15 Thread Martin Kosek
On 12/15/2015 08:03 AM, Martin Babinsky wrote:
> On 12/15/2015 07:19 AM, Jan Cholasta wrote:
>> On 14.12.2015 18:51, Tomas Babej wrote:
>>>
>>>
>>> On 12/14/2015 05:31 PM, Martin Babinsky wrote:
 fixes https://fedorahosted.org/freeipa/ticket/5528
>>>
>>> Works as expected, code-wise looks good.
>>>
>>> Thanks for looking into this, ACK!
>>>
>>> Pushed to master: 5886f87f974fa508047a21350c2e6e75a3001da6
>>
>> It would probably be better if ipa-client-install used
>> ipautil.private_ccache(), but I guess we can fix that later, once we
>> start digging into ipa-client-install componentization / rectofaring.
>>
> Yes since that would probably require heroic amounts of spaghetti untangling 
> to
> get it right. Anyway we have any milestone for ipa-client refactoring? Is it a
> part of 4.4 installer redesign effort?

Client refactoring is not currently planned for 4.4. There are plans for "Thin
Client", but not ipa-client-install refactoring. This would fall in 4.5 or even
later, I think.

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code


Re: [Freeipa-devel] [PATCH 0117] ipa-client-install: create a temporary directory for ccache files

2015-12-15 Thread Martin Kosek
On 12/14/2015 06:51 PM, Tomas Babej wrote:
> 
> 
> On 12/14/2015 05:31 PM, Martin Babinsky wrote:
>> fixes https://fedorahosted.org/freeipa/ticket/5528
> 
> Works as expected, code-wise looks good.
> 
> Thanks for looking into this, ACK!
> 
> Pushed to master: 5886f87f974fa508047a21350c2e6e75a3001da6
> 

Looks like something that should also land in ipa-4-3, no?

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code


Re: [Freeipa-devel] [PATCH 0117] ipa-client-install: create a temporary directory for ccache files

2015-12-15 Thread Martin Kosek
On 12/15/2015 12:39 PM, Martin Kosek wrote:
> On 12/14/2015 06:51 PM, Tomas Babej wrote:
>>
>>
>> On 12/14/2015 05:31 PM, Martin Babinsky wrote:
>>> fixes https://fedorahosted.org/freeipa/ticket/5528
>>
>> Works as expected, code-wise looks good.
>>
>> Thanks for looking into this, ACK!
>>
>> Pushed to master: 5886f87f974fa508047a21350c2e6e75a3001da6
>>
> 
> Looks like something that should also land in ipa-4-3, no?
> 

Ah, the actual push was yesterday before the branch - please disregard my
message :-)

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code


Re: [Freeipa-devel] [PATCH 0117] ipa-client-install: create a temporary directory for ccache files

2015-12-15 Thread Jan Cholasta

On 15.12.2015 12:41, Martin Kosek wrote:

On 12/15/2015 08:03 AM, Martin Babinsky wrote:

On 12/15/2015 07:19 AM, Jan Cholasta wrote:

On 14.12.2015 18:51, Tomas Babej wrote:



On 12/14/2015 05:31 PM, Martin Babinsky wrote:

fixes https://fedorahosted.org/freeipa/ticket/5528


Works as expected, code-wise looks good.

Thanks for looking into this, ACK!

Pushed to master: 5886f87f974fa508047a21350c2e6e75a3001da6


It would probably be better if ipa-client-install used
ipautil.private_ccache(), but I guess we can fix that later, once we
start digging into ipa-client-install componentization / rectofaring.


Yes since that would probably require heroic amounts of spaghetti untangling to
get it right. Anyway we have any milestone for ipa-client refactoring? Is it a
part of 4.4 installer redesign effort?


Client refactoring is not currently planned for 4.4. There are plans for "Thin
Client", but not ipa-client-install refactoring. This would fall in 4.5 or even
later, I think.


For further server/replica installer improvements, it's necessary to at 
least create a module from ipa-client-install. So, unless you want to 
freeze server installers in their current (WIP) state, we have to touch 
ipa-client-install as well.


--
Jan Cholasta

--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code


Re: [Freeipa-devel] [PATCH 0117] ipa-client-install: create a temporary directory for ccache files

2015-12-14 Thread Jan Cholasta

On 14.12.2015 18:51, Tomas Babej wrote:



On 12/14/2015 05:31 PM, Martin Babinsky wrote:

fixes https://fedorahosted.org/freeipa/ticket/5528


Works as expected, code-wise looks good.

Thanks for looking into this, ACK!

Pushed to master: 5886f87f974fa508047a21350c2e6e75a3001da6


It would probably be better if ipa-client-install used 
ipautil.private_ccache(), but I guess we can fix that later, once we 
start digging into ipa-client-install componentization / rectofaring.


--
Jan Cholasta

--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code


Re: [Freeipa-devel] [PATCH 0117] ipa-client-install: create a temporary directory for ccache files

2015-12-14 Thread Martin Babinsky

On 12/15/2015 07:19 AM, Jan Cholasta wrote:

On 14.12.2015 18:51, Tomas Babej wrote:



On 12/14/2015 05:31 PM, Martin Babinsky wrote:

fixes https://fedorahosted.org/freeipa/ticket/5528


Works as expected, code-wise looks good.

Thanks for looking into this, ACK!

Pushed to master: 5886f87f974fa508047a21350c2e6e75a3001da6


It would probably be better if ipa-client-install used
ipautil.private_ccache(), but I guess we can fix that later, once we
start digging into ipa-client-install componentization / rectofaring.

Yes since that would probably require heroic amounts of spaghetti 
untangling to get it right. Anyway we have any milestone for ipa-client 
refactoring? Is it a part of 4.4 installer redesign effort?


--
Martin^3 Babinsky

--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code


Re: [Freeipa-devel] [PATCH 0117] ipa-client-install: create a temporary directory for ccache files

2015-12-14 Thread Tomas Babej


On 12/14/2015 05:31 PM, Martin Babinsky wrote:
> fixes https://fedorahosted.org/freeipa/ticket/5528

Works as expected, code-wise looks good.

Thanks for looking into this, ACK!

Pushed to master: 5886f87f974fa508047a21350c2e6e75a3001da6

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code