Re: [Freeipa-devel] [PATCH 0140] [PATCH 140/140] ipalib: Use DateTime parameter class for OTP token

2014-07-04 Thread Martin Kosek 
On 07/03/2014 06:02 PM, Jan Cholasta wrote:
 On 3.7.2014 17:03, Petr Vobornik wrote:
 On 2.6.2014 18:35, Petr Vobornik wrote:
 On 14.1.2014 15:20, Petr Viktorin wrote:
 On 01/14/2014 09:33 AM, Jan Cholasta wrote:
 On 9.1.2014 16:32, Tomas Babej wrote:
 Hi,

 For ipatokennotbefore and ipatokennotafter attributes use DateTime
 parameter class instead of Str, since these are represented as
 LDAP Generalized Time in LDAP.

 Tomas


 ACK.

 This apparently depends on tbabej-0137, so let's not push it yet.


 I've rebased the patch and wanted to push it but I found out, that in
 patch 138 - expose krbPrincipalExpiration we removed the (UTC) from
 labels [1].

 We should do the same here.

 [1] http://www.redhat.com/archives/freeipa-devel/2014-April/msg00442.html


 Since Tomas is on vacation, I've rebased it again and addressed ^^.

 If we want this change, it should be pushed before GA since it changes API.

 Web UI part is pvoborni-548-1
 
 Thanks, ACK again.
 

Pushed to master: 9bf29c270d703eeae5c0ccfe6b99cd7d1a8e8c86

Martin

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH 0140] [PATCH 140/140] ipalib: Use DateTime parameter class for OTP token

2014-07-03 Thread Petr Vobornik 

On 2.6.2014 18:35, Petr Vobornik wrote:

On 14.1.2014 15:20, Petr Viktorin wrote:

On 01/14/2014 09:33 AM, Jan Cholasta wrote:

On 9.1.2014 16:32, Tomas Babej wrote:

Hi,

For ipatokennotbefore and ipatokennotafter attributes use DateTime
parameter class instead of Str, since these are represented as
LDAP Generalized Time in LDAP.

Tomas



ACK.


This apparently depends on tbabej-0137, so let's not push it yet.



I've rebased the patch and wanted to push it but I found out, that in
patch 138 - expose krbPrincipalExpiration we removed the (UTC) from
labels [1].

We should do the same here.

[1] http://www.redhat.com/archives/freeipa-devel/2014-April/msg00442.html



Since Tomas is on vacation, I've rebased it again and addressed ^^.

If we want this change, it should be pushed before GA since it changes API.

Web UI part is pvoborni-548-1
--
Petr Vobornik
From ba3b94c3dc43ac29e608e1b45991040e37751f6b Mon Sep 17 00:00:00 2001
From: Tomas Babej tba...@redhat.com
Date: Thu, 9 Jan 2014 11:29:39 +0100
Subject: [PATCH] ipalib: Use DateTime parameter class for OTP token timestamp
 attributes

For ipatokennotbefore and ipatokennotafter attributes use DateTime
parameter class instead of Str, since these are represented as
LDAP Generalized Time in LDAP.
---
 API.txt| 16 
 VERSION|  4 ++--
 ipalib/plugins/otptoken.py |  6 +++---
 3 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/API.txt b/API.txt
index c0f551706e4f5be4ff2e3f2ec00f9ad4dcf1ed03..0181f7d6cb7dd2fb6ba36ed48ad49a16088f6c2f 100644
--- a/API.txt
+++ b/API.txt
@@ -2303,8 +2303,8 @@ option: Str('description', attribute=True, cli_name='desc', multivalue=False, re
 option: Bool('ipatokendisabled', attribute=True, cli_name='disabled', multivalue=False, required=False)
 option: Int('ipatokenhotpcounter', attribute=True, autofill=True, cli_name='counter', default=0, minvalue=0, multivalue=False, required=False)
 option: Str('ipatokenmodel', attribute=True, autofill=True, cli_name='model', multivalue=False, required=False)
-option: Str('ipatokennotafter', attribute=True, cli_name='not_after', multivalue=False, required=False)
-option: Str('ipatokennotbefore', attribute=True, cli_name='not_before', multivalue=False, required=False)
+option: DateTime('ipatokennotafter', attribute=True, cli_name='not_after', multivalue=False, required=False)
+option: DateTime('ipatokennotbefore', attribute=True, cli_name='not_before', multivalue=False, required=False)
 option: StrEnum('ipatokenotpalgorithm', attribute=True, autofill=True, cli_name='algo', default=u'sha1', multivalue=False, required=False, values=(u'sha1', u'sha256', u'sha384', u'sha512'))
 option: IntEnum('ipatokenotpdigits', attribute=True, autofill=True, cli_name='digits', default=6, multivalue=False, required=False, values=(6, 8))
 option: OTPTokenKey('ipatokenotpkey', attribute=True, autofill=True, cli_name='key', multivalue=False, required=False)
@@ -2338,8 +2338,8 @@ args: 1,8,1
 arg: Str('ipatokenuniqueid?', cli_name='id', primary_key=True)
 option: Str('description?', cli_name='desc')
 option: Bool('ipatokendisabled?', cli_name='disabled')
-option: Str('ipatokennotafter?', cli_name='not_after')
-option: Str('ipatokennotbefore?', cli_name='not_before')
+option: DateTime('ipatokennotafter?', cli_name='not_after')
+option: DateTime('ipatokennotbefore?', cli_name='not_before')
 option: IntEnum('ipatokenotpdigits?', autofill=True, cli_name='digits', default=6, values=(6, 8))
 option: Str('ipatokenowner?', cli_name='owner')
 option: IntEnum('slot?', cli_name='slot', values=(1, 2))
@@ -2361,8 +2361,8 @@ option: Str('description', attribute=True, autofill=False, cli_name='desc', mult
 option: Bool('ipatokendisabled', attribute=True, autofill=False, cli_name='disabled', multivalue=False, query=True, required=False)
 option: Int('ipatokenhotpcounter', attribute=True, autofill=False, cli_name='counter', default=0, minvalue=0, multivalue=False, query=True, required=False)
 option: Str('ipatokenmodel', attribute=True, autofill=False, cli_name='model', multivalue=False, query=True, required=False)
-option: Str('ipatokennotafter', attribute=True, autofill=False, cli_name='not_after', multivalue=False, query=True, required=False)
-option: Str('ipatokennotbefore', attribute=True, autofill=False, cli_name='not_before', multivalue=False, query=True, required=False)
+option: DateTime('ipatokennotafter', attribute=True, autofill=False, cli_name='not_after', multivalue=False, query=True, required=False)
+option: DateTime('ipatokennotbefore', attribute=True, autofill=False, cli_name='not_before', multivalue=False, query=True, required=False)
 option: StrEnum('ipatokenotpalgorithm', attribute=True, autofill=False, cli_name='algo', default=u'sha1', multivalue=False, query=True, required=False, values=(u'sha1', u'sha256', u'sha384', u'sha512'))
 option: IntEnum('ipatokenotpdigits', attribute=True, autofill=False, cli_name='digits', default=6, multivalue=False,

Re: [Freeipa-devel] [PATCH 0140] [PATCH 140/140] ipalib: Use DateTime parameter class for OTP token

2014-07-03 Thread Jan Cholasta 

On 3.7.2014 17:03, Petr Vobornik wrote:

On 2.6.2014 18:35, Petr Vobornik wrote:

On 14.1.2014 15:20, Petr Viktorin wrote:

On 01/14/2014 09:33 AM, Jan Cholasta wrote:

On 9.1.2014 16:32, Tomas Babej wrote:

Hi,

For ipatokennotbefore and ipatokennotafter attributes use DateTime
parameter class instead of Str, since these are represented as
LDAP Generalized Time in LDAP.

Tomas



ACK.


This apparently depends on tbabej-0137, so let's not push it yet.



I've rebased the patch and wanted to push it but I found out, that in
patch 138 - expose krbPrincipalExpiration we removed the (UTC) from
labels [1].

We should do the same here.

[1] http://www.redhat.com/archives/freeipa-devel/2014-April/msg00442.html



Since Tomas is on vacation, I've rebased it again and addressed ^^.

If we want this change, it should be pushed before GA since it changes API.

Web UI part is pvoborni-548-1


Thanks, ACK again.

--
Jan Cholasta

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH 0140] [PATCH 140/140] ipalib: Use DateTime parameter class for OTP token

2014-06-02 Thread Petr Vobornik 

On 14.1.2014 15:20, Petr Viktorin wrote:

On 01/14/2014 09:33 AM, Jan Cholasta wrote:

On 9.1.2014 16:32, Tomas Babej wrote:

Hi,

For ipatokennotbefore and ipatokennotafter attributes use DateTime
parameter class instead of Str, since these are represented as
LDAP Generalized Time in LDAP.

Tomas



ACK.


This apparently depends on tbabej-0137, so let's not push it yet.



I've rebased the patch and wanted to push it but I found out, that in 
patch 138 - expose krbPrincipalExpiration we removed the (UTC) from 
labels [1].


We should do the same here.

[1] http://www.redhat.com/archives/freeipa-devel/2014-April/msg00442.html
--
Petr Vobornik
From 842fee3911d2fc130444d68bc9974e92a6b9deab Mon Sep 17 00:00:00 2001
From: Tomas Babej tba...@redhat.com
Date: Thu, 9 Jan 2014 11:29:39 +0100
Subject: [PATCH] ipalib: Use DateTime parameter class for OTP token timestamp
 attributes

For ipatokennotbefore and ipatokennotafter attributes use DateTime
parameter class instead of Str, since these are represented as
LDAP Generalized Time in LDAP.
---
 API.txt| 12 ++--
 VERSION|  4 ++--
 ipalib/plugins/otptoken.py | 10 +-
 3 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/API.txt b/API.txt
index caee61a22fcbf1395fcec55e9d5f5b23c4269523..b122b277245e44eeb3ca367acf748da50b5391c1 100644
--- a/API.txt
+++ b/API.txt
@@ -2234,8 +2234,8 @@ option: Str('description', attribute=True, cli_name='desc', multivalue=False, re
 option: Bool('ipatokendisabled', attribute=True, cli_name='disabled', multivalue=False, required=False)
 option: Int('ipatokenhotpcounter', attribute=True, autofill=True, cli_name='counter', default=0, minvalue=0, multivalue=False, required=False)
 option: Str('ipatokenmodel', attribute=True, autofill=True, cli_name='model', multivalue=False, required=False)
-option: Str('ipatokennotafter', attribute=True, cli_name='not_after', multivalue=False, required=False)
-option: Str('ipatokennotbefore', attribute=True, cli_name='not_before', multivalue=False, required=False)
+option: DateTime('ipatokennotafter', attribute=True, cli_name='not_after', multivalue=False, required=False)
+option: DateTime('ipatokennotbefore', attribute=True, cli_name='not_before', multivalue=False, required=False)
 option: StrEnum('ipatokenotpalgorithm', attribute=True, autofill=True, cli_name='algo', default=u'sha1', multivalue=False, required=False, values=(u'sha1', u'sha256', u'sha384', u'sha512'))
 option: IntEnum('ipatokenotpdigits', attribute=True, autofill=True, cli_name='digits', default=6, multivalue=False, required=False, values=(6, 8))
 option: OTPTokenKey('ipatokenotpkey', attribute=True, autofill=True, cli_name='key', multivalue=False, required=False)
@@ -2268,8 +2268,8 @@ option: Str('description', attribute=True, autofill=False, cli_name='desc', mult
 option: Bool('ipatokendisabled', attribute=True, autofill=False, cli_name='disabled', multivalue=False, query=True, required=False)
 option: Int('ipatokenhotpcounter', attribute=True, autofill=False, cli_name='counter', default=0, minvalue=0, multivalue=False, query=True, required=False)
 option: Str('ipatokenmodel', attribute=True, autofill=False, cli_name='model', multivalue=False, query=True, required=False)
-option: Str('ipatokennotafter', attribute=True, autofill=False, cli_name='not_after', multivalue=False, query=True, required=False)
-option: Str('ipatokennotbefore', attribute=True, autofill=False, cli_name='not_before', multivalue=False, query=True, required=False)
+option: DateTime('ipatokennotafter', attribute=True, autofill=False, cli_name='not_after', multivalue=False, query=True, required=False)
+option: DateTime('ipatokennotbefore', attribute=True, autofill=False, cli_name='not_before', multivalue=False, query=True, required=False)
 option: StrEnum('ipatokenotpalgorithm', attribute=True, autofill=False, cli_name='algo', default=u'sha1', multivalue=False, query=True, required=False, values=(u'sha1', u'sha256', u'sha384', u'sha512'))
 option: IntEnum('ipatokenotpdigits', attribute=True, autofill=False, cli_name='digits', default=6, multivalue=False, query=True, required=False, values=(6, 8))
 option: Str('ipatokenowner', attribute=True, autofill=False, cli_name='owner', multivalue=False, query=True, required=False)
@@ -2297,8 +2297,8 @@ option: Str('delattr*', cli_name='delattr', exclude='webui')
 option: Str('description', attribute=True, autofill=False, cli_name='desc', multivalue=False, required=False)
 option: Bool('ipatokendisabled', attribute=True, autofill=False, cli_name='disabled', multivalue=False, required=False)
 option: Str('ipatokenmodel', attribute=True, autofill=False, cli_name='model', multivalue=False, required=False)
-option: Str('ipatokennotafter', attribute=True, autofill=False, cli_name='not_after', multivalue=False, required=False)
-option: Str('ipatokennotbefore', attribute=True, autofill=False, cli_name='not_before', multivalue=False, required=False)
+option:

Re: [Freeipa-devel] [PATCH 0140] [PATCH 140/140] ipalib: Use DateTime parameter class for OTP token

2014-01-14 Thread Jan Cholasta 

On 9.1.2014 16:32, Tomas Babej wrote:

Hi,

For ipatokennotbefore and ipatokennotafter attributes use DateTime
parameter class instead of Str, since these are represented as
LDAP Generalized Time in LDAP.

Tomas



ACK.

--
Jan Cholasta

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel