Re: [Freeipa-devel] [PATCH 0157] Prohibit deletion of active subdomain range

2014-03-13 Thread Martin Kosek
On 03/13/2014 12:45 PM, Tomas Babej wrote: Hi, Changes the code in the idrange_del method to not only check for the root domains that match the SID in the IDRange, but for the SIDs of subdomains of trusts as well. https://fedorahosted.org/freeipa/ticket/4247 This is a very complicated

Re: [Freeipa-devel] [PATCH 0157] Prohibit deletion of active subdomain range

2014-03-13 Thread Alexander Bokovoy
On Thu, 13 Mar 2014, Tomas Babej wrote: Hi, Changes the code in the idrange_del method to not only check for the root domains that match the SID in the IDRange, but for the SIDs of subdomains of trusts as well. https://fedorahosted.org/freeipa/ticket/4247 -- Tomas Babej Associate Software

Re: [Freeipa-devel] [PATCH 0157] Prohibit deletion of active subdomain range

2014-03-13 Thread Alexander Bokovoy
On Thu, 13 Mar 2014, Martin Kosek wrote: On 03/13/2014 12:45 PM, Tomas Babej wrote: Hi, Changes the code in the idrange_del method to not only check for the root domains that match the SID in the IDRange, but for the SIDs of subdomains of trusts as well.

Re: [Freeipa-devel] [PATCH 0157] Prohibit deletion of active subdomain range

2014-03-13 Thread Martin Kosek
On 03/13/2014 12:59 PM, Alexander Bokovoy wrote: On Thu, 13 Mar 2014, Tomas Babej wrote: Hi, Changes the code in the idrange_del method to not only check for the root domains that match the SID in the IDRange, but for the SIDs of subdomains of trusts as well.

Re: [Freeipa-devel] [PATCH 0157] Prohibit deletion of active subdomain range

2014-03-13 Thread Martin Kosek
On 03/13/2014 01:01 PM, Alexander Bokovoy wrote: On Thu, 13 Mar 2014, Martin Kosek wrote: On 03/13/2014 12:45 PM, Tomas Babej wrote: Hi, Changes the code in the idrange_del method to not only check for the root domains that match the SID in the IDRange, but for the SIDs of subdomains of

Re: [Freeipa-devel] [PATCH 0157] Prohibit deletion of active subdomain range

2014-03-13 Thread Alexander Bokovoy
On Thu, 13 Mar 2014, Martin Kosek wrote: On 03/13/2014 01:01 PM, Alexander Bokovoy wrote: On Thu, 13 Mar 2014, Martin Kosek wrote: On 03/13/2014 12:45 PM, Tomas Babej wrote: Hi, Changes the code in the idrange_del method to not only check for the root domains that match the SID in the

Re: [Freeipa-devel] [PATCH 0157] Prohibit deletion of active subdomain range

2014-03-13 Thread Martin Kosek
On 03/13/2014 01:10 PM, Alexander Bokovoy wrote: On Thu, 13 Mar 2014, Martin Kosek wrote: On 03/13/2014 01:01 PM, Alexander Bokovoy wrote: On Thu, 13 Mar 2014, Martin Kosek wrote: On 03/13/2014 12:45 PM, Tomas Babej wrote: Hi, Changes the code in the idrange_del method to not only check for

Re: [Freeipa-devel] [PATCH 0157] Prohibit deletion of active subdomain range

2014-03-13 Thread Petr Spacek
On 13.3.2014 13:20, Martin Kosek wrote: On 03/13/2014 01:10 PM, Alexander Bokovoy wrote: On Thu, 13 Mar 2014, Martin Kosek wrote: On 03/13/2014 01:01 PM, Alexander Bokovoy wrote: On Thu, 13 Mar 2014, Martin Kosek wrote: On 03/13/2014 12:45 PM, Tomas Babej wrote: Hi, Changes the code in the

Re: [Freeipa-devel] [PATCH 0157] Prohibit deletion of active subdomain range

2014-03-13 Thread Alexander Bokovoy
On Thu, 13 Mar 2014, Petr Spacek wrote: On 13.3.2014 13:20, Martin Kosek wrote: On 03/13/2014 01:10 PM, Alexander Bokovoy wrote: On Thu, 13 Mar 2014, Martin Kosek wrote: On 03/13/2014 01:01 PM, Alexander Bokovoy wrote: On Thu, 13 Mar 2014, Martin Kosek wrote: On 03/13/2014 12:45 PM, Tomas

Re: [Freeipa-devel] [PATCH 0157] Prohibit deletion of active subdomain range

2014-03-13 Thread Martin Kosek
On 03/13/2014 01:33 PM, Alexander Bokovoy wrote: On Thu, 13 Mar 2014, Petr Spacek wrote: On 13.3.2014 13:20, Martin Kosek wrote: On 03/13/2014 01:10 PM, Alexander Bokovoy wrote: On Thu, 13 Mar 2014, Martin Kosek wrote: On 03/13/2014 01:01 PM, Alexander Bokovoy wrote: On Thu, 13 Mar 2014,

Re: [Freeipa-devel] [PATCH 0157] Prohibit deletion of active subdomain range

2014-03-13 Thread Martin Kosek
On 03/13/2014 01:36 PM, Martin Kosek wrote: On 03/13/2014 01:33 PM, Alexander Bokovoy wrote: On Thu, 13 Mar 2014, Petr Spacek wrote: On 13.3.2014 13:20, Martin Kosek wrote: On 03/13/2014 01:10 PM, Alexander Bokovoy wrote: On Thu, 13 Mar 2014, Martin Kosek wrote: On 03/13/2014 01:01 PM,

Re: [Freeipa-devel] [PATCH 0157] Prohibit deletion of active subdomain range

2014-03-13 Thread Alexander Bokovoy
On Thu, 13 Mar 2014, Martin Kosek wrote: On 03/13/2014 01:36 PM, Martin Kosek wrote: On 03/13/2014 01:33 PM, Alexander Bokovoy wrote: On Thu, 13 Mar 2014, Petr Spacek wrote: On 13.3.2014 13:20, Martin Kosek wrote: On 03/13/2014 01:10 PM, Alexander Bokovoy wrote: On Thu, 13 Mar 2014, Martin

Re: [Freeipa-devel] [PATCH 0157] Prohibit deletion of active subdomain range

2014-03-13 Thread Tomas Babej
On 03/13/2014 01:47 PM, Alexander Bokovoy wrote: On Thu, 13 Mar 2014, Martin Kosek wrote: On 03/13/2014 01:36 PM, Martin Kosek wrote: On 03/13/2014 01:33 PM, Alexander Bokovoy wrote: On Thu, 13 Mar 2014, Petr Spacek wrote: On 13.3.2014 13:20, Martin Kosek wrote: On 03/13/2014 01:10 PM,

Re: [Freeipa-devel] [PATCH 0157] Prohibit deletion of active subdomain range

2014-03-13 Thread Tomas Babej
On 03/13/2014 04:28 PM, Tomas Babej wrote: On 03/13/2014 01:47 PM, Alexander Bokovoy wrote: On Thu, 13 Mar 2014, Martin Kosek wrote: On 03/13/2014 01:36 PM, Martin Kosek wrote: On 03/13/2014 01:33 PM, Alexander Bokovoy wrote: On Thu, 13 Mar 2014, Petr Spacek wrote: On 13.3.2014 13:20,

Re: [Freeipa-devel] [PATCH 0157] Prohibit deletion of active subdomain range

2014-03-13 Thread Alexander Bokovoy
On Thu, 13 Mar 2014, Tomas Babej wrote: Tomas, could you please change the code correspondingly? Sure. Here is the updated patch. Slightly improved patch with better control flow. Thanks for the reviews. -- Tomas Babej Associate Software Engeneer | Red Hat | Identity Management RHCE | Brno

Re: [Freeipa-devel] [PATCH 0157] Prohibit deletion of active subdomain range

2014-03-13 Thread Petr Viktorin
On 03/13/2014 05:11 PM, Alexander Bokovoy wrote: On Thu, 13 Mar 2014, Tomas Babej wrote: Tomas, could you please change the code correspondingly? Sure. Here is the updated patch. Slightly improved patch with better control flow. Thanks for the reviews. -- Tomas Babej Associate Software