Re: [Freeipa-devel] [PATCH 016, 024, 025] First part of the replica promotion tests + testplan

2016-03-23 Thread Martin Basti
On 22.03.2016 16:23, Oleg Fayans wrote: Hi Martin, As per discussion, reverted 0025 patch and added try-catch in prepare_host method to make replica promotion tests pass On 03/22/2016 03:03 PM, Martin Basti wrote: On 22.03.2016 14:30, Oleg Fayans wrote: On 03/22/2016 02:06 PM, Martin

Re: [Freeipa-devel] [PATCH 016, 024, 025] First part of the replica promotion tests + testplan

2016-03-22 Thread Oleg Fayans
Hi Martin, As per discussion, reverted 0025 patch and added try-catch in prepare_host method to make replica promotion tests pass On 03/22/2016 03:03 PM, Martin Basti wrote: > > > On 22.03.2016 14:30, Oleg Fayans wrote: >> >> On 03/22/2016 02:06 PM, Martin Basti wrote: >>> >>> On 21.03.2016

Re: [Freeipa-devel] [PATCH 016, 024, 025] First part of the replica promotion tests + testplan

2016-03-22 Thread Martin Basti
On 22.03.2016 14:30, Oleg Fayans wrote: On 03/22/2016 02:06 PM, Martin Basti wrote: On 21.03.2016 15:54, Oleg Fayans wrote: Hi Lukas, Martin, Looks I've implemented the approach proposed by Martin. The issue seems to have gone (see the external_ca_out for external_ca test output). Would

Re: [Freeipa-devel] [PATCH 016, 024, 025] First part of the replica promotion tests + testplan

2016-03-22 Thread Oleg Fayans
On 03/22/2016 02:06 PM, Martin Basti wrote: > > > On 21.03.2016 15:54, Oleg Fayans wrote: >> Hi Lukas, Martin, >> >> Looks I've implemented the approach proposed by Martin. The issue seems >> to have gone (see the external_ca_out for external_ca test output). >> Would like you to take a look

Re: [Freeipa-devel] [PATCH 016, 024, 025] First part of the replica promotion tests + testplan

2016-03-22 Thread Martin Basti
On 21.03.2016 15:54, Oleg Fayans wrote: Hi Lukas, Martin, Looks I've implemented the approach proposed by Martin. The issue seems to have gone (see the external_ca_out for external_ca test output). Would like you to take a look and tell me what'd you think. On 03/17/2016 08:37 PM, Lukas

Re: [Freeipa-devel] [PATCH 016, 024, 025] First part of the replica promotion tests + testplan

2016-03-21 Thread Oleg Fayans
Hi Lukas, Martin, Looks I've implemented the approach proposed by Martin. The issue seems to have gone (see the external_ca_out for external_ca test output). Would like you to take a look and tell me what'd you think. On 03/17/2016 08:37 PM, Lukas Slebodnik wrote: > On (17/03/16 16:00), Oleg

Re: [Freeipa-devel] [PATCH 016, 024, 025] First part of the replica promotion tests + testplan

2016-03-19 Thread Martin Basti
On 17.03.2016 20:37, Lukas Slebodnik wrote: On (17/03/16 16:00), Oleg Fayans wrote: Hi Lukas, On 03/17/2016 11:28 AM, Lukas Slebodnik wrote: On (10/03/16 23:09), Oleg Fayans wrote: Hi Martin, On 03/08/2016 08:18 PM, Martin Basti wrote: On 08.03.2016 18:24, Martin Basti wrote: On

Re: [Freeipa-devel] [PATCH 016, 024, 025] First part of the replica promotion tests + testplan

2016-03-19 Thread Oleg Fayans
Hi Lukas, On 03/17/2016 11:28 AM, Lukas Slebodnik wrote: > On (10/03/16 23:09), Oleg Fayans wrote: >> Hi Martin, >> >> >> >> On 03/08/2016 08:18 PM, Martin Basti wrote: >>> >>> >>> On 08.03.2016 18:24, Martin Basti wrote: On 08.03.2016 12:38, Oleg Fayans wrote: > The patches

Re: [Freeipa-devel] [PATCH 016, 024, 025] First part of the replica promotion tests + testplan

2016-03-18 Thread Lukas Slebodnik
On (17/03/16 16:00), Oleg Fayans wrote: >Hi Lukas, > >On 03/17/2016 11:28 AM, Lukas Slebodnik wrote: >> On (10/03/16 23:09), Oleg Fayans wrote: >>> Hi Martin, >>> >>> >>> >>> On 03/08/2016 08:18 PM, Martin Basti wrote: On 08.03.2016 18:24, Martin Basti wrote: > > > On

Re: [Freeipa-devel] [PATCH 016, 024, 025] First part of the replica promotion tests + testplan

2016-03-18 Thread Lukas Slebodnik
On (10/03/16 23:09), Oleg Fayans wrote: >Hi Martin, > > > >On 03/08/2016 08:18 PM, Martin Basti wrote: >> >> >> On 08.03.2016 18:24, Martin Basti wrote: >>> >>> >>> On 08.03.2016 12:38, Oleg Fayans wrote: The patches were rebased against the current master On 03/04/2016 05:33 PM,

Re: [Freeipa-devel] [PATCH 016, 024, 025] First part of the replica promotion tests + testplan

2016-03-11 Thread Martin Basti
On 10.03.2016 23:09, Oleg Fayans wrote: Hi Martin, On 03/08/2016 08:18 PM, Martin Basti wrote: On 08.03.2016 18:24, Martin Basti wrote: On 08.03.2016 12:38, Oleg Fayans wrote: The patches were rebased against the current master On 03/04/2016 05:33 PM, Martin Basti wrote: * old

Re: [Freeipa-devel] [PATCH 016, 024, 025] First part of the replica promotion tests + testplan

2016-03-08 Thread Martin Basti
On 08.03.2016 18:24, Martin Basti wrote: On 08.03.2016 12:38, Oleg Fayans wrote: The patches were rebased against the current master On 03/04/2016 05:33 PM, Martin Basti wrote: * old messages have been removed * 1) this method is unused please remove it def

Re: [Freeipa-devel] [PATCH 016, 024, 025] First part of the replica promotion tests + testplan

2016-03-08 Thread Martin Basti
On 08.03.2016 12:38, Oleg Fayans wrote: The patches were rebased against the current master On 03/04/2016 05:33 PM, Martin Basti wrote: * old messages have been removed * 1) this method is unused please remove it def test_kra_install_master(self): Well, in fact it is used twice: in

Re: [Freeipa-devel] [PATCH 016, 024, 025] First part of the replica promotion tests + testplan

2016-03-08 Thread Oleg Fayans
The patches were rebased against the current master On 03/04/2016 05:33 PM, Martin Basti wrote: > * old messages have been removed * > 1) > this method is unused please remove it > > def test_kra_install_master(self): >> Well, in fact it is used twice: in both domain levels,

Re: [Freeipa-devel] [PATCH 016, 024, 025] First part of the replica promotion tests + testplan

2016-03-04 Thread Martin Basti
* old messages have been removed * 1) this method is unused please remove it def test_kra_install_master(self): Well, in fact it is used twice: in both domain levels, so I'd better keep it: -bash-4.3$ ipa-run-tests test_integration/test_replica_promotion.py --collect-only

Re: [Freeipa-devel] [PATCH 016, 024, 025] First part of the replica promotion tests + testplan

2016-03-04 Thread Oleg Fayans
Hi, Martin. An updated version of the patch is attached. Please see my comments below On 03/04/2016 08:39 AM, Martin Basti wrote: > > > On 04.03.2016 08:37, Martin Basti wrote: >> >> >> On 03.03.2016 18:38, Martin Basti wrote: >>> >>> >>> On 02.03.2016 13:47, Oleg Fayans wrote: Hi Martin,

Re: [Freeipa-devel] [PATCH 016, 024, 025] First part of the replica promotion tests + testplan

2016-03-03 Thread Martin Basti
On 04.03.2016 08:37, Martin Basti wrote: On 03.03.2016 18:38, Martin Basti wrote: On 02.03.2016 13:47, Oleg Fayans wrote: Hi Martin, I've made the requested changes. The full set of necessary patches is attached. On 03/02/2016 10:05 AM, Martin Basti wrote: On 02.03.2016 00:12, Oleg

Re: [Freeipa-devel] [PATCH 016, 024, 025] First part of the replica promotion tests + testplan

2016-03-03 Thread Martin Basti
On 03.03.2016 18:38, Martin Basti wrote: On 02.03.2016 13:47, Oleg Fayans wrote: Hi Martin, I've made the requested changes. The full set of necessary patches is attached. On 03/02/2016 10:05 AM, Martin Basti wrote: On 02.03.2016 00:12, Oleg Fayans wrote: Hi Martin, On 03/01/2016

Re: [Freeipa-devel] [PATCH 016, 024, 025] First part of the replica promotion tests + testplan

2016-03-03 Thread Martin Basti
On 02.03.2016 13:47, Oleg Fayans wrote: Hi Martin, I've made the requested changes. The full set of necessary patches is attached. On 03/02/2016 10:05 AM, Martin Basti wrote: On 02.03.2016 00:12, Oleg Fayans wrote: Hi Martin, On 03/01/2016 07:04 PM, Martin Basti wrote: On 01.03.2016

Re: [Freeipa-devel] [PATCH 016, 024, 025] First part of the replica promotion tests + testplan

2016-03-02 Thread Oleg Fayans
Hi Martin, I've made the requested changes. The full set of necessary patches is attached. On 03/02/2016 10:05 AM, Martin Basti wrote: > > > On 02.03.2016 00:12, Oleg Fayans wrote: >> Hi Martin, >> >> On 03/01/2016 07:04 PM, Martin Basti wrote: >>> >>> On 01.03.2016 14:56, Martin Basti

Re: [Freeipa-devel] [PATCH 016, 024, 025] First part of the replica promotion tests + testplan

2016-03-02 Thread Martin Basti
On 02.03.2016 00:12, Oleg Fayans wrote: Hi Martin, On 03/01/2016 07:04 PM, Martin Basti wrote: On 01.03.2016 14:56, Martin Basti wrote: On 01.03.2016 12:37, Martin Basti wrote: On 01.03.2016 12:32, Martin Basti wrote: On 29.02.2016 13:16, Oleg Fayans wrote: Hi all, Finally the

Re: [Freeipa-devel] [PATCH 016, 024, 025] First part of the replica promotion tests + testplan

2016-03-01 Thread Oleg Fayans
Hi Martin, On 03/01/2016 07:04 PM, Martin Basti wrote: > > > On 01.03.2016 14:56, Martin Basti wrote: >> >> >> >> On 01.03.2016 12:37, Martin Basti wrote: >>> >>> >>> On 01.03.2016 12:32, Martin Basti wrote: On 29.02.2016 13:16, Oleg Fayans wrote: > Hi all, > >

Re: [Freeipa-devel] [PATCH 016, 024, 025] First part of the replica promotion tests + testplan

2016-03-01 Thread Martin Basti
On 01.03.2016 14:56, Martin Basti wrote: On 01.03.2016 12:37, Martin Basti wrote: On 01.03.2016 12:32, Martin Basti wrote: On 29.02.2016 13:16, Oleg Fayans wrote: Hi all, Finally the tests pass. The patch 0024 applies on top of patch 0022 (please, consider reviewing it also).

Re: [Freeipa-devel] [PATCH 016, 024, 025] First part of the replica promotion tests + testplan

2016-03-01 Thread Martin Basti
On 01.03.2016 12:37, Martin Basti wrote: On 01.03.2016 12:32, Martin Basti wrote: On 29.02.2016 13:16, Oleg Fayans wrote: Hi all, Finally the tests pass. The patch 0024 applies on top of patch 0022 (please, consider reviewing it also). Besides, the whole functionality depends on