Re: [Freeipa-devel] [PATCH 018] certprofile-import: improve profile format documentation

2015-07-27 Thread Martin Basti 

On 24/07/15 04:06, Fraser Tweedale wrote:

On Thu, Jul 23, 2015 at 06:25:25PM +0200, Christian Heimes wrote:

The certprofile-import plugin expects a raw Dogtag config file. The XML
format is not supported. --help gives a hint about the correct file format.

https://fedorahosted.org/freeipa/ticket/5089

ACK, but IMO this does not complete 5089.  I will add more
commentary to the plugin documentation in a separate patch.

Thanks,
Fraser

Pushed to:
master: 2596adb312700a6133a4405851af9aec62941cd9
ipa-4-2: b4722beb78cafcb196c10392a48b22022a425e8e


 From 1344425af2886797ec9cef40a325e56a8d1752eb Mon Sep 17 00:00:00 2001
From: Christian Heimes chei...@redhat.com
Date: Thu, 23 Jul 2015 18:22:19 +0200
Subject: [PATCH] certprofile-import: improve profile format documentation

The certprofile-import plugin expects a raw Dogtag config file. The XML
format is not supported. --help gives a hint about the correct file format.

https://fedorahosted.org/freeipa/ticket/5089
---
  ipalib/plugins/certprofile.py | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ipalib/plugins/certprofile.py b/ipalib/plugins/certprofile.py
index 
5550ed942521dbab2e783fba1570520268f9b378..ae75d43d7412d0df7c09a33c16c833995d9a3fe4
 100644
--- a/ipalib/plugins/certprofile.py
+++ b/ipalib/plugins/certprofile.py
@@ -220,7 +220,7 @@ class certprofile_import(LDAPCreate):
  msg_summary = _('Imported profile %(value)s')
  takes_options = (
  File('file',
-label=_('Filename'),
+label=_('Filename of a raw profile. The XML format is not 
supported.'),
  cli_name='file',
  flags=('virtual_attribute',),
  ),
--
2.4.3







--
Martin Basti

--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Re: [Freeipa-devel] [PATCH 018] certprofile-import: improve profile format documentation

2015-07-23 Thread Fraser Tweedale 
On Thu, Jul 23, 2015 at 06:25:25PM +0200, Christian Heimes wrote:
 The certprofile-import plugin expects a raw Dogtag config file. The XML
 format is not supported. --help gives a hint about the correct file format.
 
 https://fedorahosted.org/freeipa/ticket/5089

ACK, but IMO this does not complete 5089.  I will add more
commentary to the plugin documentation in a separate patch.

Thanks,
Fraser

 From 1344425af2886797ec9cef40a325e56a8d1752eb Mon Sep 17 00:00:00 2001
 From: Christian Heimes chei...@redhat.com
 Date: Thu, 23 Jul 2015 18:22:19 +0200
 Subject: [PATCH] certprofile-import: improve profile format documentation
 
 The certprofile-import plugin expects a raw Dogtag config file. The XML
 format is not supported. --help gives a hint about the correct file format.
 
 https://fedorahosted.org/freeipa/ticket/5089
 ---
  ipalib/plugins/certprofile.py | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
 
 diff --git a/ipalib/plugins/certprofile.py b/ipalib/plugins/certprofile.py
 index 
 5550ed942521dbab2e783fba1570520268f9b378..ae75d43d7412d0df7c09a33c16c833995d9a3fe4
  100644
 --- a/ipalib/plugins/certprofile.py
 +++ b/ipalib/plugins/certprofile.py
 @@ -220,7 +220,7 @@ class certprofile_import(LDAPCreate):
  msg_summary = _('Imported profile %(value)s')
  takes_options = (
  File('file',
 -label=_('Filename'),
 +label=_('Filename of a raw profile. The XML format is not 
 supported.'),
  cli_name='file',
  flags=('virtual_attribute',),
  ),
 -- 
 2.4.3
 



-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code