Re: [Freeipa-devel] [PATCH 0308] Server Upgrade: fix traceback caused by cidict

2015-09-03 Thread Petr Viktorin
On 09/03/2015 01:01 PM, Martin Basti wrote:
> https://fedorahosted.org/freeipa/ticket/5283
> 
> Patch attached.

ACK.


This was caused by commit 3bf91ea, specifically the rushed reaction to
Christian's comment:
> Please use sorted(reference) instead of sorted(reference.keys()),
> set(tree) instead of set(tree.keys()) and list(somedict) instead of
> list(somedict.keys()), too. The keys() call is unnecessary and frowned upon.

Turns out python-ldap's cidict is not a propper Mapping, so the keys()
call *is* necessary.
Sorry for missing that.


-- 
Petr Viktorin

-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code


Re: [Freeipa-devel] [PATCH 0308] Server Upgrade: fix traceback caused by cidict

2015-09-03 Thread Martin Basti



On 09/03/2015 01:42 PM, Petr Viktorin wrote:

On 09/03/2015 01:01 PM, Martin Basti wrote:

https://fedorahosted.org/freeipa/ticket/5283

Patch attached.

ACK.


This was caused by commit 3bf91ea, specifically the rushed reaction to
Christian's comment:

Please use sorted(reference) instead of sorted(reference.keys()),
set(tree) instead of set(tree.keys()) and list(somedict) instead of
list(somedict.keys()), too. The keys() call is unnecessary and frowned upon.

Turns out python-ldap's cidict is not a propper Mapping, so the keys()
call *is* necessary.
Sorry for missing that.



Pushed to master: 0c5e41cc79f75e12094773cdf5a296dd06052763

--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code