Re: [Freeipa-devel] [PATCH 0355-0365] Prevent using replica file with ipa-ca-install and domain

2015-11-24 Thread Petr Vobornik
On 11/24/2015 10:21 AM, Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/5455 Patches attached. A question/proposal which Martin K.raises during triage, adding here so it won't be overlooked: """ Do we want to keep replica file as optional with DL or reject it? Maybe it could

Re: [Freeipa-devel] [PATCH 0355-0365] Prevent using replica file with ipa-ca-install and domain

2015-11-24 Thread Jan Cholasta
On 24.11.2015 10:33, Petr Vobornik wrote: On 11/24/2015 10:21 AM, Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/5455 Patches attached. A question/proposal which Martin K.raises during triage, adding here so it won't be overlooked: """ Do we want to keep replica file as

Re: [Freeipa-devel] [PATCH 0355-0365] Prevent using replica file with ipa-ca-install and domain

2015-11-24 Thread Jan Cholasta
On 24.11.2015 10:21, Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/5455 Patches attached. +def run(self): +self._run() Wouldn't it be better to rename _run() to run() instead? -- Jan Cholasta -- Manage your subscription for the Freeipa-devel mailing list: