Re: [Freeipa-devel] [PATCH 0358] ipa-getkeytab: do not return error if translations cannot be loaded
On 11/25/2015 02:31 PM, Tomas Babej wrote: > > > On 11/24/2015 05:38 PM, Martin Basti wrote: >> >> >> On 24.11.2015 17:33, Jan Cholasta wrote: >>> On 24.11.2015 16:52, Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/5483 Patch attached. >>> >>> Doesn't init_gettext() itself already print to stderr on failure? >>> >> Nope >> > > ACK, works fine. > > Failed to load translations > Keytab successfully retrieved and stored in: test.keytab > Pushed to: master: d43c3becbd406d145426d0409b8fe2a36ee6c63c ipa-4-2: 34dbb42c51ce17a450e41f998e2b3f30682c -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
Re: [Freeipa-devel] [PATCH 0358] ipa-getkeytab: do not return error if translations cannot be loaded
On 11/24/2015 05:38 PM, Martin Basti wrote: > > > On 24.11.2015 17:33, Jan Cholasta wrote: >> On 24.11.2015 16:52, Martin Basti wrote: >>> https://fedorahosted.org/freeipa/ticket/5483 >>> >>> Patch attached. >> >> Doesn't init_gettext() itself already print to stderr on failure? >> > Nope > ACK, works fine. Failed to load translations Keytab successfully retrieved and stored in: test.keytab -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
Re: [Freeipa-devel] [PATCH 0358] ipa-getkeytab: do not return error if translations cannot be loaded
On 24.11.2015 16:52, Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/5483 Patch attached. Doesn't init_gettext() itself already print to stderr on failure? -- Jan Cholasta -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
Re: [Freeipa-devel] [PATCH 0358] ipa-getkeytab: do not return error if translations cannot be loaded
On Tue, 2015-11-24 at 16:52 +0100, Martin Basti wrote: > https://fedorahosted.org/freeipa/ticket/5483 > > Patch attached. > -- > Manage your subscription for the Freeipa-devel mailing list: > https://www.redhat.com/mailman/listinfo/freeipa-devel > Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code LGTM. Simo. -- Simo Sorce * Red Hat, Inc * New York -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
Re: [Freeipa-devel] [PATCH 0358] ipa-getkeytab: do not return error if translations cannot be loaded
On 24.11.2015 17:33, Jan Cholasta wrote: On 24.11.2015 16:52, Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/5483 Patch attached. Doesn't init_gettext() itself already print to stderr on failure? Nope -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
