Re: [Freeipa-devel] [PATCH 0386] private_ccache: Harden the removal of KRB5CCNAME env variable

2015-11-25 Thread Tomas Babej
On 11/25/2015 09:04 AM, Jan Cholasta wrote: > On 23.11.2015 15:19, Rob Crittenden wrote: >> Tomas Babej wrote: >>> >>> >>> On 11/23/2015 01:50 PM, Jan Cholasta wrote: On 23.11.2015 13:40, Tomas Babej wrote: > > > On 11/23/2015 01:31 PM, Jan Cholasta wrote: >> On 23.11.2015 13

Re: [Freeipa-devel] [PATCH 0386] private_ccache: Harden the removal of KRB5CCNAME env variable

2015-11-25 Thread Jan Cholasta
On 23.11.2015 15:19, Rob Crittenden wrote: Tomas Babej wrote: On 11/23/2015 01:50 PM, Jan Cholasta wrote: On 23.11.2015 13:40, Tomas Babej wrote: On 11/23/2015 01:31 PM, Jan Cholasta wrote: On 23.11.2015 13:28, Tomas Babej wrote: On 11/23/2015 01:11 PM, Jan Cholasta wrote: On 23.11.20

Re: [Freeipa-devel] [PATCH 0386] private_ccache: Harden the removal of KRB5CCNAME env variable

2015-11-23 Thread Rob Crittenden
Tomas Babej wrote: > > > On 11/23/2015 01:50 PM, Jan Cholasta wrote: >> On 23.11.2015 13:40, Tomas Babej wrote: >>> >>> >>> On 11/23/2015 01:31 PM, Jan Cholasta wrote: On 23.11.2015 13:28, Tomas Babej wrote: > > > On 11/23/2015 01:11 PM, Jan Cholasta wrote: >> On 23.11.2015 1

Re: [Freeipa-devel] [PATCH 0386] private_ccache: Harden the removal of KRB5CCNAME env variable

2015-11-23 Thread Tomas Babej
On 11/23/2015 01:50 PM, Jan Cholasta wrote: > On 23.11.2015 13:40, Tomas Babej wrote: >> >> >> On 11/23/2015 01:31 PM, Jan Cholasta wrote: >>> On 23.11.2015 13:28, Tomas Babej wrote: On 11/23/2015 01:11 PM, Jan Cholasta wrote: > On 23.11.2015 12:53, Tomas Babej wrote: >> Hi

Re: [Freeipa-devel] [PATCH 0386] private_ccache: Harden the removal of KRB5CCNAME env variable

2015-11-23 Thread Jan Cholasta
On 23.11.2015 13:40, Tomas Babej wrote: On 11/23/2015 01:31 PM, Jan Cholasta wrote: On 23.11.2015 13:28, Tomas Babej wrote: On 11/23/2015 01:11 PM, Jan Cholasta wrote: On 23.11.2015 12:53, Tomas Babej wrote: Hi, If the code within the private_ccache contextmanager does not set/removes th

Re: [Freeipa-devel] [PATCH 0386] private_ccache: Harden the removal of KRB5CCNAME env variable

2015-11-23 Thread Martin Kosek
On 11/23/2015 01:40 PM, Tomas Babej wrote: > > > On 11/23/2015 01:31 PM, Jan Cholasta wrote: >> On 23.11.2015 13:28, Tomas Babej wrote: >>> >>> >>> On 11/23/2015 01:11 PM, Jan Cholasta wrote: On 23.11.2015 12:53, Tomas Babej wrote: > Hi, > > If the code within the private_ccache

Re: [Freeipa-devel] [PATCH 0386] private_ccache: Harden the removal of KRB5CCNAME env variable

2015-11-23 Thread Tomas Babej
On 11/23/2015 01:31 PM, Jan Cholasta wrote: > On 23.11.2015 13:28, Tomas Babej wrote: >> >> >> On 11/23/2015 01:11 PM, Jan Cholasta wrote: >>> On 23.11.2015 12:53, Tomas Babej wrote: Hi, If the code within the private_ccache contextmanager does not set/removes the KRB5CCNAME,

Re: [Freeipa-devel] [PATCH 0386] private_ccache: Harden the removal of KRB5CCNAME env variable

2015-11-23 Thread Jan Cholasta
On 23.11.2015 13:28, Tomas Babej wrote: On 11/23/2015 01:11 PM, Jan Cholasta wrote: On 23.11.2015 12:53, Tomas Babej wrote: Hi, If the code within the private_ccache contextmanager does not set/removes the KRB5CCNAME, the pop method will raise KeyError, which will cause unnecessary terminati

Re: [Freeipa-devel] [PATCH 0386] private_ccache: Harden the removal of KRB5CCNAME env variable

2015-11-23 Thread Tomas Babej
On 11/23/2015 01:11 PM, Jan Cholasta wrote: > On 23.11.2015 12:53, Tomas Babej wrote: >> Hi, >> >> If the code within the private_ccache contextmanager does not >> set/removes the KRB5CCNAME, the pop method will raise KeyError, which >> will cause unnecessary termination of the code flow. >> >> M

Re: [Freeipa-devel] [PATCH 0386] private_ccache: Harden the removal of KRB5CCNAME env variable

2015-11-23 Thread Jan Cholasta
On 23.11.2015 12:53, Tomas Babej wrote: Hi, If the code within the private_ccache contextmanager does not set/removes the KRB5CCNAME, the pop method will raise KeyError, which will cause unnecessary termination of the code flow. Make sure the KRB5CCNAME is popped out of os.environ only if prese