Re: [Freeipa-devel] [PATCH 109] Use getent admin@domain for nss check in, ipa-client-install

2013-09-20 Thread Petr Viktorin

On 09/19/2013 04:41 PM, Ana Krivokapic wrote:

On 09/19/2013 04:33 PM, Tomas Babej wrote:

On 09/19/2013 11:59 AM, Tomas Babej wrote:

Hi,

Use 'getent admin@domain' rather than 'getent admin@REALM' to check
if nss
is working properly since admin@REALM check fails in case the domain
and the realm
name does not match.

https://fedorahosted.org/freeipa/ticket/3906




Thanks to Ana for telling me I basically copied Stephen's patch:

https://www.redhat.com/archives/freeipa-devel/2013-September/msg00085.html


And I did the same mistake. Fixed patched attached.




___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


ACK



Pushed to:
master: 316a9c215982527814089dc02be95fe14e635006
ipa-3-3: b0b7335cbaf104ba582c12b49e908c280d332cf6


--
PetrĀ³

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


Re: [Freeipa-devel] [PATCH 109] Use getent admin@domain for nss check in, ipa-client-install

2013-09-19 Thread Ana Krivokapic
On 09/19/2013 04:33 PM, Tomas Babej wrote:
> On 09/19/2013 11:59 AM, Tomas Babej wrote:
>> Hi,
>>
>> Use 'getent admin@domain' rather than 'getent admin@REALM' to check if nss
>> is working properly since admin@REALM check fails in case the domain and the
>> realm
>> name does not match.
>>
>> https://fedorahosted.org/freeipa/ticket/3906
>>
>>
>
> Thanks to Ana for telling me I basically copied Stephen's patch:
>
> https://www.redhat.com/archives/freeipa-devel/2013-September/msg00085.html
>
> And I did the same mistake. Fixed patched attached.
>
>
>
>
> ___
> Freeipa-devel mailing list
> Freeipa-devel@redhat.com
> https://www.redhat.com/mailman/listinfo/freeipa-devel

ACK

-- 
Regards,

Ana Krivokapic
Associate Software Engineer
FreeIPA team
Red Hat Inc.

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

Re: [Freeipa-devel] [PATCH 109] Use getent admin@domain for nss check in, ipa-client-install

2013-09-19 Thread Tomas Babej

On 09/19/2013 11:59 AM, Tomas Babej wrote:

Hi,

Use 'getent admin@domain' rather than 'getent admin@REALM' to check if 
nss
is working properly since admin@REALM check fails in case the domain 
and the realm

name does not match.

https://fedorahosted.org/freeipa/ticket/3906




Thanks to Ana for telling me I basically copied Stephen's patch:

https://www.redhat.com/archives/freeipa-devel/2013-September/msg00085.html

And I did the same mistake. Fixed patched attached.


--
Tomas Babej
Associate Software Engeneer | Red Hat | Identity Management
RHCE | Brno Site | IRC: tbabej | freeipa.org

From e399363d7c7de0320652e8745a2bcaff523d5037 Mon Sep 17 00:00:00 2001
From: Tomas Babej 
Date: Wed, 18 Sep 2013 13:18:37 +0200
Subject: [PATCH 109/110] Use getent admin@domain for nss check in
 ipa-client-install

Use 'getent admin@domain' rather than 'getent admin@REALM' to check if nss
is working properly since admin@REALM check fails in case the domain and the realm
name does not match.

https://fedorahosted.org/freeipa/ticket/3906
---
 ipa-client/ipa-install/ipa-client-install | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/ipa-client/ipa-install/ipa-client-install b/ipa-client/ipa-install/ipa-client-install
index 59381fe97559197bab91cbb396eb7217e583582b..7e474bd59a850e12f1f9f2f72a81cf9a979f779a 100755
--- a/ipa-client/ipa-install/ipa-client-install
+++ b/ipa-client/ipa-install/ipa-client-install
@@ -2502,7 +2502,7 @@ def install(options, env, fstore, statestore):
 # Particulary, SSSD might take longer than 6-8 seconds.
 while n < 10 and not found:
 try:
-ipautil.run(["getent", "passwd", "admin@%s" % cli_realm])
+ipautil.run(["getent", "passwd", "admin@%s" % cli_domain])
 found = True
 except Exception, e:
 time.sleep(1)
@@ -2511,7 +2511,7 @@ def install(options, env, fstore, statestore):
 if not found:
 root_logger.error(
 "Unable to find 'admin' user with "
-"'getent passwd admin@%s'!" % cli_realm)
+"'getent passwd admin@%s'!" % cli_domain)
 if conf:
 root_logger.info("Recognized configuration: %s", conf)
 else:
-- 
1.8.3.1

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel