Re: [Freeipa-devel] [PATCH 565] Fix potential aborts in KDB driver

2016-01-20 Thread Martin Basti
On 13.01.2016 16:13, Martin Basti wrote: On 13.01.2016 16:03, Simo Sorce wrote: On Wed, 2016-01-13 at 15:49 +0100, Martin Basti wrote: On 13.01.2016 15:31, Martin Babinsky wrote: On 01/13/2016 03:30 PM, Simo Sorce wrote: On Wed, 2016-01-13 at 14:02 +0100, Martin Babinsky wrote: On

Re: [Freeipa-devel] [PATCH 565] Fix potential aborts in KDB driver

2016-01-13 Thread Martin Babinsky
On 01/05/2016 11:19 PM, Simo Sorce wrote: On Tue, 2016-01-05 at 16:15 -0500, Simo Sorce wrote: The LDAP context was not checked on the first api call and a context may be null on some error conditions (LDAP server unreachable). Always check that we have a valid context before calling the ldap

Re: [Freeipa-devel] [PATCH 565] Fix potential aborts in KDB driver

2016-01-13 Thread Martin Babinsky
On 01/13/2016 03:30 PM, Simo Sorce wrote: On Wed, 2016-01-13 at 14:02 +0100, Martin Babinsky wrote: On 01/05/2016 11:19 PM, Simo Sorce wrote: On Tue, 2016-01-05 at 16:15 -0500, Simo Sorce wrote: The LDAP context was not checked on the first api call and a context may be null on some error

Re: [Freeipa-devel] [PATCH 565] Fix potential aborts in KDB driver

2016-01-13 Thread Martin Basti
On 13.01.2016 15:31, Martin Babinsky wrote: On 01/13/2016 03:30 PM, Simo Sorce wrote: On Wed, 2016-01-13 at 14:02 +0100, Martin Babinsky wrote: On 01/05/2016 11:19 PM, Simo Sorce wrote: On Tue, 2016-01-05 at 16:15 -0500, Simo Sorce wrote: The LDAP context was not checked on the first api

Re: [Freeipa-devel] [PATCH 565] Fix potential aborts in KDB driver

2016-01-13 Thread Simo Sorce
On Wed, 2016-01-13 at 15:49 +0100, Martin Basti wrote: > > On 13.01.2016 15:31, Martin Babinsky wrote: > > On 01/13/2016 03:30 PM, Simo Sorce wrote: > >> On Wed, 2016-01-13 at 14:02 +0100, Martin Babinsky wrote: > >>> On 01/05/2016 11:19 PM, Simo Sorce wrote: > On Tue, 2016-01-05 at 16:15

Re: [Freeipa-devel] [PATCH 565] Fix potential aborts in KDB driver

2016-01-13 Thread Simo Sorce
On Wed, 2016-01-13 at 14:02 +0100, Martin Babinsky wrote: > On 01/05/2016 11:19 PM, Simo Sorce wrote: > > On Tue, 2016-01-05 at 16:15 -0500, Simo Sorce wrote: > >> The LDAP context was not checked on the first api call and a context may > >> be null on some error conditions (LDAP server

Re: [Freeipa-devel] [PATCH 565] Fix potential aborts in KDB driver

2016-01-05 Thread Simo Sorce
On Tue, 2016-01-05 at 16:15 -0500, Simo Sorce wrote: > The LDAP context was not checked on the first api call and a context may > be null on some error conditions (LDAP server unreachable). > > Always check that we have a valid context before calling the ldap API. > > Builds abut it is untested.