Re: [Freeipa-devel] [PATCH 64] Implement password based session login

2012-02-27 Thread Martin Kosek
On Sun, 2012-02-26 at 11:22 -0500, John Dennis wrote: ... There is one other minor issue not included in any previous patches nor this one, the VERSION file should be updated to force the apache configuration to be updated. Thanks for the patches John, a lot of work have been done. I would

Re: [Freeipa-devel] [PATCH 64] Implement password based session login

2012-02-27 Thread John Dennis
Attached is a revised patch, it addresses the following concerns raised during review: * The version in ipa.conf has been bumped. * Rob reported duplicate session cookies being returned. As far as I can tell this was due to a Python bug where it reused the value of a default keyword

Re: [Freeipa-devel] [PATCH 64] Implement password based session login

2012-02-27 Thread Rob Crittenden
John Dennis wrote: Attached is a revised patch, it addresses the following concerns raised during review: * The version in ipa.conf has been bumped. * Rob reported duplicate session cookies being returned. As far as I can tell this was due to a Python bug where it reused the value of a default

Re: [Freeipa-devel] [PATCH 64] Implement password based session login

2012-02-27 Thread John Dennis
On 02/27/2012 01:50 PM, Rob Crittenden wrote: John Dennis wrote: Attached is a revised patch, it addresses the following concerns raised during review: * The version in ipa.conf has been bumped. * Rob reported duplicate session cookies being returned. As far as I can tell this was due to a

Re: [Freeipa-devel] [PATCH 64] Implement password based session login

2012-02-27 Thread Rob Crittenden
John Dennis wrote: On 02/27/2012 01:50 PM, Rob Crittenden wrote: John Dennis wrote: Attached is a revised patch, it addresses the following concerns raised during review: * The version in ipa.conf has been bumped. * Rob reported duplicate session cookies being returned. As far as I can tell

Re: [Freeipa-devel] [PATCH 64] Implement password based session login

2012-02-27 Thread John Dennis
On 02/27/2012 05:53 PM, Rob Crittenden wrote: John Dennis wrote: On 02/27/2012 01:50 PM, Rob Crittenden wrote: John Dennis wrote: Attached is a revised patch, it addresses the following concerns raised during review: * The version in ipa.conf has been bumped. * Rob reported duplicate

Re: [Freeipa-devel] [PATCH 64] Implement password based session login

2012-02-27 Thread Rob Crittenden
John Dennis wrote: On 02/27/2012 05:53 PM, Rob Crittenden wrote: John Dennis wrote: On 02/27/2012 01:50 PM, Rob Crittenden wrote: John Dennis wrote: Attached is a revised patch, it addresses the following concerns raised during review: * The version in ipa.conf has been bumped. * Rob

Re: [Freeipa-devel] [PATCH 64] Implement password based session login

2012-02-26 Thread Rob Crittenden
John Dennis wrote: This patch adds support for password based session login (see detailed comments in patch) Only the server side is implemented, someone will have to add password based login to the UI, when they do they should update the unauthorized messges to include the new method, those

Re: [Freeipa-devel] [PATCH 64] Implement password based session login

2012-02-26 Thread John Dennis
On 02/26/2012 03:38 PM, Rob Crittenden wrote: John Dennis wrote: This patch adds support for password based session login (see detailed comments in patch) Only the server side is implemented, someone will have to add password based login to the UI, when they do they should update the

Re: [Freeipa-devel] [PATCH 64] Implement password based session login

2012-02-26 Thread John Dennis
On 02/26/2012 03:54 PM, John Dennis wrote: I assume you're running the script I attached. The reason why you keep getting new sessions is because the script does not send the previous cookie back, from the server's perspective these all appear to be new login requests. Sessions are not tracked

Re: [Freeipa-devel] [PATCH 64] Implement password based session login

2012-02-26 Thread Rob Crittenden
John Dennis wrote: On 02/26/2012 03:54 PM, John Dennis wrote: I assume you're running the script I attached. The reason why you keep getting new sessions is because the script does not send the previous cookie back, from the server's perspective these all appear to be new login requests.

Re: [Freeipa-devel] [PATCH 64] Implement password based session login

2012-02-26 Thread John Dennis
On 02/26/2012 04:40 PM, Rob Crittenden wrote: John Dennis wrote: On 02/26/2012 03:54 PM, John Dennis wrote: I assume you're running the script I attached. The reason why you keep getting new sessions is because the script does not send the previous cookie back, from the server's perspective