Re: [Freeipa-devel] [PATCH 68] text unit test should validate using installed mo file

2012-04-11 Thread Rob Crittenden
Petr Viktorin wrote: On 04/09/2012 05:24 PM, John Dennis wrote: On 03/30/2012 08:57 AM, Petr Viktorin wrote: On 03/30/2012 02:41 AM, John Dennis wrote: On 03/28/2012 04:40 AM, Petr Viktorin wrote: Can install/po/Makefile just call test_i18n.py from the tests/ tree? It doesn't import any IPA c

Re: [Freeipa-devel] [PATCH 68] text unit test should validate using installed mo file

2012-04-10 Thread Petr Viktorin
On 04/09/2012 05:24 PM, John Dennis wrote: On 03/30/2012 08:57 AM, Petr Viktorin wrote: On 03/30/2012 02:41 AM, John Dennis wrote: On 03/28/2012 04:40 AM, Petr Viktorin wrote: Can install/po/Makefile just call test_i18n.py from the tests/ tree? It doesn't import any IPA code so there's no need

Re: [Freeipa-devel] [PATCH 68] text unit test should validate using installed mo file

2012-03-30 Thread Petr Viktorin
On 03/30/2012 02:41 AM, John Dennis wrote: On 03/28/2012 04:40 AM, Petr Viktorin wrote: Can install/po/Makefile just call test_i18n.py from the tests/ tree? It doesn't import any IPA code so there's no need to set sys.path in this case (though there'd have to be a comment saying we depend on thi

Re: [Freeipa-devel] [PATCH 68] text unit test should validate using installed mo file

2012-03-28 Thread Petr Viktorin
On 03/27/2012 10:31 PM, John Dennis wrote: On 03/27/2012 01:57 PM, Petr Viktorin wrote: Seeing this, I definitely recommend putting po_file_iterate in an importable package. Of course I considered that. Clearly not any existing top level directory in the tree, those are reserved for what we in

Re: [Freeipa-devel] [PATCH 68] text unit test should validate using installed mo file

2012-03-27 Thread John Dennis
On 03/27/2012 01:57 PM, Petr Viktorin wrote: Seeing this, I definitely recommend putting po_file_iterate in an importable package. Of course I considered that. Clearly not any existing top level directory in the tree, those are reserved for what we install and what is "import visible" after i

Re: [Freeipa-devel] [PATCH 68] text unit test should validate using installed mo file

2012-03-27 Thread Petr Viktorin
On 03/27/2012 04:58 PM, John Dennis wrote: [...] def test_create_translation(): f = text.create_translation key = ('foo', None) @@ -129,6 +45,84 @@ def test_create_translation(): assert context.__dict__[key] is t +class test_TestLang(object): +def setUp(self): +

Re: [Freeipa-devel] [PATCH 68] text unit test should validate using installed mo file

2012-03-27 Thread John Dennis
On 03/27/2012 10:34 AM, John Dennis wrote: This patch addresses ticket 2582, see comments in commit message. Sorry, the patch I originally posted was incorrect, the work had been done in several commits but I forgot to "squash" them into one commit and patch before posting it. This new patch