Re: [Freeipa-devel] [PATCHES] 0014-0016 Deprecate HBAC source hosts

2013-04-12 Thread Ana Krivokapic

On 04/12/2013 12:31 AM, Ana Krivokapic wrote:

On 04/11/2013 05:57 PM, Rob Crittenden wrote:

Petr Viktorin wrote:

On 04/11/2013 12:01 AM, Rob Crittenden wrote:

Ana Krivokapic wrote:

Hello,

This patch set deprecates HBAC source hosts from IPA.

See commit messages and the design page[1] for details.

https://fedorahosted.org/freeipa/ticket/3528

[1] http://www.freeipa.org/page/V3/HBACSourceHosts


Been a while since I've run the UI but I get an error in FF 18:

Timestamp: 04/10/2013 05:43:31 PM
Error: TypeError: e.messages is undefined
Source File: https://rawhide2.greyoak.com/ipa/ui/js/freeipa/app.js
Line: 1


This probably means that you didn't rebuild the UI since 42300eb.
Try git clean and a fresh rebuild, or use tools in install/ui/util/
(Petr Vobornik is the person to ask about those).


Seems to have been a remnant of a previous build. I'm guessing that 
the UI build directories aren't covered by a clean/distclean. I 
manually removed some files from build and it works now.





The other changes seem to operate fine. I tested with an older client
and got reasonable error messages back when I tried to do the various
sourcehost things.

I got an unknown error message with --add-sourcehost but it did 
include

the text that the command is deprecated so I think this is acceptable.
There isn't a lot we can do, I'm sorry we didn't add this exception in
the beginning.

I do wonder if we should leave the warning in hbactest if 
sourcehost is

set though, for those cases where there are already options set.


So this question still remains, should we leave the sourcehost 
warning in hbactest for another release or two?


rob

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


Rob and I agreed on IRC to put the sourcehost warning back in hbactest 
for now. I updated the patch 0016 accordingly. (It also needed a 
slight rebase, due to API changes that happened in the meantime.) New 
version is attached.




___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


After further discussion on IRC, we decided there is no reason to keep 
the warning after all. I am attaching a rebased version of the original 
patch 0016.


--
Regards,

Ana Krivokapic
Associate Software Engineer
FreeIPA team
Red Hat Inc.

From 61e168906a2869ab01aa82839b3967cdf5dad10a Mon Sep 17 00:00:00 2001
From: Ana Krivokapic akriv...@redhat.com
Date: Fri, 12 Apr 2013 17:38:09 +0200
Subject: [PATCH] Deprecate HBAC source hosts from CLI

Hide the commands and options listed below from the CLI,
but keep them in the API. When called directly from the API,
raise appropriate exceptions informing the user that the
functionality has been deprecated.

Affected commands: hbacrule_add_sourcehost, hbacrule_remove_sourcehost.
Affected options: sourcehostcategory, sourcehost_host and
sourcehost_hostgroup (hbacrule); sourcehost (hbactest).

https://fedorahosted.org/freeipa/ticket/3528
---
 API.txt   |  20 +++--
 VERSION   |   2 +-
 ipalib/__init__.py|   2 +-
 ipalib/errors.py  |  15 
 ipalib/parameters.py  |  17 
 ipalib/plugins/hbacrule.py|  49 +++
 ipalib/plugins/hbactest.py|  26 +-
 tests/test_xmlrpc/test_hbac_plugin.py | 131 --
 tests/test_xmlrpc/test_hbactest_plugin.py |  80 +++---
 9 files changed, 86 insertions(+), 256 deletions(-)

diff --git a/API.txt b/API.txt
index 13cb380e05ffcb96d28becb04feb184d24ecf986..3e01fdc3611b5bc71e1a4ee185af63f7c4b07c06 100644
--- a/API.txt
+++ b/API.txt
@@ -1379,7 +1379,7 @@ output: Entry('result', type 'dict', Gettext('A dictionary representing an LDA
 output: Output('summary', (type 'unicode', type 'NoneType'), None)
 output: Output('value', type 'unicode', None)
 command: hbacrule_add
-args: 1,13,3
+args: 1,15,3
 arg: Str('cn', attribute=True, cli_name='name', multivalue=False, primary_key=True, required=True)
 option: StrEnum('accessruletype', attribute=True, autofill=True, cli_name='type', default=u'allow', exclude='webui', multivalue=False, required=True, values=(u'allow', u'deny'))
 option: Str('addattr*', cli_name='addattr', exclude='webui')
@@ -1391,7 +1391,9 @@ option: Bool('ipaenabledflag', attribute=True, cli_name='ipaenabledflag', multiv
 option: Flag('raw', autofill=True, cli_name='raw', default=False, exclude='webui')
 option: StrEnum('servicecategory', attribute=True, cli_name='servicecat', multivalue=False, required=False, values=(u'all',))
 option: Str('setattr*', cli_name='setattr', exclude='webui')
-option: StrEnum('sourcehostcategory', attribute=True, cli_name='srchostcat', multivalue=False, required=False, values=(u'all',))
+option: DeprecatedParam('sourcehost_host', 

Re: [Freeipa-devel] [PATCHES] 0014-0016 Deprecate HBAC source hosts

2013-04-12 Thread Rob Crittenden

Ana Krivokapic wrote:

On 04/12/2013 12:31 AM, Ana Krivokapic wrote:

On 04/11/2013 05:57 PM, Rob Crittenden wrote:

Petr Viktorin wrote:

On 04/11/2013 12:01 AM, Rob Crittenden wrote:

Ana Krivokapic wrote:

Hello,

This patch set deprecates HBAC source hosts from IPA.

See commit messages and the design page[1] for details.

https://fedorahosted.org/freeipa/ticket/3528

[1] http://www.freeipa.org/page/V3/HBACSourceHosts


Been a while since I've run the UI but I get an error in FF 18:

Timestamp: 04/10/2013 05:43:31 PM
Error: TypeError: e.messages is undefined
Source File: https://rawhide2.greyoak.com/ipa/ui/js/freeipa/app.js
Line: 1


This probably means that you didn't rebuild the UI since 42300eb.
Try git clean and a fresh rebuild, or use tools in install/ui/util/
(Petr Vobornik is the person to ask about those).


Seems to have been a remnant of a previous build. I'm guessing that
the UI build directories aren't covered by a clean/distclean. I
manually removed some files from build and it works now.




The other changes seem to operate fine. I tested with an older client
and got reasonable error messages back when I tried to do the various
sourcehost things.

I got an unknown error message with --add-sourcehost but it did
include
the text that the command is deprecated so I think this is acceptable.
There isn't a lot we can do, I'm sorry we didn't add this exception in
the beginning.

I do wonder if we should leave the warning in hbactest if
sourcehost is
set though, for those cases where there are already options set.


So this question still remains, should we leave the sourcehost
warning in hbactest for another release or two?

rob

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


Rob and I agreed on IRC to put the sourcehost warning back in hbactest
for now. I updated the patch 0016 accordingly. (It also needed a
slight rebase, due to API changes that happened in the meantime.) New
version is attached.



___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


After further discussion on IRC, we decided there is no reason to keep
the warning after all. I am attaching a rebased version of the original
patch 0016.


ACK. Pushed to master and rebased and pushed to ipa-3-1

rob

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


Re: [Freeipa-devel] [PATCHES] 0014-0016 Deprecate HBAC source hosts

2013-04-12 Thread Ana Krivokapic

On 04/12/2013 08:30 PM, Rob Crittenden wrote:

Ana Krivokapic wrote:

On 04/12/2013 12:31 AM, Ana Krivokapic wrote:

On 04/11/2013 05:57 PM, Rob Crittenden wrote:

Petr Viktorin wrote:

On 04/11/2013 12:01 AM, Rob Crittenden wrote:

Ana Krivokapic wrote:

Hello,

This patch set deprecates HBAC source hosts from IPA.

See commit messages and the design page[1] for details.

https://fedorahosted.org/freeipa/ticket/3528

[1] http://www.freeipa.org/page/V3/HBACSourceHosts


Been a while since I've run the UI but I get an error in FF 18:

Timestamp: 04/10/2013 05:43:31 PM
Error: TypeError: e.messages is undefined
Source File: https://rawhide2.greyoak.com/ipa/ui/js/freeipa/app.js
Line: 1


This probably means that you didn't rebuild the UI since 42300eb.
Try git clean and a fresh rebuild, or use tools in install/ui/util/
(Petr Vobornik is the person to ask about those).


Seems to have been a remnant of a previous build. I'm guessing that
the UI build directories aren't covered by a clean/distclean. I
manually removed some files from build and it works now.



The other changes seem to operate fine. I tested with an older 
client
and got reasonable error messages back when I tried to do the 
various

sourcehost things.

I got an unknown error message with --add-sourcehost but it did
include
the text that the command is deprecated so I think this is 
acceptable.
There isn't a lot we can do, I'm sorry we didn't add this 
exception in

the beginning.

I do wonder if we should leave the warning in hbactest if
sourcehost is
set though, for those cases where there are already options set.


So this question still remains, should we leave the sourcehost
warning in hbactest for another release or two?

rob

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


Rob and I agreed on IRC to put the sourcehost warning back in hbactest
for now. I updated the patch 0016 accordingly. (It also needed a
slight rebase, due to API changes that happened in the meantime.) New
version is attached.



___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


After further discussion on IRC, we decided there is no reason to keep
the warning after all. I am attaching a rebased version of the original
patch 0016.


ACK. Pushed to master and rebased and pushed to ipa-3-1

rob



I've linked the design page in http://www.freeipa.org/page/V3_Designs

--
Regards,

Ana Krivokapic
Associate Software Engineer
FreeIPA team
Red Hat Inc.

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


Re: [Freeipa-devel] [PATCHES] 0014-0016 Deprecate HBAC source hosts

2013-04-11 Thread Petr Viktorin

On 04/11/2013 12:01 AM, Rob Crittenden wrote:

Ana Krivokapic wrote:

Hello,

This patch set deprecates HBAC source hosts from IPA.

See commit messages and the design page[1] for details.

https://fedorahosted.org/freeipa/ticket/3528

[1] http://www.freeipa.org/page/V3/HBACSourceHosts


Been a while since I've run the UI but I get an error in FF 18:

Timestamp: 04/10/2013 05:43:31 PM
Error: TypeError: e.messages is undefined
Source File: https://rawhide2.greyoak.com/ipa/ui/js/freeipa/app.js
Line: 1


This probably means that you didn't rebuild the UI since 42300eb.
Try git clean and a fresh rebuild, or use tools in install/ui/util/ 
(Petr Vobornik is the person to ask about those).



The other changes seem to operate fine. I tested with an older client
and got reasonable error messages back when I tried to do the various
sourcehost things.

I got an unknown error message with --add-sourcehost but it did include
the text that the command is deprecated so I think this is acceptable.
There isn't a lot we can do, I'm sorry we didn't add this exception in
the beginning.

I do wonder if we should leave the warning in hbactest if sourcehost is
set though, for those cases where there are already options set.

rob

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel



--
PetrĀ³

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


Re: [Freeipa-devel] [PATCHES] 0014-0016 Deprecate HBAC source hosts

2013-04-11 Thread Rob Crittenden

Petr Viktorin wrote:

On 04/11/2013 12:01 AM, Rob Crittenden wrote:

Ana Krivokapic wrote:

Hello,

This patch set deprecates HBAC source hosts from IPA.

See commit messages and the design page[1] for details.

https://fedorahosted.org/freeipa/ticket/3528

[1] http://www.freeipa.org/page/V3/HBACSourceHosts


Been a while since I've run the UI but I get an error in FF 18:

Timestamp: 04/10/2013 05:43:31 PM
Error: TypeError: e.messages is undefined
Source File: https://rawhide2.greyoak.com/ipa/ui/js/freeipa/app.js
Line: 1


This probably means that you didn't rebuild the UI since 42300eb.
Try git clean and a fresh rebuild, or use tools in install/ui/util/
(Petr Vobornik is the person to ask about those).


Seems to have been a remnant of a previous build. I'm guessing that the 
UI build directories aren't covered by a clean/distclean. I manually 
removed some files from build and it works now.





The other changes seem to operate fine. I tested with an older client
and got reasonable error messages back when I tried to do the various
sourcehost things.

I got an unknown error message with --add-sourcehost but it did include
the text that the command is deprecated so I think this is acceptable.
There isn't a lot we can do, I'm sorry we didn't add this exception in
the beginning.

I do wonder if we should leave the warning in hbactest if sourcehost is
set though, for those cases where there are already options set.


So this question still remains, should we leave the sourcehost warning 
in hbactest for another release or two?


rob

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


Re: [Freeipa-devel] [PATCHES] 0014-0016 Deprecate HBAC source hosts

2013-04-11 Thread Ana Krivokapic

On 04/11/2013 05:57 PM, Rob Crittenden wrote:

Petr Viktorin wrote:

On 04/11/2013 12:01 AM, Rob Crittenden wrote:

Ana Krivokapic wrote:

Hello,

This patch set deprecates HBAC source hosts from IPA.

See commit messages and the design page[1] for details.

https://fedorahosted.org/freeipa/ticket/3528

[1] http://www.freeipa.org/page/V3/HBACSourceHosts


Been a while since I've run the UI but I get an error in FF 18:

Timestamp: 04/10/2013 05:43:31 PM
Error: TypeError: e.messages is undefined
Source File: https://rawhide2.greyoak.com/ipa/ui/js/freeipa/app.js
Line: 1


This probably means that you didn't rebuild the UI since 42300eb.
Try git clean and a fresh rebuild, or use tools in install/ui/util/
(Petr Vobornik is the person to ask about those).


Seems to have been a remnant of a previous build. I'm guessing that 
the UI build directories aren't covered by a clean/distclean. I 
manually removed some files from build and it works now.





The other changes seem to operate fine. I tested with an older client
and got reasonable error messages back when I tried to do the various
sourcehost things.

I got an unknown error message with --add-sourcehost but it did include
the text that the command is deprecated so I think this is acceptable.
There isn't a lot we can do, I'm sorry we didn't add this exception in
the beginning.

I do wonder if we should leave the warning in hbactest if sourcehost is
set though, for those cases where there are already options set.


So this question still remains, should we leave the sourcehost warning 
in hbactest for another release or two?


rob

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


Rob and I agreed on IRC to put the sourcehost warning back in hbactest 
for now. I updated the patch 0016 accordingly. (It also needed a slight 
rebase, due to API changes that happened in the meantime.) New version 
is attached.


--
Regards,

Ana Krivokapic
Associate Software Engineer
FreeIPA team
Red Hat Inc.

From 3af5d795939964e4f29bba5d0f1105f46b5f02be Mon Sep 17 00:00:00 2001
From: Ana Krivokapic akriv...@redhat.com
Date: Fri, 12 Apr 2013 00:17:55 +0200
Subject: [PATCH] Deprecate HBAC source hosts from CLI

Hide the commands and options listed below from the CLI,
but keep them in the API. When called directly from the API,
raise appropriate exceptions informing the user that the
functionality has been deprecated.

Affected commands: hbacrule_add_sourcehost, hbacrule_remove_sourcehost.
Affected options: sourcehostcategory, sourcehost_host and
sourcehost_hostgroup (hbacrule); sourcehost (hbactest).

https://fedorahosted.org/freeipa/ticket/3528
---
 API.txt   |  20 +++--
 VERSION   |   2 +-
 ipalib/__init__.py|   2 +-
 ipalib/errors.py  |  15 
 ipalib/parameters.py  |  17 
 ipalib/plugins/hbacrule.py|  49 +++
 ipalib/plugins/hbactest.py|   9 +-
 tests/test_xmlrpc/test_hbac_plugin.py | 131 --
 tests/test_xmlrpc/test_hbactest_plugin.py |  80 +++---
 9 files changed, 86 insertions(+), 239 deletions(-)

diff --git a/API.txt b/API.txt
index 13cb380e05ffcb96d28becb04feb184d24ecf986..3e01fdc3611b5bc71e1a4ee185af63f7c4b07c06 100644
--- a/API.txt
+++ b/API.txt
@@ -1379,7 +1379,7 @@ output: Entry('result', type 'dict', Gettext('A dictionary representing an LDA
 output: Output('summary', (type 'unicode', type 'NoneType'), None)
 output: Output('value', type 'unicode', None)
 command: hbacrule_add
-args: 1,13,3
+args: 1,15,3
 arg: Str('cn', attribute=True, cli_name='name', multivalue=False, primary_key=True, required=True)
 option: StrEnum('accessruletype', attribute=True, autofill=True, cli_name='type', default=u'allow', exclude='webui', multivalue=False, required=True, values=(u'allow', u'deny'))
 option: Str('addattr*', cli_name='addattr', exclude='webui')
@@ -1391,7 +1391,9 @@ option: Bool('ipaenabledflag', attribute=True, cli_name='ipaenabledflag', multiv
 option: Flag('raw', autofill=True, cli_name='raw', default=False, exclude='webui')
 option: StrEnum('servicecategory', attribute=True, cli_name='servicecat', multivalue=False, required=False, values=(u'all',))
 option: Str('setattr*', cli_name='setattr', exclude='webui')
-option: StrEnum('sourcehostcategory', attribute=True, cli_name='srchostcat', multivalue=False, required=False, values=(u'all',))
+option: DeprecatedParam('sourcehost_host', attribute=True, cli_name='sourcehost_host', multivalue=False, required=False)
+option: DeprecatedParam('sourcehost_hostgroup', attribute=True, cli_name='sourcehost_hostgroup', multivalue=False, required=False)
+option: DeprecatedParam('sourcehostcategory', attribute=True, cli_name='sourcehostcategory', multivalue=False, required=False)
 option: StrEnum('usercategory', 

Re: [Freeipa-devel] [PATCHES] 0014-0016 Deprecate HBAC source hosts

2013-04-10 Thread Rob Crittenden

Ana Krivokapic wrote:

Hello,

This patch set deprecates HBAC source hosts from IPA.

See commit messages and the design page[1] for details.

https://fedorahosted.org/freeipa/ticket/3528

[1] http://www.freeipa.org/page/V3/HBACSourceHosts


Been a while since I've run the UI but I get an error in FF 18:

Timestamp: 04/10/2013 05:43:31 PM
Error: TypeError: e.messages is undefined
Source File: https://rawhide2.greyoak.com/ipa/ui/js/freeipa/app.js
Line: 1

The other changes seem to operate fine. I tested with an older client 
and got reasonable error messages back when I tried to do the various 
sourcehost things.


I got an unknown error message with --add-sourcehost but it did include 
the text that the command is deprecated so I think this is acceptable. 
There isn't a lot we can do, I'm sorry we didn't add this exception in 
the beginning.


I do wonder if we should leave the warning in hbactest if sourcehost is 
set though, for those cases where there are already options set.


rob

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel