Re: [Freeipa-devel] [PATCHES] 0025-26 Test improvements

2012-04-04 Thread Petr Viktorin
On 04/02/2012 05:05 PM, Rob Crittenden wrote: Petr Viktorin wrote: On 03/26/2012 10:44 PM, Rob Crittenden wrote: Petr Viktorin wrote: Patch 25 fixes errors I found by running pylint on the testsuite. They were in code that was unused, either by error or because it only runs on errors. Patch

Re: [Freeipa-devel] [PATCHES] 0025-26 Test improvements

2012-04-02 Thread Rob Crittenden
Petr Viktorin wrote: On 03/26/2012 10:44 PM, Rob Crittenden wrote: Petr Viktorin wrote: Patch 25 fixes errors I found by running pylint on the testsuite. They were in code that was unused, either by error or because it only runs on errors. Patch 26 adds a test for the batch plugin. In patch

Re: [Freeipa-devel] [PATCHES] 0025-26 Test improvements

2012-03-27 Thread Petr Viktorin
On 03/26/2012 10:44 PM, Rob Crittenden wrote: Petr Viktorin wrote: Patch 25 fixes errors I found by running pylint on the testsuite. They were in code that was unused, either by error or because it only runs on errors. Patch 26 adds a test for the batch plugin. In patch 25 the second

Re: [Freeipa-devel] [PATCHES] 0025-26 Test improvements

2012-03-26 Thread Rob Crittenden
Petr Viktorin wrote: Patch 25 fixes errors I found by running pylint on the testsuite. They were in code that was unused, either by error or because it only runs on errors. Patch 26 adds a test for the batch plugin. In patch 25 the second test_internal_error should really be