Re: [Freeipa-devel] [PATCHES] 0585-0587 Convert Password Policy COSTemplate default permissions to managed

2014-06-18 Thread Martin Kosek
On 06/13/2014 06:03 PM, Petr Viktorin wrote:
 The first patch is preparation.
 
 As for the second two, this is how the bulk of the transition will look.

Works fine, also tested with unit test. When testing it, I found one error:

# ipa pwpolicy-add ipausers --maxlife 90 --minlife 1 --priority 1
ipa: ERROR: no such entry

However, this is not a problem in pwpolicy permissions, but rather caused by
https://fedorahosted.org/freeipa/ticket/4372
as ipausers is not readable to the privileged user even though the user has
Group Administrators privilege.

ACK to this patch set (I wanted to push myself, but you just cause a conflict :)

Martin

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


Re: [Freeipa-devel] [PATCHES] 0585-0587 Convert Password Policy COSTemplate default permissions to managed

2014-06-18 Thread Petr Viktorin

On 06/18/2014 02:48 PM, Martin Kosek wrote:

On 06/13/2014 06:03 PM, Petr Viktorin wrote:

The first patch is preparation.

As for the second two, this is how the bulk of the transition will look.


Works fine, also tested with unit test. When testing it, I found one error:

# ipa pwpolicy-add ipausers --maxlife 90 --minlife 1 --priority 1
ipa: ERROR: no such entry

However, this is not a problem in pwpolicy permissions, but rather caused by
https://fedorahosted.org/freeipa/ticket/4372
as ipausers is not readable to the privileged user even though the user has
Group Administrators privilege.

ACK to this patch set (I wanted to push myself, but you just cause a conflict :)


Thanks for the review!



--
PetrĀ³

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel