Re: [Freeipa-devel] [PATCHES] 295-299 Allow changing chaining of the IPA CA certificate

2014-07-30 Thread Petr Viktorin
On 07/30/2014 02:51 PM, Jan Cholasta wrote: Dne 30.7.2014 v 14:47 Rob Crittenden napsal(a): Jan Cholasta wrote: Dne 29.7.2014 v 16:33 Rob Crittenden napsal(a): Rob Crittenden wrote: Jan Cholasta wrote: Dne 28.7.2014 v 21:39 Rob Crittenden napsal(a): This is oh-so close. AFAICT it generally

Re: [Freeipa-devel] [PATCHES] 295-299 Allow changing chaining of the IPA CA certificate

2014-07-30 Thread Jan Cholasta
Dne 30.7.2014 v 14:47 Rob Crittenden napsal(a): Jan Cholasta wrote: Dne 29.7.2014 v 16:33 Rob Crittenden napsal(a): Rob Crittenden wrote: Jan Cholasta wrote: Dne 28.7.2014 v 21:39 Rob Crittenden napsal(a): This is oh-so close. AFAICT it generally does what it should, I think it is ready for

Re: [Freeipa-devel] [PATCHES] 295-299 Allow changing chaining of the IPA CA certificate

2014-07-30 Thread Rob Crittenden
Jan Cholasta wrote: > Dne 29.7.2014 v 16:33 Rob Crittenden napsal(a): >> Rob Crittenden wrote: >>> Jan Cholasta wrote: Dne 28.7.2014 v 21:39 Rob Crittenden napsal(a): > This is oh-so close. AFAICT it generally does what it should, I > think it > is ready for a wider audience. Just

Re: [Freeipa-devel] [PATCHES] 295-299 Allow changing chaining of the IPA CA certificate

2014-07-30 Thread Jan Cholasta
Dne 29.7.2014 v 16:33 Rob Crittenden napsal(a): Rob Crittenden wrote: Jan Cholasta wrote: Dne 28.7.2014 v 21:39 Rob Crittenden napsal(a): This is oh-so close. AFAICT it generally does what it should, I think it is ready for a wider audience. Just a few more things: 306: A while True loop is u

Re: [Freeipa-devel] [PATCHES] 295-299 Allow changing chaining of the IPA CA certificate

2014-07-29 Thread Rob Crittenden
Rob Crittenden wrote: > Jan Cholasta wrote: >> Dne 28.7.2014 v 21:39 Rob Crittenden napsal(a): >>> This is oh-so close. AFAICT it generally does what it should, I think it >>> is ready for a wider audience. Just a few more things: >>> >>> 306: A while True loop is used for something which AFAICT ca

Re: [Freeipa-devel] [PATCHES] 295-299 Allow changing chaining of the IPA CA certificate

2014-07-29 Thread Rob Crittenden
Jan Cholasta wrote: > Dne 28.7.2014 v 21:39 Rob Crittenden napsal(a): >> This is oh-so close. AFAICT it generally does what it should, I think it >> is ready for a wider audience. Just a few more things: >> >> 306: A while True loop is used for something which AFAICT can only ever >> execute once.

Re: [Freeipa-devel] [PATCHES] 295-299 Allow changing chaining of the IPA CA certificate

2014-07-28 Thread Rob Crittenden
Jan Cholasta wrote: > On 22.7.2014 15:21, Rob Crittenden wrote: >> Rob Crittenden wrote: >>> Jan Cholasta wrote: On 2.7.2014 19:37, Jan Cholasta wrote: > On 2.7.2014 19:08, Rob Crittenden wrote: >> Trimming to respond to your questions. Not sure if this is related: #

Re: [Freeipa-devel] [PATCHES] 295-299 Allow changing chaining of the IPA CA certificate

2014-07-22 Thread Rob Crittenden
Rob Crittenden wrote: > Jan Cholasta wrote: >> On 2.7.2014 19:37, Jan Cholasta wrote: >>> On 2.7.2014 19:08, Rob Crittenden wrote: Trimming to respond to your questions. >> Not sure if this is related: >> # pki cert-find >> PKIException: Internal Server Error I'm pretty s

Re: [Freeipa-devel] [PATCHES] 295-299 Allow changing chaining of the IPA CA certificate

2014-07-03 Thread Rob Crittenden
Jan Cholasta wrote: > On 2.7.2014 19:37, Jan Cholasta wrote: >> On 2.7.2014 19:08, Rob Crittenden wrote: >>> Trimming to respond to your questions. > Not sure if this is related: > # pki cert-find > PKIException: Internal Server Error >>> >>> I'm pretty sure the cert-find error is relat

Re: [Freeipa-devel] [PATCHES] 295-299 Allow changing chaining of the IPA CA certificate

2014-07-02 Thread Jan Cholasta
On 2.7.2014 19:08, Rob Crittenden wrote: Trimming to respond to your questions. Not sure if this is related: # pki cert-find PKIException: Internal Server Error I'm pretty sure the cert-find error is related to the fact that I had a test build of dogtag installed, so that can be ignored. It

Re: [Freeipa-devel] [PATCHES] 295-299 Allow changing chaining of the IPA CA certificate

2014-07-02 Thread Rob Crittenden
Jan Cholasta wrote: > On 28.6.2014 00:19, Rob Crittenden wrote: >> >> I'm going to consolidate all reviews for 241 - 303 here. I'm not doing >> this in any particular order. Trimming to respond to your questions. >> Not sure if this is related: >> # pki cert-find >> PKIException: Internal Server E

Re: [Freeipa-devel] [PATCHES] 295-299 Allow changing chaining of the IPA CA certificate

2014-07-02 Thread Jan Cholasta
On 28.6.2014 00:19, Rob Crittenden wrote: I'm going to consolidate all reviews for 241 - 303 here. I'm not doing this in any particular order. OK, I will send further patches only in this thread. Missing man page for ipa-certupdate I did not want to delay the patch, so I have se

Re: [Freeipa-devel] [PATCHES] 295-299 Allow changing chaining of the IPA CA certificate

2014-06-30 Thread Nalin Dahyabhai
On Fri, Jun 27, 2014 at 06:19:25PM -0400, Rob Crittenden wrote: > How it is monitoring with a ca-error I don't know. If there's a previously-issued certificate present, the state machine goes back to "monitoring" rather than the dead-end "rejected" state, so that it'll try again later when certifi

Re: [Freeipa-devel] [PATCHES] 295-299 Allow changing chaining of the IPA CA certificate

2014-06-30 Thread Rob Crittenden
Rob Crittenden wrote: > Jan Cholasta wrote: >> On 26.6.2014 20:05, Rob Crittenden wrote: >>> Jan Cholasta wrote: On 16.6.2014 15:35, Jan Cholasta wrote: > Hi, > > the attached patches implement > . > > My patches 241-253 and

Re: [Freeipa-devel] [PATCHES] 295-299 Allow changing chaining of the IPA CA certificate

2014-06-26 Thread Rob Crittenden
Jan Cholasta wrote: > On 16.6.2014 15:35, Jan Cholasta wrote: >> Hi, >> >> the attached patches implement >> . >> >> My patches 241-253 and 262-294 are required for this >> (, >>

Re: [Freeipa-devel] [PATCHES] 295-299 Allow changing chaining of the IPA CA certificate

2014-06-26 Thread Jan Cholasta
On 16.6.2014 15:35, Jan Cholasta wrote: Hi, the attached patches implement . My patches 241-253 and 262-294 are required for this (,