Re: [Freeipa-devel] [PATCHES 0001-0005] Profile management commands

2015-05-13 Thread Martin Basti
On 13/05/15 10:06, Jan Cholasta wrote: Hi, Dne 5.5.2015 v 10:38 Martin Basti napsal(a): On 05/05/15 08:29, Fraser Tweedale wrote: On Mon, May 04, 2015 at 06:35:45PM +0200, Martin Basti wrote: On 04/05/15 15:36, Fraser Tweedale wrote: Hello, Please review the first cut of the 'certprofile'

Re: [Freeipa-devel] [PATCHES 0001-0005] Profile management commands

2015-05-13 Thread Fraser Tweedale
Hi Jan, thanks for review. Comments inline. On Wed, May 13, 2015 at 10:06:04AM +0200, Jan Cholasta wrote: Hi, Dne 5.5.2015 v 10:38 Martin Basti napsal(a): On 05/05/15 08:29, Fraser Tweedale wrote: On Mon, May 04, 2015 at 06:35:45PM +0200, Martin Basti wrote: On 04/05/15 15:36, Fraser

Re: [Freeipa-devel] [PATCHES 0001-0005] Profile management commands

2015-05-13 Thread Jan Cholasta
Dne 13.5.2015 v 11:41 Fraser Tweedale napsal(a): Hi Jan, thanks for review. Comments inline. On Wed, May 13, 2015 at 10:06:04AM +0200, Jan Cholasta wrote: 12) IMO the profile backend should be merged in to the ra backend. I don't see a need to have these two separate. I wasn't sure, so I

Re: [Freeipa-devel] [PATCHES 0001-0005] Profile management commands

2015-05-13 Thread Jan Cholasta
Dne 13.5.2015 v 10:36 Martin Basti napsal(a): On 13/05/15 10:06, Jan Cholasta wrote: Hi, Dne 5.5.2015 v 10:38 Martin Basti napsal(a): On 05/05/15 08:29, Fraser Tweedale wrote: On Mon, May 04, 2015 at 06:35:45PM +0200, Martin Basti wrote: On 04/05/15 15:36, Fraser Tweedale wrote: Hello,

Re: [Freeipa-devel] [PATCHES 0001-0005] Profile management commands

2015-05-13 Thread Fraser Tweedale
On Wed, May 13, 2015 at 01:19:49PM +0200, Jan Cholasta wrote: Dne 13.5.2015 v 11:41 Fraser Tweedale napsal(a): Hi Jan, thanks for review. Comments inline. On Wed, May 13, 2015 at 10:06:04AM +0200, Jan Cholasta wrote: 12) IMO the profile backend should be merged in to the ra backend. I don't

Re: [Freeipa-devel] [PATCHES 0001-0005] Profile management commands

2015-05-13 Thread Jan Cholasta
Hi, Dne 5.5.2015 v 10:38 Martin Basti napsal(a): On 05/05/15 08:29, Fraser Tweedale wrote: On Mon, May 04, 2015 at 06:35:45PM +0200, Martin Basti wrote: On 04/05/15 15:36, Fraser Tweedale wrote: Hello, Please review the first cut of the 'certprofile' command and other changes associated

Re: [Freeipa-devel] [PATCHES 0001-0005] Profile management commands

2015-05-05 Thread Fraser Tweedale
On Mon, May 04, 2015 at 06:35:45PM +0200, Martin Basti wrote: On 04/05/15 15:36, Fraser Tweedale wrote: Hello, Please review the first cut of the 'certprofile' command and other changes associated with the Certificate Profiles feature[1]. Custom profiles can't be used yet because

Re: [Freeipa-devel] [PATCHES 0001-0005] Profile management commands

2015-05-05 Thread Martin Basti
On 05/05/15 08:29, Fraser Tweedale wrote: On Mon, May 04, 2015 at 06:35:45PM +0200, Martin Basti wrote: On 04/05/15 15:36, Fraser Tweedale wrote: Hello, Please review the first cut of the 'certprofile' command and other changes associated with the Certificate Profiles feature[1]. Custom

Re: [Freeipa-devel] [PATCHES 0001-0005] Profile management commands

2015-05-04 Thread Martin Basti
On 04/05/15 15:36, Fraser Tweedale wrote: Hello, Please review the first cut of the 'certprofile' command and other changes associated with the Certificate Profiles feature[1]. Custom profiles can't be used yet because 'cert-request' has not been updated, but you can manage the profiles (find,