Re: [Freeipa-devel] [PATCHES 0005-0011] Fix some of the defects reported by covscan on freeipa-master

2015-01-30 Thread Lukas Slebodnik
On (29/01/15 12:57), Martin Babinsky wrote: Date: Wed, 28 Jan 2015 16:28:01 +0100 Subject: [PATCH 6/7] ipa-uuid: emit a message when unexpected mod type is encountered This patch is related to the following defect reported by covscan of FreeIPA master code: Error: DEADCODE (CWE-561):

Re: [Freeipa-devel] [PATCHES 0005-0011] Fix some of the defects reported by covscan on freeipa-master

2015-01-30 Thread Martin Kosek
On 01/29/2015 01:42 PM, Alexander Bokovoy wrote: On Thu, 29 Jan 2015, Martin Babinsky wrote: On 01/28/2015 06:30 PM, Alexander Bokovoy wrote: On Wed, 28 Jan 2015, Martin Babinsky wrote: On 01/28/2015 03:37 PM, Simo Sorce wrote: On Wed, 2015-01-28 at 14:53 +0100, Martin Babinsky wrote: On

Re: [Freeipa-devel] [PATCHES 0005-0011] Fix some of the defects reported by covscan on freeipa-master

2015-01-29 Thread Martin Babinsky
On 01/28/2015 06:30 PM, Alexander Bokovoy wrote: On Wed, 28 Jan 2015, Martin Babinsky wrote: On 01/28/2015 03:37 PM, Simo Sorce wrote: On Wed, 2015-01-28 at 14:53 +0100, Martin Babinsky wrote: On 01/27/2015 05:21 PM, Martin Babinsky wrote: This series of patches is related to

Re: [Freeipa-devel] [PATCHES 0005-0011] Fix some of the defects reported by covscan on freeipa-master

2015-01-29 Thread Alexander Bokovoy
On Thu, 29 Jan 2015, Martin Babinsky wrote: On 01/28/2015 06:30 PM, Alexander Bokovoy wrote: On Wed, 28 Jan 2015, Martin Babinsky wrote: On 01/28/2015 03:37 PM, Simo Sorce wrote: On Wed, 2015-01-28 at 14:53 +0100, Martin Babinsky wrote: On 01/27/2015 05:21 PM, Martin Babinsky wrote: This

Re: [Freeipa-devel] [PATCHES 0005-0011] Fix some of the defects reported by covscan on freeipa-master

2015-01-28 Thread Martin Babinsky
On 01/27/2015 05:21 PM, Martin Babinsky wrote: This series of patches is related to https://fedorahosted.org/freeipa/ticket/4795. The attached patches attempt to address some of the defects encountered during running covscan on freeipa-master branch. The complete list is here:

Re: [Freeipa-devel] [PATCHES 0005-0011] Fix some of the defects reported by covscan on freeipa-master

2015-01-28 Thread Simo Sorce
On Wed, 2015-01-28 at 14:53 +0100, Martin Babinsky wrote: On 01/27/2015 05:21 PM, Martin Babinsky wrote: This series of patches is related to https://fedorahosted.org/freeipa/ticket/4795. The attached patches attempt to address some of the defects encountered during running covscan on

Re: [Freeipa-devel] [PATCHES 0005-0011] Fix some of the defects reported by covscan on freeipa-master

2015-01-28 Thread Martin Babinsky
On 01/28/2015 12:11 PM, Alexander Bokovoy wrote: On Wed, 28 Jan 2015, Martin Babinsky wrote: can you pick this up as the way to fix this coverity issue ? Simo. Yes I will try to implement it and post all the updates ASAP. I have tried to incorporate Alexander's patch to the

Re: [Freeipa-devel] [PATCHES 0005-0011] Fix some of the defects reported by covscan on freeipa-master

2015-01-28 Thread Alexander Bokovoy
On Wed, 28 Jan 2015, Martin Babinsky wrote: On 01/28/2015 12:11 PM, Alexander Bokovoy wrote: On Wed, 28 Jan 2015, Martin Babinsky wrote: can you pick this up as the way to fix this coverity issue ? Simo. Yes I will try to implement it and post all the updates ASAP. I have tried to

Re: [Freeipa-devel] [PATCHES 0005-0011] Fix some of the defects reported by covscan on freeipa-master

2015-01-28 Thread Petr Spacek
On 27.1.2015 18:36, Martin Babinsky wrote: On 01/27/2015 06:05 PM, Petr Spacek wrote: On 27.1.2015 18:02, Alexander Bokovoy wrote: -slapi_search_internal_get_entry(sdn, attrs, entry, -otp_config_plugin_id(otp_config)); +search_result =

Re: [Freeipa-devel] [PATCHES 0005-0011] Fix some of the defects reported by covscan on freeipa-master

2015-01-28 Thread Martin Babinsky
On 01/28/2015 08:51 AM, Martin Babinsky wrote: On 01/27/2015 10:15 PM, Simo Sorce wrote: On Tue, 2015-01-27 at 23:04 +0200, Alexander Bokovoy wrote: On Tue, 27 Jan 2015, Simo Sorce wrote: On Tue, 2015-01-27 at 22:20 +0200, Alexander Bokovoy wrote: On Tue, 27 Jan 2015, Simo Sorce wrote: On

Re: [Freeipa-devel] [PATCHES 0005-0011] Fix some of the defects reported by covscan on freeipa-master

2015-01-28 Thread Alexander Bokovoy
On Wed, 28 Jan 2015, Martin Babinsky wrote: can you pick this up as the way to fix this coverity issue ? Simo. Yes I will try to implement it and post all the updates ASAP. I have tried to incorporate Alexander's patch to the 'ipa_kdb_principals.c'. However covscan is still not happy

Re: [Freeipa-devel] [PATCHES 0005-0011] Fix some of the defects reported by covscan on freeipa-master

2015-01-28 Thread Alexander Bokovoy
On Wed, 28 Jan 2015, Martin Babinsky wrote: On 01/28/2015 03:37 PM, Simo Sorce wrote: On Wed, 2015-01-28 at 14:53 +0100, Martin Babinsky wrote: On 01/27/2015 05:21 PM, Martin Babinsky wrote: This series of patches is related to https://fedorahosted.org/freeipa/ticket/4795. The attached

Re: [Freeipa-devel] [PATCHES 0005-0011] Fix some of the defects reported by covscan on freeipa-master

2015-01-28 Thread Simo Sorce
On Wed, 2015-01-28 at 16:46 +0100, Martin Babinsky wrote: On 01/28/2015 03:37 PM, Simo Sorce wrote: On Wed, 2015-01-28 at 14:53 +0100, Martin Babinsky wrote: On 01/27/2015 05:21 PM, Martin Babinsky wrote: This series of patches is related to https://fedorahosted.org/freeipa/ticket/4795.

Re: [Freeipa-devel] [PATCHES 0005-0011] Fix some of the defects reported by covscan on freeipa-master

2015-01-28 Thread Martin Babinsky
On 01/28/2015 03:37 PM, Simo Sorce wrote: On Wed, 2015-01-28 at 14:53 +0100, Martin Babinsky wrote: On 01/27/2015 05:21 PM, Martin Babinsky wrote: This series of patches is related to https://fedorahosted.org/freeipa/ticket/4795. The attached patches attempt to address some of the defects

Re: [Freeipa-devel] [PATCHES 0005-0011] Fix some of the defects reported by covscan on freeipa-master

2015-01-27 Thread Simo Sorce
On Tue, 2015-01-27 at 22:07 +0200, Alexander Bokovoy wrote: On Tue, 27 Jan 2015, Simo Sorce wrote: On Tue, 2015-01-27 at 18:04 +0100, Petr Spacek wrote: On 27.1.2015 17:56, Alexander Bokovoy wrote: On Tue, 27 Jan 2015, Martin Babinsky wrote: From 23a823c3c5933d5c14342e15c00599af74b84118

Re: [Freeipa-devel] [PATCHES 0005-0011] Fix some of the defects reported by covscan on freeipa-master

2015-01-27 Thread Alexander Bokovoy
On Tue, 27 Jan 2015, Petr Spacek wrote: I don't know this piece of code so I can't say anything in particular. Are you 100 % sure that it will not cause any harm in future? I'm hesitant to introduce a goto branching which is not testable nowadays. Personally I would prefer either assert() or

Re: [Freeipa-devel] [PATCHES 0005-0011] Fix some of the defects reported by covscan on freeipa-master

2015-01-27 Thread Alexander Bokovoy
On Tue, 27 Jan 2015, Simo Sorce wrote: On Tue, 2015-01-27 at 22:07 +0200, Alexander Bokovoy wrote: On Tue, 27 Jan 2015, Simo Sorce wrote: On Tue, 2015-01-27 at 18:04 +0100, Petr Spacek wrote: On 27.1.2015 17:56, Alexander Bokovoy wrote: On Tue, 27 Jan 2015, Martin Babinsky wrote: From

Re: [Freeipa-devel] [PATCHES 0005-0011] Fix some of the defects reported by covscan on freeipa-master

2015-01-27 Thread Simo Sorce
On Tue, 2015-01-27 at 22:20 +0200, Alexander Bokovoy wrote: On Tue, 27 Jan 2015, Simo Sorce wrote: On Tue, 2015-01-27 at 22:07 +0200, Alexander Bokovoy wrote: On Tue, 27 Jan 2015, Simo Sorce wrote: On Tue, 2015-01-27 at 18:04 +0100, Petr Spacek wrote: On 27.1.2015 17:56, Alexander Bokovoy

Re: [Freeipa-devel] [PATCHES 0005-0011] Fix some of the defects reported by covscan on freeipa-master

2015-01-27 Thread Simo Sorce
On Tue, 2015-01-27 at 23:04 +0200, Alexander Bokovoy wrote: On Tue, 27 Jan 2015, Simo Sorce wrote: On Tue, 2015-01-27 at 22:20 +0200, Alexander Bokovoy wrote: On Tue, 27 Jan 2015, Simo Sorce wrote: On Tue, 2015-01-27 at 22:07 +0200, Alexander Bokovoy wrote: On Tue, 27 Jan 2015, Simo Sorce

Re: [Freeipa-devel] [PATCHES 0005-0011] Fix some of the defects reported by covscan on freeipa-master

2015-01-27 Thread Alexander Bokovoy
On Tue, 27 Jan 2015, Simo Sorce wrote: On Tue, 2015-01-27 at 22:20 +0200, Alexander Bokovoy wrote: On Tue, 27 Jan 2015, Simo Sorce wrote: On Tue, 2015-01-27 at 22:07 +0200, Alexander Bokovoy wrote: On Tue, 27 Jan 2015, Simo Sorce wrote: On Tue, 2015-01-27 at 18:04 +0100, Petr Spacek wrote:

Re: [Freeipa-devel] [PATCHES 0005-0011] Fix some of the defects reported by covscan on freeipa-master

2015-01-27 Thread Alexander Bokovoy
On Tue, 27 Jan 2015, Simo Sorce wrote: On Tue, 2015-01-27 at 18:04 +0100, Petr Spacek wrote: On 27.1.2015 17:56, Alexander Bokovoy wrote: On Tue, 27 Jan 2015, Martin Babinsky wrote: From 23a823c3c5933d5c14342e15c00599af74b84118 Mon Sep 17 00:00:00 2001 From: Martin Babinsky

Re: [Freeipa-devel] [PATCHES 0005-0011] Fix some of the defects reported by covscan on freeipa-master

2015-01-27 Thread Martin Babinsky
On 01/27/2015 10:15 PM, Simo Sorce wrote: On Tue, 2015-01-27 at 23:04 +0200, Alexander Bokovoy wrote: On Tue, 27 Jan 2015, Simo Sorce wrote: On Tue, 2015-01-27 at 22:20 +0200, Alexander Bokovoy wrote: On Tue, 27 Jan 2015, Simo Sorce wrote: On Tue, 2015-01-27 at 22:07 +0200, Alexander Bokovoy

Re: [Freeipa-devel] [PATCHES 0005-0011] Fix some of the defects reported by covscan on freeipa-master

2015-01-27 Thread Petr Spacek
On 27.1.2015 17:56, Alexander Bokovoy wrote: On Tue, 27 Jan 2015, Martin Babinsky wrote: From 23a823c3c5933d5c14342e15c00599af74b84118 Mon Sep 17 00:00:00 2001 From: Martin Babinsky mbabi...@redhat.com Date: Tue, 27 Jan 2015 13:21:33 +0100 Subject: [PATCH 3/7] proposed fix fo a defect

Re: [Freeipa-devel] [PATCHES 0005-0011] Fix some of the defects reported by covscan on freeipa-master

2015-01-27 Thread Martin Babinsky
On 01/27/2015 06:05 PM, Petr Spacek wrote: On 27.1.2015 18:02, Alexander Bokovoy wrote: -slapi_search_internal_get_entry(sdn, attrs, entry, -otp_config_plugin_id(otp_config)); +search_result = slapi_search_internal_get_entry(sdn, attrs, entry, +

Re: [Freeipa-devel] [PATCHES 0005-0011] Fix some of the defects reported by covscan on freeipa-master

2015-01-27 Thread Petr Spacek
On 27.1.2015 18:23, Alexander Bokovoy wrote: On Tue, 27 Jan 2015, Petr Spacek wrote: On 27.1.2015 17:56, Alexander Bokovoy wrote: On Tue, 27 Jan 2015, Martin Babinsky wrote: From 23a823c3c5933d5c14342e15c00599af74b84118 Mon Sep 17 00:00:00 2001 From: Martin Babinsky mbabi...@redhat.com Date:

Re: [Freeipa-devel] [PATCHES 0005-0011] Fix some of the defects reported by covscan on freeipa-master

2015-01-27 Thread Petr Spacek
On 27.1.2015 18:02, Alexander Bokovoy wrote: -slapi_search_internal_get_entry(sdn, attrs, entry, -otp_config_plugin_id(otp_config)); +search_result = slapi_search_internal_get_entry(sdn, attrs, entry, +otp_config_plugin_id(otp_config));

Re: [Freeipa-devel] [PATCHES 0005-0011] Fix some of the defects reported by covscan on freeipa-master

2015-01-27 Thread Petr Spacek
On 27.1.2015 18:41, Alexander Bokovoy wrote: On Tue, 27 Jan 2015, Petr Spacek wrote: On 27.1.2015 18:23, Alexander Bokovoy wrote: On Tue, 27 Jan 2015, Petr Spacek wrote: On 27.1.2015 17:56, Alexander Bokovoy wrote: On Tue, 27 Jan 2015, Martin Babinsky wrote: From