Re: [Freeipa-devel] [PATCHES 0175-0176] New forward zone test cases
On 01/13/2015 02:36 PM, Tomas Babej wrote: > > On 01/13/2015 01:36 PM, Martin Basti wrote: >> On 13/01/15 10:04, Martin Kosek wrote: >>> On 01/12/2015 06:43 PM, Martin Basti wrote: On 05/01/15 16:18, Martin Basti wrote: > On 17/12/14 15:15, Martin Basti wrote: >> On 16/12/14 17:14, Martin Basti wrote: >>> On 15/12/14 20:15, Martin Basti wrote: On 15/12/14 19:18, Martin Basti wrote: > https://fedorahosted.org/freeipa/ticket/4750 > > Patches need rebase and minor pytest modification to apply on > master, I > will do that after review. > > Patches for ipa-4-1 attached. > > I forgot to fix copy paste error. Updated patches attached >>> Removed unneeded nsrecord validation in 2 tests >>> >>> updated patches attached >>> >> Added: >> >> * find forward zone with --forward-policy=none (no fwzone exists) >> * find forward zone with --forward-policy=only (no fwzone exists) >> * find forward zone with --forward-policy=first (no fwzone exists) >> * enable enabled zone >> * disable disabled zone >> >> Patches attached. >> >> > Hi Scott, could you ack or nack the patchset, other test tickets > are waiting, > and we want to avoid huge rebases/merging > From QA point of view, tests are OK. Can somebody do code review please? >>> Code looks OK, runs cleanly (except that I thought that wait_for_dns >>> is boolean >>> value and not an integer :-/) >>> >>> So ACK from me. After you prepare a version for master branch, we >>> can push them. >>> >>> Martin >> Rebased patches attached >> >> >> >> >> >> ___ >> Freeipa-devel mailing list >> Freeipa-devel@redhat.com >> https://www.redhat.com/mailman/listinfo/freeipa-devel > > Pushed to master: 92feba2223575856820c2b95beab88a5229b4f6e > > -- > Tomas Babej > Associate Software Engineer | Red Hat | Identity Management > RHCE | Brno Site | IRC: tbabej | freeipa.org Also pushed the 4.1 version: Pushed to ipa-4-1: 9f3b445ed39f4c1ecc3007136223d869fe9cf37b -- Tomas Babej Associate Software Engineer | Red Hat | Identity Management RHCE | Brno Site | IRC: tbabej | freeipa.org ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCHES 0175-0176] New forward zone test cases
On 01/13/2015 01:36 PM, Martin Basti wrote: > On 13/01/15 10:04, Martin Kosek wrote: >> On 01/12/2015 06:43 PM, Martin Basti wrote: >>> On 05/01/15 16:18, Martin Basti wrote: On 17/12/14 15:15, Martin Basti wrote: > On 16/12/14 17:14, Martin Basti wrote: >> On 15/12/14 20:15, Martin Basti wrote: >>> On 15/12/14 19:18, Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/4750 Patches need rebase and minor pytest modification to apply on master, I will do that after review. Patches for ipa-4-1 attached. >>> I forgot to fix copy paste error. >>> >>> Updated patches attached >>> >> Removed unneeded nsrecord validation in 2 tests >> >> updated patches attached >> > Added: > > * find forward zone with --forward-policy=none (no fwzone exists) > * find forward zone with --forward-policy=only (no fwzone exists) > * find forward zone with --forward-policy=first (no fwzone exists) > * enable enabled zone > * disable disabled zone > > Patches attached. > > Hi Scott, could you ack or nack the patchset, other test tickets are waiting, and we want to avoid huge rebases/merging >>> From QA point of view, tests are OK. Can somebody do code review >>> please? >> Code looks OK, runs cleanly (except that I thought that wait_for_dns >> is boolean >> value and not an integer :-/) >> >> So ACK from me. After you prepare a version for master branch, we can >> push them. >> >> Martin > Rebased patches attached > > > > > > ___ > Freeipa-devel mailing list > Freeipa-devel@redhat.com > https://www.redhat.com/mailman/listinfo/freeipa-devel Pushed to master: 92feba2223575856820c2b95beab88a5229b4f6e -- Tomas Babej Associate Software Engineer | Red Hat | Identity Management RHCE | Brno Site | IRC: tbabej | freeipa.org ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCHES 0175-0176] New forward zone test cases
On 01/12/2015 06:43 PM, Martin Basti wrote: > On 05/01/15 16:18, Martin Basti wrote: >> On 17/12/14 15:15, Martin Basti wrote: >>> On 16/12/14 17:14, Martin Basti wrote: On 15/12/14 20:15, Martin Basti wrote: > On 15/12/14 19:18, Martin Basti wrote: >> https://fedorahosted.org/freeipa/ticket/4750 >> >> Patches need rebase and minor pytest modification to apply on master, I >> will do that after review. >> >> Patches for ipa-4-1 attached. >> >> > I forgot to fix copy paste error. > > Updated patches attached > Removed unneeded nsrecord validation in 2 tests updated patches attached >>> Added: >>> >>> * find forward zone with --forward-policy=none (no fwzone exists) >>> * find forward zone with --forward-policy=only (no fwzone exists) >>> * find forward zone with --forward-policy=first (no fwzone exists) >>> * enable enabled zone >>> * disable disabled zone >>> >>> Patches attached. >>> >>> >> Hi Scott, could you ack or nack the patchset, other test tickets are waiting, >> and we want to avoid huge rebases/merging >> > From QA point of view, tests are OK. Can somebody do code review please? Code looks OK, runs cleanly (except that I thought that wait_for_dns is boolean value and not an integer :-/) So ACK from me. After you prepare a version for master branch, we can push them. Martin ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCHES 0175-0176] New forward zone test cases
On 05/01/15 16:18, Martin Basti wrote: On 17/12/14 15:15, Martin Basti wrote: On 16/12/14 17:14, Martin Basti wrote: On 15/12/14 20:15, Martin Basti wrote: On 15/12/14 19:18, Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/4750 Patches need rebase and minor pytest modification to apply on master, I will do that after review. Patches for ipa-4-1 attached. I forgot to fix copy paste error. Updated patches attached Removed unneeded nsrecord validation in 2 tests updated patches attached Added: * find forward zone with --forward-policy=none (no fwzone exists) * find forward zone with --forward-policy=only (no fwzone exists) * find forward zone with --forward-policy=first (no fwzone exists) * enable enabled zone * disable disabled zone Patches attached. Hi Scott, could you ack or nack the patchset, other test tickets are waiting, and we want to avoid huge rebases/merging From QA point of view, tests are OK. Can somebody do code review please? -- Martin Basti ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCHES 0175-0176] New forward zone test cases
On 17/12/14 15:15, Martin Basti wrote: On 16/12/14 17:14, Martin Basti wrote: On 15/12/14 20:15, Martin Basti wrote: On 15/12/14 19:18, Martin Basti wrote: https://fedorahosted.org/freeipa/ticket/4750 Patches need rebase and minor pytest modification to apply on master, I will do that after review. Patches for ipa-4-1 attached. I forgot to fix copy paste error. Updated patches attached Removed unneeded nsrecord validation in 2 tests updated patches attached Added: * find forward zone with --forward-policy=none (no fwzone exists) * find forward zone with --forward-policy=only (no fwzone exists) * find forward zone with --forward-policy=first (no fwzone exists) * enable enabled zone * disable disabled zone Patches attached. Hi Scott, could you ack or nack the patchset, other test tickets are waiting, and we want to avoid huge rebases/merging -- Martin Basti ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [PATCHES 0175-0176] New forward zone test cases
On 16/12/14 17:14, Martin Basti wrote:
On 15/12/14 20:15, Martin Basti wrote:
On 15/12/14 19:18, Martin Basti wrote:
https://fedorahosted.org/freeipa/ticket/4750
Patches need rebase and minor pytest modification to apply on
master, I will do that after review.
Patches for ipa-4-1 attached.
I forgot to fix copy paste error.
Updated patches attached
Removed unneeded nsrecord validation in 2 tests
updated patches attached
Added:
* find forward zone with --forward-policy=none (no fwzone exists)
* find forward zone with --forward-policy=only (no fwzone exists)
* find forward zone with --forward-policy=first (no fwzone exists)
* enable enabled zone
* disable disabled zone
Patches attached.
--
Martin Basti
From 881fb066d390e1969c83cf278e3df603dc576628 Mon Sep 17 00:00:00 2001
From: Martin Basti
Date: Fri, 5 Dec 2014 16:12:54 +0100
Subject: [PATCH 1/2] DNS tests: separate current forward zone tests
Ticket: https://fedorahosted.org/freeipa/ticket/4750
---
ipatests/test_xmlrpc/test_dns_plugin.py | 764 ++--
1 file changed, 438 insertions(+), 326 deletions(-)
diff --git a/ipatests/test_xmlrpc/test_dns_plugin.py b/ipatests/test_xmlrpc/test_dns_plugin.py
index fb53853147ecf663cf7015867131445f32364cfb..16b69e4514abb0e3f257b9e16047db05e30548bd 100644
--- a/ipatests/test_xmlrpc/test_dns_plugin.py
+++ b/ipatests/test_xmlrpc/test_dns_plugin.py
@@ -290,6 +290,21 @@ zone_findtest_forward_dn = DN(('idnsname', zone_findtest_forward), api.env.conta
zone_fw_wildcard = u'*.wildcardforwardzone.test.'
+zone_root = u'.'
+zone_root_dnsname = DNSName(zone_root)
+zone_root_ip = u'172.16.29.222'
+zone_root_dn = DN(('idnsname', zone_root),
+ api.env.container_dns, api.env.basedn)
+zone_root_ns = u'ns'
+zone_root_ns_dnsname = DNSName(zone_root_ns)
+zone_root_ns_dn = DN(('idnsname', zone_root_ns), zone_root_dn)
+zone_root_rname = u'root.example.com.'
+zone_root_rname_dnsname = DNSName(zone_root_rname)
+zone_root_permission = u'Manage DNS zone %s' % zone_root
+zone_root_permission_dn = DN(('cn', zone_root_permission),
+ api.env.container_permission, api.env.basedn)
+
+
def _get_nameservers_ldap(conn):
base_dn = DN(('cn', 'masters'), ('cn', 'ipa'), ('cn', 'etc'), api.env.basedn)
ldap_filter = '(&(objectClass=ipaConfigObject)(cn=DNS))'
@@ -359,17 +374,13 @@ class test_dns(Declarative):
cleanup_commands = [
('dnszone_del', [zone1, zone2, zone3, zone4, zone5, revzone1, revzone2,
revzone3_classless1, revzone3_classless2,
- idnzone1, revidnzone1, zone_findtest_master],
-{'continue': True}),
-('dnsforwardzone_del', [fwzone1, zone_findtest_forward,
-zone_fw_wildcard],
+ idnzone1, revidnzone1],
{'continue': True}),
('dnsconfig_mod', [], {'idnsforwarders' : None,
'idnsforwardpolicy' : None,
'idnsallowsyncptr' : None,
}),
('permission_del', [zone1_permission, idnzone1_permission,
-fwzone1_permission,
revzone3_classless2_permission], {'force': True}
),
]
@@ -2841,6 +2852,280 @@ class test_dns(Declarative):
dict(
+desc='Disable zone %r' % zone1,
+command=('dnszone_disable', [zone1], {}),
+expected={
+'value': zone1_absolute_dnsname,
+'summary': u'Disabled DNS zone "%s"' % zone1_absolute,
+'result': True,
+},
+),
+
+
+dict(
+desc='Check if zone %r is really disabled' % zone1,
+command=('dnszone_show', [zone1], {}),
+expected={
+'value': zone1_absolute_dnsname,
+'summary': None,
+'result': {
+'dn': zone1_dn,
+'idnsname': [zone1_absolute_dnsname],
+'idnszoneactive': [u'FALSE'],
+'nsrecord': nameservers,
+'idnssoamname': [self_server_ns_dnsname],
+'idnssoarname': [zone1_rname_dnsname],
+'idnssoaserial': [fuzzy_digits],
+'idnssoarefresh': [fuzzy_digits],
+'idnssoaretry': [fuzzy_digits],
+'idnssoaexpire': [fuzzy_digits],
+'idnssoaminimum': [fuzzy_digits],
+'idnsallowtransfer': [u'172.16.31.80;'],
+'idnsallowquery': [u'!192.0.2.0/24;any;'],
+'mxrecord': [u'0 ns1.dnszone.test.'],
+'locrecord': [u"49 11 42.400 N 16 36 29.600 E 227.64 10.00 10.00 0.10"],
+},
+},
+),
+
+
+dict(
+desc='Enable zone %r' % zone1,
+command=('dnszone_enable', [zone1], {}),
+
Re: [Freeipa-devel] [PATCHES 0175-0176] New forward zone test cases
On 15/12/14 20:15, Martin Basti wrote:
On 15/12/14 19:18, Martin Basti wrote:
https://fedorahosted.org/freeipa/ticket/4750
Patches need rebase and minor pytest modification to apply on master,
I will do that after review.
Patches for ipa-4-1 attached.
I forgot to fix copy paste error.
Updated patches attached
Removed unneeded nsrecord validation in 2 tests
updated patches attached
--
Martin Basti
From 881fb066d390e1969c83cf278e3df603dc576628 Mon Sep 17 00:00:00 2001
From: Martin Basti
Date: Fri, 5 Dec 2014 16:12:54 +0100
Subject: [PATCH 1/2] DNS tests: separate current forward zone tests
Ticket: https://fedorahosted.org/freeipa/ticket/4750
---
ipatests/test_xmlrpc/test_dns_plugin.py | 764 ++--
1 file changed, 438 insertions(+), 326 deletions(-)
diff --git a/ipatests/test_xmlrpc/test_dns_plugin.py b/ipatests/test_xmlrpc/test_dns_plugin.py
index fb53853147ecf663cf7015867131445f32364cfb..16b69e4514abb0e3f257b9e16047db05e30548bd 100644
--- a/ipatests/test_xmlrpc/test_dns_plugin.py
+++ b/ipatests/test_xmlrpc/test_dns_plugin.py
@@ -290,6 +290,21 @@ zone_findtest_forward_dn = DN(('idnsname', zone_findtest_forward), api.env.conta
zone_fw_wildcard = u'*.wildcardforwardzone.test.'
+zone_root = u'.'
+zone_root_dnsname = DNSName(zone_root)
+zone_root_ip = u'172.16.29.222'
+zone_root_dn = DN(('idnsname', zone_root),
+ api.env.container_dns, api.env.basedn)
+zone_root_ns = u'ns'
+zone_root_ns_dnsname = DNSName(zone_root_ns)
+zone_root_ns_dn = DN(('idnsname', zone_root_ns), zone_root_dn)
+zone_root_rname = u'root.example.com.'
+zone_root_rname_dnsname = DNSName(zone_root_rname)
+zone_root_permission = u'Manage DNS zone %s' % zone_root
+zone_root_permission_dn = DN(('cn', zone_root_permission),
+ api.env.container_permission, api.env.basedn)
+
+
def _get_nameservers_ldap(conn):
base_dn = DN(('cn', 'masters'), ('cn', 'ipa'), ('cn', 'etc'), api.env.basedn)
ldap_filter = '(&(objectClass=ipaConfigObject)(cn=DNS))'
@@ -359,17 +374,13 @@ class test_dns(Declarative):
cleanup_commands = [
('dnszone_del', [zone1, zone2, zone3, zone4, zone5, revzone1, revzone2,
revzone3_classless1, revzone3_classless2,
- idnzone1, revidnzone1, zone_findtest_master],
-{'continue': True}),
-('dnsforwardzone_del', [fwzone1, zone_findtest_forward,
-zone_fw_wildcard],
+ idnzone1, revidnzone1],
{'continue': True}),
('dnsconfig_mod', [], {'idnsforwarders' : None,
'idnsforwardpolicy' : None,
'idnsallowsyncptr' : None,
}),
('permission_del', [zone1_permission, idnzone1_permission,
-fwzone1_permission,
revzone3_classless2_permission], {'force': True}
),
]
@@ -2841,6 +2852,280 @@ class test_dns(Declarative):
dict(
+desc='Disable zone %r' % zone1,
+command=('dnszone_disable', [zone1], {}),
+expected={
+'value': zone1_absolute_dnsname,
+'summary': u'Disabled DNS zone "%s"' % zone1_absolute,
+'result': True,
+},
+),
+
+
+dict(
+desc='Check if zone %r is really disabled' % zone1,
+command=('dnszone_show', [zone1], {}),
+expected={
+'value': zone1_absolute_dnsname,
+'summary': None,
+'result': {
+'dn': zone1_dn,
+'idnsname': [zone1_absolute_dnsname],
+'idnszoneactive': [u'FALSE'],
+'nsrecord': nameservers,
+'idnssoamname': [self_server_ns_dnsname],
+'idnssoarname': [zone1_rname_dnsname],
+'idnssoaserial': [fuzzy_digits],
+'idnssoarefresh': [fuzzy_digits],
+'idnssoaretry': [fuzzy_digits],
+'idnssoaexpire': [fuzzy_digits],
+'idnssoaminimum': [fuzzy_digits],
+'idnsallowtransfer': [u'172.16.31.80;'],
+'idnsallowquery': [u'!192.0.2.0/24;any;'],
+'mxrecord': [u'0 ns1.dnszone.test.'],
+'locrecord': [u"49 11 42.400 N 16 36 29.600 E 227.64 10.00 10.00 0.10"],
+},
+},
+),
+
+
+dict(
+desc='Enable zone %r' % zone1,
+command=('dnszone_enable', [zone1], {}),
+expected={
+'value': zone1_absolute_dnsname,
+'summary': u'Enabled DNS zone "%s"' % zone1_absolute,
+'result': True,
+},
+),
+
+
+dict(
+desc='Check if zone %r is really enabled' % zone1,
+command=('dnszon
Re: [Freeipa-devel] [PATCHES 0175-0176] New forward zone test cases
On 15/12/14 19:18, Martin Basti wrote:
https://fedorahosted.org/freeipa/ticket/4750
Patches need rebase and minor pytest modification to apply on master,
I will do that after review.
Patches for ipa-4-1 attached.
I forgot to fix copy paste error.
Updated patches attached
--
Martin Basti
From 74c21768cbf33b14e099cc2cdad39fb67ba7fca8 Mon Sep 17 00:00:00 2001
From: Martin Basti
Date: Fri, 5 Dec 2014 16:12:54 +0100
Subject: [PATCH 1/2] DNS tests: separate current forward zone tests
Ticket: https://fedorahosted.org/freeipa/ticket/4750
---
ipatests/test_xmlrpc/test_dns_plugin.py | 748 ++--
1 file changed, 432 insertions(+), 316 deletions(-)
diff --git a/ipatests/test_xmlrpc/test_dns_plugin.py b/ipatests/test_xmlrpc/test_dns_plugin.py
index fb53853147ecf663cf7015867131445f32364cfb..422f7ebd17e84488783ab13d31c7d6fc63a485c8 100644
--- a/ipatests/test_xmlrpc/test_dns_plugin.py
+++ b/ipatests/test_xmlrpc/test_dns_plugin.py
@@ -290,6 +290,21 @@ zone_findtest_forward_dn = DN(('idnsname', zone_findtest_forward), api.env.conta
zone_fw_wildcard = u'*.wildcardforwardzone.test.'
+zone_root = u'.'
+zone_root_dnsname = DNSName(zone_root)
+zone_root_ip = u'172.16.29.222'
+zone_root_dn = DN(('idnsname', zone_root),
+ api.env.container_dns, api.env.basedn)
+zone_root_ns = u'ns'
+zone_root_ns_dnsname = DNSName(zone_root_ns)
+zone_root_ns_dn = DN(('idnsname', zone_root_ns), zone_root_dn)
+zone_root_rname = u'root.example.com.'
+zone_root_rname_dnsname = DNSName(zone_root_rname)
+zone_root_permission = u'Manage DNS zone %s' % zone_root
+zone_root_permission_dn = DN(('cn', zone_root_permission),
+ api.env.container_permission, api.env.basedn)
+
+
def _get_nameservers_ldap(conn):
base_dn = DN(('cn', 'masters'), ('cn', 'ipa'), ('cn', 'etc'), api.env.basedn)
ldap_filter = '(&(objectClass=ipaConfigObject)(cn=DNS))'
@@ -359,17 +374,13 @@ class test_dns(Declarative):
cleanup_commands = [
('dnszone_del', [zone1, zone2, zone3, zone4, zone5, revzone1, revzone2,
revzone3_classless1, revzone3_classless2,
- idnzone1, revidnzone1, zone_findtest_master],
-{'continue': True}),
-('dnsforwardzone_del', [fwzone1, zone_findtest_forward,
-zone_fw_wildcard],
+ idnzone1, revidnzone1],
{'continue': True}),
('dnsconfig_mod', [], {'idnsforwarders' : None,
'idnsforwardpolicy' : None,
'idnsallowsyncptr' : None,
}),
('permission_del', [zone1_permission, idnzone1_permission,
-fwzone1_permission,
revzone3_classless2_permission], {'force': True}
),
]
@@ -2841,6 +2852,280 @@ class test_dns(Declarative):
dict(
+desc='Disable zone %r' % zone1,
+command=('dnszone_disable', [zone1], {}),
+expected={
+'value': zone1_absolute_dnsname,
+'summary': u'Disabled DNS zone "%s"' % zone1_absolute,
+'result': True,
+},
+),
+
+
+dict(
+desc='Check if zone %r is really disabled' % zone1,
+command=('dnszone_show', [zone1], {}),
+expected={
+'value': zone1_absolute_dnsname,
+'summary': None,
+'result': {
+'dn': zone1_dn,
+'idnsname': [zone1_absolute_dnsname],
+'idnszoneactive': [u'FALSE'],
+'nsrecord': nameservers,
+'idnssoamname': [self_server_ns_dnsname],
+'idnssoarname': [zone1_rname_dnsname],
+'idnssoaserial': [fuzzy_digits],
+'idnssoarefresh': [fuzzy_digits],
+'idnssoaretry': [fuzzy_digits],
+'idnssoaexpire': [fuzzy_digits],
+'idnssoaminimum': [fuzzy_digits],
+'idnsallowtransfer': [u'172.16.31.80;'],
+'idnsallowquery': [u'!192.0.2.0/24;any;'],
+'mxrecord': [u'0 ns1.dnszone.test.'],
+'locrecord': [u"49 11 42.400 N 16 36 29.600 E 227.64 10.00 10.00 0.10"],
+},
+},
+),
+
+
+dict(
+desc='Enable zone %r' % zone1,
+command=('dnszone_enable', [zone1], {}),
+expected={
+'value': zone1_absolute_dnsname,
+'summary': u'Enabled DNS zone "%s"' % zone1_absolute,
+'result': True,
+},
+),
+
+
+dict(
+desc='Check if zone %r is really enabled' % zone1,
+command=('dnszone_show', [zone1_absolute], {}),
+expected={
+'value': zone1_absolute_dnsname,
+
