Re: [Freeipa-devel] [PATCHES 0204-0207] Server upgrade: Make LDAP data upgrade deterministic

2015-03-12 Thread David Kupka

On 03/06/2015 04:50 PM, Martin Basti wrote:

The patchset ensure, the upgrade order will respect ordering of entries
in *.update files.

Required for: https://fedorahosted.org/freeipa/ticket/4904

Patch 205 also fixes https://fedorahosted.org/freeipa/ticket/3560

Required patch mbasti-0203

Patches attached.




Changes in code looks good and the upgrade process still works, ACK.

--
David Kupka

--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code


Re: [Freeipa-devel] [PATCHES 0204-0207] Server upgrade: Make LDAP data upgrade deterministic

2015-03-12 Thread Rob Crittenden
Martin Basti wrote:
 The patchset ensure, the upgrade order will respect ordering of entries
 in *.update files.
 
 Required for: https://fedorahosted.org/freeipa/ticket/4904
 
 Patch 205 also fixes https://fedorahosted.org/freeipa/ticket/3560
 
 Required patch mbasti-0203
 
 Patches attached.
 
 
 

Just reading the patches, untested.

I think ordered should default to True in the update() method of
ldapupdater to keep in spirit with the design.

Otherwise LGTM that it implements what was designed.

rob


-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code