Re: [Freeipa-devel] [TEST][patch-0033] Added assertion errors to topology tests, track N 5772

2016-04-20 Thread Martin Basti
On 12.04.2016 16:15, Martin Babinsky wrote: On 04/06/2016 02:40 PM, Oleg Fayans wrote: Hi Martin, The updated patches are attached On 04/04/2016 06:46 PM, Martin Babinsky wrote: On 03/31/2016 05:15 PM, Oleg Fayans wrote: Hi Martin, Thanks for the review. The updated patch(es) are included

Re: [Freeipa-devel] [TEST][patch-0033] Added assertion errors to topology tests, track N 5772

2016-04-12 Thread Martin Babinsky
On 04/06/2016 02:40 PM, Oleg Fayans wrote: Hi Martin, The updated patches are attached On 04/04/2016 06:46 PM, Martin Babinsky wrote: On 03/31/2016 05:15 PM, Oleg Fayans wrote: Hi Martin, Thanks for the review. The updated patch(es) are included Testrun output can be found here: http://fpa

Re: [Freeipa-devel] [TEST][patch-0033] Added assertion errors to topology tests, track N 5772

2016-04-06 Thread Oleg Fayans
Hi Martin, The updated patches are attached On 04/04/2016 06:46 PM, Martin Babinsky wrote: > On 03/31/2016 05:15 PM, Oleg Fayans wrote: >> Hi Martin, >> >> Thanks for the review. The updated patch(es) are included >> >> Testrun output can be found here: >> >> http://fpaste.org/347800/59421745/ >>

Re: [Freeipa-devel] [TEST][patch-0033] Added assertion errors to topology tests, track N 5772

2016-04-04 Thread Martin Babinsky
On 03/31/2016 05:15 PM, Oleg Fayans wrote: Hi Martin, Thanks for the review. The updated patch(es) are included Testrun output can be found here: http://fpaste.org/347800/59421745/ On 03/31/2016 01:10 PM, Martin Basti wrote: On 31.03.2016 12:07, Oleg Fayans wrote: Please, disregard it for

Re: [Freeipa-devel] [TEST][patch-0033] Added assertion errors to topology tests, track N 5772

2016-03-31 Thread Oleg Fayans
Hi Martin, Thanks for the review. The updated patch(es) are included Testrun output can be found here: http://fpaste.org/347800/59421745/ On 03/31/2016 01:10 PM, Martin Basti wrote: > > > On 31.03.2016 12:07, Oleg Fayans wrote: >> Please, disregard it for a while, it does not pass lint. >> >>

Re: [Freeipa-devel] [TEST][patch-0033] Added assertion errors to topology tests, track N 5772

2016-03-31 Thread Martin Basti
On 31.03.2016 12:07, Oleg Fayans wrote: Please, disregard it for a while, it does not pass lint. On 03/31/2016 12:05 PM, Oleg Fayans wrote: NACK Please send unrelated changes in separate patches. I do not see relation between changing variable names, adding assertion messages and setting

Re: [Freeipa-devel] [TEST][patch-0033] Added assertion errors to topology tests, track N 5772

2016-03-31 Thread Oleg Fayans
Please, disregard it for a while, it does not pass lint. On 03/31/2016 12:05 PM, Oleg Fayans wrote: > > > -- Oleg Fayans Quality Engineer FreeIPA team RedHat. -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to