Re: [Freeipa-devel] [WIP] ipapython/iputil.py refactoring for better cross-platform support
On 20.07.2011 21:59, John Dennis wrote: > On 07/20/2011 01:30 PM, Alexander Bokovoy wrote: >> Actual value is substituted using top-level Makefile's >> SUPPORTED_PLAFTORM= variable (defaults to 'redhat', can be redefined >> without modifying Makefile, in package building scripts, for example) >> and then ipapython/services.py is generated from ipapython/services.py.in > > Why can't the platform be resolved at runtime instead of part of a > static build? That would be more flexible wouldn't it? We would ship the > same code in each release which is a win for robustness and > reproducibility. I guess I don't see the advantage of static build time > code selection in a language like Python. The reason for it is that runtime platform selection simply gives no advantages in IPA case. A typical deployment is a distribution of a prepared package to multiple clients, not building freeipa code on every single client with a purpose to run ipa-client-install on it. At this point we already know the platform. Replacing this knowledge with run-time detection that can go wrong and would require more extensive knowledge and effort to verify that platform is detected reliably isn't really productive. > Earlier you said: > >> I'll try to avoid using package management tools > > but since you're relying on build tools you're implicitly relying on > package management tools. I was talking about using package management tools in runtime where one would incur computational costs. In proposed solution I'm trying to delegate a decision point to a package maintainer or a developer which already knows a platform s/he works with. There is no runtime overhead at all and single make SUPPORTED_PLATFORM=foobar would be equivalent to already utilised make -- / Alexander Bokovoy ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [WIP] ipapython/iputil.py refactoring for better cross-platform support
On 07/20/2011 01:30 PM, Alexander Bokovoy wrote: Actual value is substituted using top-level Makefile's SUPPORTED_PLAFTORM= variable (defaults to 'redhat', can be redefined without modifying Makefile, in package building scripts, for example) and then ipapython/services.py is generated from ipapython/services.py.in Why can't the platform be resolved at runtime instead of part of a static build? That would be more flexible wouldn't it? We would ship the same code in each release which is a win for robustness and reproducibility. I guess I don't see the advantage of static build time code selection in a language like Python. Earlier you said: > I'll try to avoid using package management tools but since you're relying on build tools you're implicitly relying on package management tools. -- John Dennis Looking to carve out IT costs? www.redhat.com/carveoutcosts/ ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [WIP] ipapython/iputil.py refactoring for better cross-platform support
On Wed, 2011-07-20 at 20:36 +0300, Alexander Bokovoy wrote: > On 20.07.2011 20:30, Alexander Bokovoy wrote: > > I moved existing code to ipapython/platform/redhat.py. > > ipapython/services.py is auto-generated and basically is one-liner: > > = > > from ipapython.platform. import * > > = > > > > Actual value is substituted using top-level Makefile's > > SUPPORTED_PLAFTORM= variable (defaults to 'redhat', can be redefined > > without modifying Makefile, in package building scripts, for example) > > and then ipapython/services.py is generated from ipapython/services.py.in > The original patch misses ipapython/services.py.in. I'll update patch > but the file is really one-liner (attached). The direction looks good to me, please keep on. Simo. -- Simo Sorce * Red Hat, Inc * New York ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
Re: [Freeipa-devel] [WIP] ipapython/iputil.py refactoring for better cross-platform support
On 20.07.2011 20:30, Alexander Bokovoy wrote: > I moved existing code to ipapython/platform/redhat.py. > ipapython/services.py is auto-generated and basically is one-liner: > = > from ipapython.platform. import * > = > > Actual value is substituted using top-level Makefile's > SUPPORTED_PLAFTORM= variable (defaults to 'redhat', can be redefined > without modifying Makefile, in package building scripts, for example) > and then ipapython/services.py is generated from ipapython/services.py.in The original patch misses ipapython/services.py.in. I'll update patch but the file is really one-liner (attached). -- / Alexander Bokovoy from ipapython.platform.SUPPORTED_PLATFORM import * ___ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
